void dot_add_task(Agnode_t * dag_node);
void dot_add_input_dependencies(SD_task_t current_job, Agedge_t * edge);
void dot_add_output_dependencies(SD_task_t current_job, Agedge_t * edge);
-bool child_are_marked(SD_task_t task);
-xbt_dynar_t SD_dotload_FILE(FILE * in_file);
+xbt_dynar_t SD_dotload_generic(const char * filename);
static double dot_parse_double(const char *string)
{
- if (string == NULL)
- return -1;
- int ret = 0;
- double value = -1;
-
- ret = sscanf(string, "%lg", &value);
- if (ret != 1)
- WARN1("%s is not a double", string);
- return value;
+ if (string == NULL)
+ return -1;
+ double value = -1;
+ char *err;
+
+ //ret = sscanf(string, "%lg", &value);
+ errno = 0;
+ value = strtod(string,&err);
+ if(errno)
+ {
+ XBT_WARN("Failed to convert string to double: %s\n",strerror(errno));
+ return -1;
+ }
+ return value;
}
+
static int dot_parse_int(const char *string)
{
if (string == NULL)
ret = sscanf(string, "%d", &value);
if (ret != 1)
- WARN1("%s is not an integer", string);
+ XBT_WARN("%s is not an integer", string);
return value;
}
unsigned int cursor;
SD_task_t task;
xbt_dynar_foreach(result, cursor, task) {
- INFO1("Task %d", cursor);
+ XBT_INFO("Task %d", cursor);
SD_task_dump(task);
}
}
-bool child_are_marked(SD_task_t task){
- SD_task_t child_task = NULL;
- bool all_marked = true;
- SD_dependency_t depafter = NULL;
- unsigned int count;
- xbt_dynar_foreach(task->tasks_after,count,depafter){
- child_task = depafter->dst;
- //test marked
- if(child_task->marked == 0) {
- all_marked = false;
- break;
- }
- child_task = NULL;
- }
- return all_marked;
-}
-
-bool acyclic_graph_detection(xbt_dynar_t dag){
- unsigned int count=0, count_current=0;
- bool all_marked = true;
- SD_task_t task = NULL, parent_task = NULL;
- SD_dependency_t depbefore = NULL;
- xbt_dynar_t next = NULL, current = xbt_dynar_new(sizeof(SD_task_t),NULL);
-
- xbt_dynar_foreach(dag,count,task){
- if(task->kind == SD_TASK_COMM_E2E) continue;
- task->marked = 0;
- if(xbt_dynar_length(task->tasks_after) == 0){
- xbt_dynar_push(current, &task);
- }
- }
- task = NULL;
- count = 0;
- //test if something has to be done for the next iteration
- while(xbt_dynar_length(current) != 0){
- next = xbt_dynar_new(sizeof(SD_task_t),NULL);
- //test if the current iteration is done
- count_current=0;
- xbt_dynar_foreach(current,count_current,task){
- if (task == NULL) continue;
- count = 0;
- //push task in next
- task->marked = 1;
- count = 0;
- xbt_dynar_foreach(task->tasks_before,count,depbefore){
- parent_task = depbefore->src;
- if(parent_task->kind == SD_TASK_COMM_E2E){
- unsigned int j=0;
- parent_task->marked = 1;
- xbt_dynar_foreach(parent_task->tasks_before,j,depbefore){
- parent_task = depbefore->src;
- if(child_are_marked(parent_task))
- xbt_dynar_push(next, &parent_task);
- }
- } else{
- if(child_are_marked(parent_task))
- xbt_dynar_push(next, &parent_task);
- }
- parent_task = NULL;
- }
- task = NULL;
- count = 0;
- }
- xbt_dynar_free(¤t);
- current = next;
- next = NULL;
- }
- xbt_dynar_free(¤t);
- current = NULL;
- all_marked = true;
- xbt_dynar_foreach(dag,count,task){
- if(task->kind == SD_TASK_COMM_E2E) continue;
- //test if all tasks are marked
- if(task->marked == 0){
- WARN1("the task %s is not marked",task->name);
- all_marked = false;
- break;
- }
- }
- task = NULL;
- if(!all_marked){
- VERB0("there is at least one cycle in your task graph");
- }
- return all_marked;
-}
static void dot_task_free(void *task)
{
*/
xbt_dynar_t SD_dotload(const char *filename)
{
- FILE *in_file = fopen(filename, "r");
- xbt_assert1(in_file, "Unable to open \"%s\"\n", filename);
- SD_dotload_FILE(in_file);
- fclose(in_file);
+ SD_dotload_generic(filename);
xbt_dynar_t computer = NULL;
xbt_dict_cursor_t dict_cursor;
char *computer_name;
}
xbt_dynar_t SD_dotload_with_sched(const char *filename){
- FILE *in_file = fopen(filename, "r");
- xbt_assert1(in_file, "Unable to open \"%s\"\n", filename);
- SD_dotload_FILE(in_file);
- fclose(in_file);
+ SD_dotload_generic(filename);
if(schedule == true){
xbt_dynar_t computer = NULL;
xbt_dynar_free(&computer);
}
xbt_dict_free(&computers);
- if(acyclic_graph_detection(result))
+ if(acyclic_graph_detail(result))
return result;
else
- WARN0("There is at least one cycle in the provided task graph");
+ XBT_WARN("There is at least one cycle in the provided task graph");
}else{
- WARN0("The scheduling is ignored");
+ XBT_WARN("The scheduling is ignored");
}
return NULL;
}
-xbt_dynar_t SD_dotload_FILE(FILE * in_file)
+xbt_dynar_t SD_dotload_generic(const char * filename)
{
- xbt_assert0(in_file, "Unable to use a null file descriptor\n");
+ xbt_assert(filename, "Unable to use a null file descriptor\n");
+//dag_dot = agopen((char*)filename,Agstrictdirected,0);
+ FILE *in_file = fopen(filename, "r");
dag_dot = agread(in_file, NIL(Agdisc_t *));
result = xbt_dynar_new(sizeof(SD_task_t), dot_task_free);
xbt_dynar_foreach(file->tasks_before, cpt1, depbefore) {
xbt_dynar_foreach(file->tasks_after, cpt2, depafter) {
if (depbefore->src == depafter->dst) {
- WARN2
+ XBT_WARN
("File %s is produced and consumed by task %s. This loop dependency will prevent the execution of the task.",
file->name, depbefore->src->name);
}
/* Free previous copy of the files */
xbt_dict_free(&files);
- if(acyclic_graph_detection(result))
+ fclose(in_file);
+ if(acyclic_graph_detail(result))
return result;
+ acyclic_graph_detail(result);
+ free(dag_dot);
return NULL;
}
SD_task_t current_job;
double runtime = dot_parse_double(agget(dag_node, (char *) "size"));
- DEBUG3("See <job id=%s runtime=%s %.0f>", name,
+ XBT_DEBUG("See <job id=%s runtime=%s %.0f>", name,
agget(dag_node, (char *) "size"), runtime);
current_job = xbt_dict_get_or_null(jobs, name);
if (current_job == NULL) {
if (char_order != NULL)
order = (long) dot_parse_int(char_order);
xbt_dynar_t computer = NULL;
- //INFO2("performer = %d, order=%d",performer,order);
+ //XBT_INFO("performer = %d, order=%d",performer,order);
if(performer != -1 && order != -1){
//necessary parameters are given
computer = xbt_dict_get_or_null(computers, char_performer);
computer = xbt_dynar_new(sizeof(SD_task_t), NULL);
xbt_dict_set(computers, char_performer, computer, NULL);
}
- if(performer < sd_global->workstation_count){
+ if(performer < xbt_lib_length(host_lib)){
// the wanted computer is available
SD_task_t *task_test = NULL;
if(order < computer->used)
if(task_test != NULL && *task_test != NULL && *task_test != current_job){
/*the user gives the same order to several tasks*/
schedule = false;
- VERB4("The task %s starts on the computer %s at the position : %s like the task %s",
+ XBT_VERB("The task %s starts on the computer %s at the position : %s like the task %s",
(*task_test)->name, char_performer, char_order, current_job->name);
}else{
//the parameter seems to be ok
/*the platform has not enough processors to schedule the DAG like
*the user wants*/
schedule = false;
- VERB0("The schedule is ignored, there are not enough computers");
+ XBT_VERB("The schedule is ignored, there are not enough computers");
}
}
else {
//one of necessary parameters are not given
schedule = false;
- VERB1("The schedule is ignored, the task %s is not correctly schedule", current_job->name);
+ XBT_VERB("The schedule is ignored, the task %s is not correctly schedule", current_job->name);
}
}
}
void dot_add_input_dependencies(SD_task_t current_job, Agedge_t * edge)
{
SD_task_t file;
-
- char name[80];
- sprintf(name, "%s->%s", agnameof(agtail(edge)), agnameof(aghead(edge)));
+ char *name_tail=agnameof(agtail(edge));
+ char *name_head=agnameof(aghead(edge));
+ char *name = malloc((strlen(name_head)+strlen(name_tail)+3)*sizeof(char));
+ sprintf(name, "%s->%s", name_tail, name_head);
double size = dot_parse_double(agget(edge, (char *) "size"));
- DEBUG2("size : %e, get size : %s", size, agget(edge, (char *) "size"));
+ XBT_DEBUG("size : %e, get size : %s", size, agget(edge, (char *) "size"));
if (size > 0) {
file = xbt_dict_get_or_null(files, name);
xbt_dict_set(files, name, file, &dot_task_free);
} else {
if (SD_task_get_amount(file) != size) {
- WARN3("Ignoring file %s size redefinition from %.0f to %.0f",
+ XBT_WARN("Ignoring file %s size redefinition from %.0f to %.0f",
name, SD_task_get_amount(file), size);
}
}
SD_task_dependency_add(NULL, NULL, file, current_job);
}
}
+ free(name);
}
/* dot_add_output_dependencies create the dependencies between a
void dot_add_output_dependencies(SD_task_t current_job, Agedge_t * edge)
{
SD_task_t file;
- char name[80];
- sprintf(name, "%s->%s", agnameof(agtail(edge)), agnameof(aghead(edge)));
+ char *name_tail=agnameof(agtail(edge));
+ char *name_head=agnameof(aghead(edge));
+ char *name = malloc((strlen(name_head)+strlen(name_tail)+3)*sizeof(char));
+ sprintf(name, "%s->%s", name_tail, name_head);
double size = dot_parse_double(agget(edge, (char *) "size"));
- DEBUG2("size : %e, get size : %s", size, agget(edge, (char *) "size"));
+ XBT_DEBUG("size : %e, get size : %s", size, agget(edge, (char *) "size"));
if (size > 0) {
file = xbt_dict_get_or_null(files, name);
xbt_dict_set(files, name, file, &dot_task_free);
} else {
if (SD_task_get_amount(file) != size) {
- WARN3("Ignoring file %s size redefinition from %.0f to %.0f",
+ XBT_WARN("Ignoring file %s size redefinition from %.0f to %.0f",
name, SD_task_get_amount(file), size);
}
}
SD_task_dependency_add(NULL, NULL, current_job, file);
if (xbt_dynar_length(file->tasks_before) > 1) {
- WARN1("File %s created at more than one location...", file->name);
+ XBT_WARN("File %s created at more than one location...", file->name);
}
} else {
file = xbt_dict_get_or_null(jobs, agnameof(aghead(edge)));
SD_task_dependency_add(NULL, NULL, current_job, file);
}
}
+ free(name);
}
