With a std::map, entries are already sorted by their keys.

[simgrid.git] / src / kernel / EngineImpl.cpp

diff --git a/src/kernel/EngineImpl.cpp b/src/kernel/EngineImpl.cpp
index dcda57d..3a96a57 100644 (file)
--- a/src/kernel/EngineImpl.cpp
+++ b/src/kernel/EngineImpl.cpp
@@ -1,4 +1,4 @@
-/* Copyright (c) 2016-2018. The SimGrid Team. All rights reserved.          */
+/* Copyright (c) 2016-2019. The SimGrid Team. All rights reserved.          */
 
 /* This program is free software; you can redistribute it and/or modify it
  * under the terms of the license (GNU LGPL) which comes with this package. */
@@ -8,30 +8,18 @@
 #include "simgrid/kernel/routing/NetZoneImpl.hpp"
 #include "simgrid/s4u/Host.hpp"
 #include "src/surf/StorageImpl.hpp"
-
-#include <algorithm>
+#include "src/surf/network_interface.hpp"
 
 namespace simgrid {
 namespace kernel {
 
-EngineImpl::EngineImpl() = default;
 EngineImpl::~EngineImpl()
 {
-  /* copy all names to not modify the map while iterating over it.
-   *
-   * Plus, the hosts are destroyed in the lexicographic order to ensure
-   * that the output is reproducible: we don't want to kill them in the
-   * pointer order as it could be platform-dependent, which would break
-   * the tests.
+  /* Since hosts_ is a std::map, the hosts are destroyed in the lexicographic order, which ensures that the output is
+   * reproducible.
    */
-  std::vector<std::string> names;
-  for (auto const& kv : hosts_)
-    names.push_back(kv.second->get_name());
-
-  std::sort(names.begin(), names.end());
-
-  for (auto const& name : names)
-    hosts_.at(name)->destroy();
+  while (not hosts_.empty())
+    hosts_.begin()->second->destroy();
 
   /* Also delete the other data */
   delete netzone_root_;
@@ -40,7 +28,11 @@ EngineImpl::~EngineImpl()
 
   for (auto const& kv : storages_)
     if (kv.second)
-      delete kv.second->getImpl();
+      kv.second->get_impl()->destroy();
+
+  for (auto const& kv : links_)
+    if (kv.second)
+      kv.second->get_impl()->destroy();
 }
 }
 }