Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
Nobody will ever need to override the behavior of config parsing, so simplify the...
[simgrid.git] / src / surf / surf_routing.c
index 4544514..5d6a515 100644 (file)
@@ -1,10 +1,13 @@
-/* Copyright (c) 2009, 2010. The SimGrid Team. 
+/* Copyright (c) 2009, 2010, 2011. The SimGrid Team.
  * All rights reserved.                                                     */
 
 /* This program is free software; you can redistribute it and/or modify it
  * under the terms of the license (GNU LGPL) which comes with this package. */
 
 #include <pcre.h>               /* regular expression library */
+
+#include "simgrid/platf.h" // platform creation API
+
 #include "surf_routing_private.h"
 #include "surf/surf_routing.h"
 #include "surf/surfxml_parse_values.h"
@@ -52,9 +55,6 @@ static void routing_parse_Speer(void);          /* peer bypass */
 static void routing_parse_Srandom(void);        /* random bypass */
 static void routing_parse_Erandom(void);        /* random bypass */
 
-static void routing_parse_Sconfig(void);        /* config Tag */
-static void routing_parse_Econfig(void);        /* config Tag */
-
 static char* replace_random_parameter(char * chaine);
 static void clean_routing_after_parse(void);
 
@@ -186,11 +186,9 @@ static void parse_E_host(void)
 /*
  * \brief Add a host to the network element list from XML
  */
-static void parse_S_host_XML(void)
+static void parse_S_host_XML(surf_parsing_host_arg_t h)
 {
-//     XBT_INFO("parse_S_host_XML");
-//     XBT_INFO("'%s'  '%s'",struct_host->V_host_id, struct_host->V_host_coord);
-       parse_S_host(struct_host->V_host_id, struct_host->V_host_coord);
+       parse_S_host(h->V_host_id, h->V_host_coord);
 }
 static void parse_E_host_XML(void)
 {
@@ -421,16 +419,26 @@ static void parse_E_bypassRoute_store_route(void)
 }
 
 /**
- * \brief Make a new routing component
+ * \brief Make a new routing component to the platform
+ *
+ * Add a new autonomous system to the platform. Any elements (such as host,
+ * router or sub-AS) added after this call and before the corresponding call
+ * to sg_platf_new_AS_close() will be added to this AS.
  *
- * make the new structure and
- * set the parsing functions to allows parsing the part of the routing tree
+ * Once this function was called, the configuration concerning the used
+ * models cannot be changed anymore.
+ *
+ * @param AS_id name of this autonomous system. Must be uniq in the platform
+ * @param wanted_routing_type one of Full, Floyd, Dijkstra or similar. Full list in the variable routing_models, in src/surf/surf_routing.c
  */
-void routing_AS_init(const char *AS_id, const char *wanted_routing_type)
+void sg_platf_new_AS_open(const char *AS_id, const char *wanted_routing_type)
 {
   routing_component_t new_routing;
   model_type_t model = NULL;
   int cpt;
+
+  surf_parse_models_setup(); /* ensure that the models are created after the last <config> tag and before the first <AS>-like */
+
   /* search the routing model */
   for (cpt = 0; routing_models[cpt].name; cpt++)
     if (!strcmp(wanted_routing_type, routing_models[cpt].name))
@@ -489,26 +497,21 @@ void routing_AS_init(const char *AS_id, const char *wanted_routing_type)
   current_routing = new_routing;
 }
 
-/*
- * Detect the routing model type of the routing component from XML platforms
- */
-static void parse_S_AS(void)
-{
-  routing_AS_init(A_surfxml_AS_id, A_surfxml_AS_routing);
-}
-
-
 /**
- * \brief Finish the creation of a new routing component
+ * \brief Specify that the current description of AS is finished
+ *
+ * Once you've declared all the content of your AS, you have to close
+ * it with this call. Your AS is not usable until you call this function.
+ *
+ * @fixme: this call is not as robust as wanted: bad things WILL happen
+ * if you call it twice for the same AS, or if you forget calling it, or
+ * even if you add stuff to a closed AS
  *
- * When you finish to read the routing component, other structures must be created. 
- * the "end" method allow to do that for any routing model type
  */
-void routing_AS_end(const char *AS_id)
-{
+void sg_platf_new_AS_close() {
 
   if (current_routing == NULL) {
-    THROWF(arg_error, 0, "Close AS(%s), that were never opened", AS_id);
+    THROWF(arg_error, 0, "Close an AS, but none was under construction");
   } else {
     network_element_info_t info = NULL;
     xbt_assert(!xbt_lib_get_or_null(as_router_lib,current_routing->name, ROUTING_ASR_LEVEL),
@@ -526,14 +529,6 @@ void routing_AS_end(const char *AS_id)
   }
 }
 
-/*
- * \brief Finish the creation of a new routing component from XML
- */
-static void parse_E_AS(void)
-{
-  routing_AS_end(A_surfxml_AS_id);
-}
-
 /* Aux Business methods */
 
 /**
@@ -972,7 +967,7 @@ void routing_model_create(size_t size_of_links, void *loopback, double_f_cpvoid_
   current_routing = NULL;
 
   /* parse generic elements */
-  surfxml_add_callback(STag_surfxml_host_cb_list, &parse_S_host_XML);
+  surf_parse_host_add_cb(parse_S_host_XML);
   surfxml_add_callback(ETag_surfxml_host_cb_list, &parse_E_host_XML);
   surfxml_add_callback(STag_surfxml_router_cb_list, &parse_S_router_XML);
 
@@ -993,9 +988,6 @@ void routing_model_create(size_t size_of_links, void *loopback, double_f_cpvoid_
   surfxml_add_callback(ETag_surfxml_bypassRoute_cb_list,
                        &parse_E_bypassRoute_store_route);
 
-  surfxml_add_callback(STag_surfxml_AS_cb_list, &parse_S_AS);
-  surfxml_add_callback(ETag_surfxml_AS_cb_list, &parse_E_AS);
-
   surfxml_add_callback(STag_surfxml_cluster_cb_list,
                        &routing_parse_Scluster);
 
@@ -1012,8 +1004,6 @@ void routing_model_create(size_t size_of_links, void *loopback, double_f_cpvoid_
 
 void surf_parse_add_callback_config(void)
 {
-       surfxml_add_callback(STag_surfxml_config_cb_list, &routing_parse_Sconfig);
-       surfxml_add_callback(ETag_surfxml_config_cb_list, &routing_parse_Econfig);
        surfxml_add_callback(STag_surfxml_prop_cb_list, &parse_properties_XML);
        surfxml_add_callback(STag_surfxml_random_cb_list, &routing_parse_Srandom);
 }
@@ -1479,26 +1469,101 @@ void generic_src_dst_check(routing_component_t rc, const char *src,
      src,dst,src_as->name, dst_as->name,rc->name);
 }
 
-static void routing_parse_Sconfig(void)
-{
-  XBT_DEBUG("START configuration name = %s",A_surfxml_config_id);
-}
 
-static void routing_parse_Econfig(void)
+static void parse_create_host_link(int i)
 {
-  xbt_dict_cursor_t cursor = NULL;
-  char *key;
-  char *elem;
-  char *cfg;
-  xbt_dict_foreach(current_property_set, cursor, key, elem) {
-         cfg = bprintf("%s:%s",key,elem);
-         if(xbt_cfg_is_default_value(_surf_cfg_set, key))
-                 xbt_cfg_set_parse(_surf_cfg_set, cfg);
-         else
-                 XBT_INFO("The custom configuration '%s' is already defined by user!",key);
-         free(cfg);
-  }
-  XBT_DEBUG("End configuration name = %s",A_surfxml_config_id);
+       char *host_id, *link_id = NULL;
+       s_surf_parsing_host_arg_t host;
+       memset(&host,0,sizeof(host));
+
+       host_id = bprintf("%s%d%s", struct_cluster->V_cluster_prefix, i, struct_cluster->V_cluster_suffix);
+       link_id = bprintf("%s_link_%d", struct_cluster->V_cluster_id, i);
+
+       A_surfxml_host_state = A_surfxml_host_state_ON;
+
+       XBT_DEBUG("<host\tid=\"%s\"\tpower=\"%f\">", host_id, struct_cluster->S_cluster_power);
+       host.V_host_id = xbt_strdup(host_id);
+       if(strcmp(struct_cluster->V_cluster_availability_file,"")){
+         xbt_dict_set(patterns, "radical", bprintf("%d", i), xbt_free);
+         char* tmp_availability_file = xbt_strdup(struct_cluster->V_cluster_availability_file);
+         xbt_str_varsubst(tmp_availability_file,patterns);
+         XBT_DEBUG("\tavailability_file=\"%s\"",tmp_availability_file);
+         host.V_host_power_trace = tmgr_trace_new(tmp_availability_file);
+         xbt_free(tmp_availability_file);
+       }
+       else
+       {
+         XBT_DEBUG("\tavailability_file=\"\"");
+       }
+       if(strcmp(struct_cluster->V_cluster_state_file,"")){
+         char *tmp_state_file = xbt_strdup(struct_cluster->V_cluster_state_file);
+         xbt_str_varsubst(tmp_state_file,patterns);
+         XBT_DEBUG("\tstate_file=\"%s\"",tmp_state_file);
+         host.V_host_state_trace = tmgr_trace_new(tmp_state_file);
+         xbt_free(tmp_state_file);
+       }
+       else
+       {
+         XBT_DEBUG("\tstate_file=\"\"");
+       }
+
+       host.V_host_power_peak = struct_cluster->S_cluster_power;
+       host.V_host_power_scale = 1.0;
+       host.V_host_core = struct_cluster->S_cluster_core;
+       host.V_host_state_initial = SURF_RESOURCE_ON;
+       host.V_host_coord = "";
+       surf_parse_host(&host);
+       XBT_DEBUG("</host>");
+
+       A_surfxml_link_sharing_policy = A_surfxml_link_sharing_policy_SHARED;
+       if(AX_surfxml_cluster_sharing_policy == A_surfxml_cluster_sharing_policy_FULLDUPLEX)
+       {A_surfxml_link_sharing_policy =  A_surfxml_link_sharing_policy_FULLDUPLEX;}
+       if(AX_surfxml_cluster_sharing_policy == A_surfxml_cluster_sharing_policy_FATPIPE)
+       {A_surfxml_link_sharing_policy =  A_surfxml_link_sharing_policy_FATPIPE;}
+
+       XBT_DEBUG("<link\tid=\"%s\"\tbw=\"%f\"\tlat=\"%f\"/>", link_id,struct_cluster->S_cluster_bw, struct_cluster->S_cluster_lat);
+
+       struct_lnk = xbt_new0(s_surf_parsing_link_arg_t, 1);
+       struct_lnk->V_link_id = xbt_strdup(link_id);
+       struct_lnk->V_link_bandwidth = struct_cluster->S_cluster_bw;
+       struct_lnk->V_link_latency = struct_cluster->S_cluster_lat;
+       struct_lnk->V_link_bandwidth_file = NULL;
+       struct_lnk->V_link_latency_file = NULL;
+       struct_lnk->V_link_state_file = NULL;
+       struct_lnk->V_link_state = SURF_RESOURCE_ON;
+       struct_lnk->V_link_sharing_policy = A_surfxml_link_sharing_policy;
+
+       if (A_surfxml_link_sharing_policy == A_surfxml_link_sharing_policy_SHARED)
+               struct_lnk->V_policy_initial_link = SURF_LINK_SHARED;
+       else
+       {
+        if (A_surfxml_link_sharing_policy == A_surfxml_link_sharing_policy_FATPIPE)
+                struct_lnk->V_policy_initial_link = SURF_LINK_FATPIPE;
+        else if (A_surfxml_link_sharing_policy == A_surfxml_link_sharing_policy_FULLDUPLEX)
+                struct_lnk->V_policy_initial_link = SURF_LINK_FULLDUPLEX;
+       }
+       surf_parse_link();
+
+       ETag_surfxml_host();
+       ETag_surfxml_link();
+
+       surf_parsing_link_up_down_t info = xbt_new0(s_surf_parsing_link_up_down_t, 1);
+
+       if (A_surfxml_link_sharing_policy == A_surfxml_link_sharing_policy_FULLDUPLEX){
+               char* tmp_link =  bprintf("%s_UP",link_id);
+               info->link_up   = xbt_lib_get_or_null(link_lib, tmp_link, SURF_LINK_LEVEL);
+               free(tmp_link);
+               tmp_link =  bprintf("%s_DOWN",link_id);
+               info->link_down = xbt_lib_get_or_null(link_lib, tmp_link, SURF_LINK_LEVEL);
+               free(tmp_link);
+       }
+       else{
+               info->link_up   = xbt_lib_get_or_null(link_lib, link_id, SURF_LINK_LEVEL);
+               info->link_down = info->link_up;
+       }
+       xbt_dict_set(cluster_host_link,host_id,info,xbt_free);
+       xbt_free(link_id);
+       xbt_free(host_id);
 }
 
 void routing_parse_Scluster(void)
@@ -1509,12 +1574,13 @@ void routing_parse_Scluster(void)
   static int AX_ptr = 0;
   char *host_id, *groups, *link_id = NULL;
 
+  s_surf_parsing_host_arg_t host;
+
   if( strcmp(struct_cluster->V_cluster_availability_file,"")
          || strcmp(struct_cluster->V_cluster_state_file,"") )
   {
          if(xbt_dict_size(patterns)==0)
                  patterns = xbt_dict_new();
-         XBT_INFO("'%s' '%s'",A_surfxml_cluster_state_file,struct_cluster->V_cluster_availability_file);
          xbt_dict_set(patterns,"id",struct_cluster->V_cluster_id,NULL);
          xbt_dict_set(patterns,"prefix",struct_cluster->V_cluster_prefix,NULL);
          xbt_dict_set(patterns,"suffix",struct_cluster->V_cluster_suffix,NULL);
@@ -1524,16 +1590,11 @@ void routing_parse_Scluster(void)
   int start, end, i;
   xbt_dynar_t radical_elements;
   xbt_dynar_t radical_ends;
-  int cluster_sharing_policy = AX_surfxml_cluster_sharing_policy;
-  int cluster_bb_sharing_policy = AX_surfxml_cluster_bb_sharing_policy;
-  if(cluster_sharing_policy == A_surfxml_cluster_sharing_policy_FULLDUPLEX)
-         xbt_dict_set(cluster_host_link,struct_cluster->V_cluster_id,bprintf("fullduplex"),free);
 
   static unsigned int surfxml_buffer_stack_stack_ptr = 1;
   static unsigned int surfxml_buffer_stack_stack[1024];
 
   surfxml_buffer_stack_stack[0] = 0;
-
   surfxml_bufferstack_push(1);
 
   SURFXML_BUFFER_SET(AS_id, struct_cluster->V_cluster_id);
@@ -1541,8 +1602,11 @@ void routing_parse_Scluster(void)
   XBT_DEBUG("<AS id=\"%s\"\trouting=\"Cluster\">", struct_cluster->V_cluster_id);
   SURFXML_START_TAG(AS);
 
+  //Make all hosts
   radical_elements = xbt_str_split(struct_cluster->V_cluster_radical, ",");
   xbt_dynar_foreach(radical_elements, iter, groups) {
+    memset(&host,0,sizeof(host));
+
     radical_ends = xbt_str_split(groups, "-");
     switch (xbt_dynar_length(radical_ends)) {
     case 1:
@@ -1551,14 +1615,13 @@ void routing_parse_Scluster(void)
                link_id = bprintf("%s_link_%d", struct_cluster->V_cluster_id, start);
 
                XBT_DEBUG("<host\tid=\"%s\"\tpower=\"%f\">", host_id, struct_cluster->S_cluster_power);
-               struct_host = xbt_new0(s_surf_parsing_host_arg_t, 1);
-               struct_host->V_host_id = host_id;
+               host.V_host_id = host_id;
                if(strcmp(struct_cluster->V_cluster_availability_file,"")){
                  xbt_dict_set(patterns, "radical", bprintf("%d", start), xbt_free);
                  char* tmp_availability_file = xbt_strdup(struct_cluster->V_cluster_availability_file);
                  xbt_str_varsubst(tmp_availability_file,patterns);
                  XBT_DEBUG("\tavailability_file=\"%s\"",tmp_availability_file);
-                 struct_host->V_host_power_trace = tmgr_trace_new(tmp_availability_file);
+                 host.V_host_power_trace = tmgr_trace_new(tmp_availability_file);
                  xbt_free(tmp_availability_file);
                }
                else
@@ -1569,7 +1632,7 @@ void routing_parse_Scluster(void)
                  char *tmp_state_file = xbt_strdup(struct_cluster->V_cluster_state_file);
                  xbt_str_varsubst(tmp_state_file,patterns);
                  XBT_DEBUG("\tstate_file=\"%s\"",tmp_state_file);
-                 struct_host->V_host_state_trace = tmgr_trace_new(tmp_state_file);
+                 host.V_host_state_trace = tmgr_trace_new(tmp_state_file);
                  xbt_free(tmp_state_file);
                }
                else
@@ -1577,18 +1640,18 @@ void routing_parse_Scluster(void)
                  XBT_DEBUG("\tstate_file=\"\"");
                }
 
-               struct_host->V_host_power_peak = struct_cluster->S_cluster_power;
-               struct_host->V_host_power_scale = 1.0;
-               struct_host->V_host_core = struct_cluster->S_cluster_core;
-               struct_host->V_host_state_initial = SURF_RESOURCE_ON;
-               struct_host->V_host_coord = "";
-               STag_surfxml_host_cluster();
+               host.V_host_power_peak = struct_cluster->S_cluster_power;
+               host.V_host_power_scale = 1.0;
+               host.V_host_core = struct_cluster->S_cluster_core;
+               host.V_host_state_initial = SURF_RESOURCE_ON;
+               host.V_host_coord = "";
+               surf_parse_host(&host);
                XBT_DEBUG("</host>");
 
                A_surfxml_link_sharing_policy = A_surfxml_link_sharing_policy_SHARED;
-               if(cluster_sharing_policy == A_surfxml_cluster_sharing_policy_FULLDUPLEX)
+               if(struct_cluster->V_cluster_sharing_policy == A_surfxml_cluster_sharing_policy_FULLDUPLEX)
                {A_surfxml_link_sharing_policy =  A_surfxml_link_sharing_policy_FULLDUPLEX;}
-               if(cluster_sharing_policy == A_surfxml_cluster_sharing_policy_FATPIPE)
+               if(struct_cluster->V_cluster_sharing_policy == A_surfxml_cluster_sharing_policy_FATPIPE)
                {A_surfxml_link_sharing_policy =  A_surfxml_link_sharing_policy_FATPIPE;}
 
                XBT_DEBUG("<link\tid=\"%s\"\tbw=\"%f\"\tlat=\"%f\"/>", link_id,struct_cluster->S_cluster_bw, struct_cluster->S_cluster_lat);
@@ -1612,7 +1675,7 @@ void routing_parse_Scluster(void)
                 else if (A_surfxml_link_sharing_policy == A_surfxml_link_sharing_policy_FULLDUPLEX)
                         struct_lnk->V_policy_initial_link = SURF_LINK_FULLDUPLEX;
                }
-               STag_surfxml_link_cluster();
+               surf_parse_link();
 
                xbt_dict_set(cluster_host_link,host_id,strdup(link_id),free);
 //             XBT_INFO("key '%s' Value '%s'",host_id,link_id);
@@ -1633,14 +1696,13 @@ void routing_parse_Scluster(void)
                A_surfxml_host_state = A_surfxml_host_state_ON;
 
                XBT_DEBUG("<host\tid=\"%s\"\tpower=\"%f\">", host_id, struct_cluster->S_cluster_power);
-               struct_host = xbt_new0(s_surf_parsing_host_arg_t, 1);
-               struct_host->V_host_id = host_id;
+               host.V_host_id = host_id;
                if(strcmp(struct_cluster->V_cluster_availability_file,"")){
                  xbt_dict_set(patterns, "radical", bprintf("%d", i), xbt_free);
                  char* tmp_availability_file = xbt_strdup(struct_cluster->V_cluster_availability_file);
                  xbt_str_varsubst(tmp_availability_file,patterns);
                  XBT_DEBUG("\tavailability_file=\"%s\"",tmp_availability_file);
-                 struct_host->V_host_power_trace = tmgr_trace_new(tmp_availability_file);
+                 host.V_host_power_trace = tmgr_trace_new(tmp_availability_file);
                  xbt_free(tmp_availability_file);
                }
                else
@@ -1651,7 +1713,7 @@ void routing_parse_Scluster(void)
                  char *tmp_state_file = xbt_strdup(struct_cluster->V_cluster_state_file);
                  xbt_str_varsubst(tmp_state_file,patterns);
                  XBT_DEBUG("\tstate_file=\"%s\"",tmp_state_file);
-                 struct_host->V_host_state_trace = tmgr_trace_new(tmp_state_file);
+                 host.V_host_state_trace = tmgr_trace_new(tmp_state_file);
                  xbt_free(tmp_state_file);
                }
                else
@@ -1659,18 +1721,18 @@ void routing_parse_Scluster(void)
                  XBT_DEBUG("\tstate_file=\"\"");
                }
 
-               struct_host->V_host_power_peak = struct_cluster->S_cluster_power;
-               struct_host->V_host_power_scale = 1.0;
-               struct_host->V_host_core = struct_cluster->S_cluster_core;
-               struct_host->V_host_state_initial = SURF_RESOURCE_ON;
-               struct_host->V_host_coord = "";
-               STag_surfxml_host_cluster();
+               host.V_host_power_peak = struct_cluster->S_cluster_power;
+               host.V_host_power_scale = 1.0;
+               host.V_host_core = struct_cluster->S_cluster_core;
+               host.V_host_state_initial = SURF_RESOURCE_ON;
+               host.V_host_coord = "";
+               surf_parse_host(&host);
                XBT_DEBUG("</host>");
 
                A_surfxml_link_sharing_policy = A_surfxml_link_sharing_policy_SHARED;
-               if(cluster_sharing_policy == A_surfxml_cluster_sharing_policy_FULLDUPLEX)
+               if(struct_cluster->V_cluster_sharing_policy == A_surfxml_cluster_sharing_policy_FULLDUPLEX)
                {A_surfxml_link_sharing_policy =  A_surfxml_link_sharing_policy_FULLDUPLEX;}
-               if(cluster_sharing_policy == A_surfxml_cluster_sharing_policy_FATPIPE)
+               if(struct_cluster->V_cluster_sharing_policy == A_surfxml_cluster_sharing_policy_FATPIPE)
                {A_surfxml_link_sharing_policy =  A_surfxml_link_sharing_policy_FATPIPE;}
 
                XBT_DEBUG("<link\tid=\"%s\"\tbw=\"%f\"\tlat=\"%f\"/>", link_id,struct_cluster->S_cluster_bw, struct_cluster->S_cluster_lat);
@@ -1694,7 +1756,7 @@ void routing_parse_Scluster(void)
                 else if (A_surfxml_link_sharing_policy == A_surfxml_link_sharing_policy_FULLDUPLEX)
                         struct_lnk->V_policy_initial_link = SURF_LINK_FULLDUPLEX;
                }
-               STag_surfxml_link_cluster();
+               surf_parse_link();
 
                xbt_dict_set(cluster_host_link,host_id,strdup(link_id),free);
 //             XBT_INFO("key '%s' Value '%s'",host_id,link_id);
@@ -1714,6 +1776,7 @@ void routing_parse_Scluster(void)
   }
   xbt_dynar_free(&radical_elements);
 
+  //Make the router
   XBT_DEBUG(" ");
   XBT_DEBUG("<router id=\"%s\"/>", struct_cluster->S_cluster_router_id);
   SURFXML_BUFFER_SET(router_id, struct_cluster->S_cluster_router_id);
@@ -1721,16 +1784,17 @@ void routing_parse_Scluster(void)
   SURFXML_START_TAG(router);
   SURFXML_END_TAG(router);
 
+  //Make the backbone
   if( (struct_cluster->S_cluster_bb_bw!= 0)  && (struct_cluster->S_cluster_bb_lat!=0)  ){
          char *link_backbone = bprintf("%s_backbone", struct_cluster->V_cluster_id);
          XBT_DEBUG("<link\tid=\"%s\" bw=\"%f\" lat=\"%f\"/>", link_backbone,struct_cluster->S_cluster_bb_bw, struct_cluster->S_cluster_bb_lat);
 
          A_surfxml_link_sharing_policy = A_surfxml_link_sharing_policy_SHARED;
-         if(cluster_bb_sharing_policy == A_surfxml_cluster_bb_sharing_policy_FATPIPE)
+         if(AX_surfxml_cluster_bb_sharing_policy == A_surfxml_cluster_bb_sharing_policy_FATPIPE)
          {A_surfxml_link_sharing_policy =  A_surfxml_link_sharing_policy_FATPIPE;}
 
          struct_lnk = xbt_new0(s_surf_parsing_link_arg_t, 1);
-         struct_lnk->V_link_id = link_backbone;
+         struct_lnk->V_link_id = xbt_strdup(link_backbone);
          struct_lnk->V_link_bandwidth = struct_cluster->S_cluster_bb_bw;
          struct_lnk->V_link_latency = struct_cluster->S_cluster_bb_lat;
          struct_lnk->V_link_bandwidth_file = NULL;
@@ -1742,15 +1806,16 @@ void routing_parse_Scluster(void)
          if (A_surfxml_link_sharing_policy == A_surfxml_link_sharing_policy_SHARED)
                  struct_lnk->V_policy_initial_link = SURF_LINK_SHARED;
          else
-         {
-          if (A_surfxml_link_sharing_policy == A_surfxml_link_sharing_policy_FATPIPE)
-                  struct_lnk->V_policy_initial_link = SURF_LINK_FATPIPE;
-          else if (A_surfxml_link_sharing_policy == A_surfxml_link_sharing_policy_FULLDUPLEX)
-                  struct_lnk->V_policy_initial_link = SURF_LINK_FULLDUPLEX;
-         }
+                 struct_lnk->V_policy_initial_link = SURF_LINK_FATPIPE;
 
-         STag_surfxml_link_cluster();
+         surf_parse_link();
          ETag_surfxml_link();
+
+         surf_parsing_link_up_down_t info = xbt_new0(s_surf_parsing_link_up_down_t, 1);
+         info->link_up   = xbt_lib_get_or_null(link_lib, link_backbone, SURF_LINK_LEVEL);
+         info->link_down = info->link_up;
+         xbt_dict_set(cluster_host_link,struct_cluster->V_cluster_id,info,xbt_free);
+         free(link_backbone);
   }
 
   XBT_DEBUG(" ");
@@ -1778,14 +1843,6 @@ void routing_parse_Scluster(void)
   XBT_DEBUG(" ");
 
   surfxml_bufferstack_pop(1);
-
-//  xbt_dict_cursor_t cursor = NULL;
-//  char *key,*data;
-//
-//  XBT_INFO("\n");
-//  xbt_dict_foreach(cluster_host_link,cursor,key,data){
-//       XBT_INFO("%s : %s",key,data);
-//  }
 }
 /*
  * This function take a string and replace parameters from patterns dict.