sonar: ignore more issues, hide commented code, add 'explicit'

[simgrid.git] / src / mc / Session.hpp

diff --git a/src/mc/Session.hpp b/src/mc/Session.hpp
index 508f65a..ecdb31d 100644 (file)
--- a/src/mc/Session.hpp
+++ b/src/mc/Session.hpp
@@ -1,5 +1,4 @@
-/* Copyright (c) 2016-2019. The SimGrid Team.
- * All rights reserved.                                                     */
+/* Copyright (c) 2016-2019. The SimGrid Team. All rights reserved.          */
 
 /* This program is free software; you can redistribute it and/or modify it
  * under the terms of the license (GNU LGPL) which comes with this package. */
@@ -7,22 +6,10 @@
 #ifndef SIMGRID_MC_SESSION_HPP
 #define SIMGRID_MC_SESSION_HPP
 
-#ifdef __linux__
-#include <sys/prctl.h>
-#endif
-
-#include "xbt/sysdep.h"
-#include "xbt/system_error.hpp"
-#include <sys/socket.h>
-#include <sys/types.h>
+#include "src/mc/ModelChecker.hpp"
 
 #include <functional>
 
-#include "xbt/log.h"
-
-#include "src/mc/mc_forward.hpp"
-#include "src/mc/ModelChecker.hpp"
-
 namespace simgrid {
 namespace mc {
 
@@ -36,52 +23,34 @@ namespace mc {
  */
 class Session {
 private:
-  std::unique_ptr<ModelChecker> modelChecker_;
-  std::shared_ptr<simgrid::mc::Snapshot> initialSnapshot_;
-
-  Session(pid_t pid, int socket);
+  std::unique_ptr<ModelChecker> model_checker_;
+  std::shared_ptr<simgrid::mc::Snapshot> initial_snapshot_;
 
   // No copy:
   Session(Session const&) = delete;
   Session& operator=(Session const&) = delete;
 
 public:
-  ~Session();
-  void close();
-
-  void initialize();
-  void execute(Transition const& transition);
-  void logState();
-
-  void restoreInitialState();
-
-  // static constructors
-
-  /** Create a new session by forking
+  /** Create a new session by executing the provided code in a fork()
    *
    *  This sets up the environment for the model-checked process
-   *  (environoment variables, sockets, etc.).
+   *  (environment variables, sockets, etc.).
    *
-   *  The code is expected to `exec` the model-checker program.
+   *  The code is expected to `exec` the model-checked application.
    */
-  static Session* fork(std::function<void()> code);
+  explicit Session(const std::function<void()>& code);
 
-  /** Spawn a model-checked process
-   *
-   *  @param path full path of the executable
-   *  @param argv arguments for the model-checked process (NULL-terminated)
-   */
-  static Session* spawnv(const char *path, char *const argv[]);
+  ~Session();
+  void close();
 
-  /** Spawn a model-checked process (using PATH)
-   *
-   *  @param file file name of the executable (found using `PATH`)
-   *  @param argv arguments for the model-checked process (NULL-terminated)
-   */
-  static Session* spawnvp(const char *file, char *const argv[]);
+  void initialize();
+  void execute(Transition const& transition);
+  void log_state();
+
+  void restore_initial_state();
 };
 
-// Temporary
+// Temporary :)
 extern simgrid::mc::Session* session;
 
 }