mc: don't catch exceptions we cannot deal with

[simgrid.git] / src / mc / checker / simgrid_mc.cpp

diff --git a/src/mc/checker/simgrid_mc.cpp b/src/mc/checker/simgrid_mc.cpp
index 0c59749..010cbfe 100644 (file)
--- a/src/mc/checker/simgrid_mc.cpp
+++ b/src/mc/checker/simgrid_mc.cpp
@@ -25,7 +25,7 @@ char** argvdup(int argc, char** argv)
   return argv_copy;
 }
 
-static std::unique_ptr<simgrid::mc::Checker> createChecker(simgrid::mc::Session& session)
+static std::unique_ptr<simgrid::mc::Checker> create_checker(simgrid::mc::Session& session)
 {
   if (_sg_mc_comms_determinism || _sg_mc_send_determinism)
     return std::unique_ptr<simgrid::mc::Checker>(simgrid::mc::createCommunicationDeterminismChecker(session));
@@ -37,48 +37,34 @@ static std::unique_ptr<simgrid::mc::Checker> createChecker(simgrid::mc::Session&
 
 int main(int argc, char** argv)
 {
-  using simgrid::mc::Session;
+  if (argc < 2)
+    xbt_die("Missing arguments.\n");
 
-  try {
-    if (argc < 2)
-      xbt_die("Missing arguments.\n");
-
-    // Currently, we need this before sg_config_init:
-    _sg_do_model_check = 1;
+  // Currently, we need this before sg_config_init:
+  _sg_do_model_check = 1;
 
-    // The initialization function can touch argv.
-    // We make a copy of argv before modifying it in order to pass the original
-    // value to the model-checked:
-    char** argv_copy = argvdup(argc, argv);
-    xbt_log_init(&argc, argv);
-    sg_config_init(&argc, argv);
+  // The initialization function can touch argv.
+  // We make a copy of argv before modifying it in order to pass the original
+  // value to the model-checked:
+  char** argv_copy = argvdup(argc, argv);
+  xbt_log_init(&argc, argv);
+  sg_config_init(&argc, argv);
 
-    simgrid::mc::session = new Session([argv_copy] {
-        execvp(argv_copy[1], argv_copy+1);
-      });
-    delete[] argv_copy;
+  simgrid::mc::session = new simgrid::mc::Session([argv_copy] { execvp(argv_copy[1], argv_copy + 1); });
+  delete[] argv_copy;
 
-    std::unique_ptr<simgrid::mc::Checker> checker = createChecker(*simgrid::mc::session);
-    int res = SIMGRID_MC_EXIT_SUCCESS;
-    try {
-      checker->run();
-    } catch (const simgrid::mc::DeadlockError&) {
-      res = SIMGRID_MC_EXIT_DEADLOCK;
-    } catch (const simgrid::mc::TerminationError&) {
-      res = SIMGRID_MC_EXIT_NON_TERMINATION;
-    } catch (const simgrid::mc::LivenessError&) {
-      res = SIMGRID_MC_EXIT_LIVENESS;
-    }
-    checker = nullptr;
-    simgrid::mc::session->close();
-    return res;
-  }
-  catch(std::exception& e) {
-    XBT_ERROR("Exception: %s", e.what());
-    return SIMGRID_MC_EXIT_ERROR;
-  }
-  catch(...) {
-    XBT_ERROR("Unknown exception");
-    return SIMGRID_MC_EXIT_ERROR;
+  std::unique_ptr<simgrid::mc::Checker> checker = create_checker(*simgrid::mc::session);
+  int res                                       = SIMGRID_MC_EXIT_SUCCESS;
+  try {
+    checker->run();
+  } catch (const simgrid::mc::DeadlockError&) {
+    res = SIMGRID_MC_EXIT_DEADLOCK;
+  } catch (const simgrid::mc::TerminationError&) {
+    res = SIMGRID_MC_EXIT_NON_TERMINATION;
+  } catch (const simgrid::mc::LivenessError&) {
+    res = SIMGRID_MC_EXIT_LIVENESS;
   }
+  checker = nullptr;
+  simgrid::mc::session->close();
+  return res;
 }