please sonar by using every parameters (+cosmetics)

[simgrid.git] / examples / msg / app-token-ring / app-token-ring.c

diff --git a/examples/msg/app-token-ring/app-token-ring.c b/examples/msg/app-token-ring/app-token-ring.c
index 2ab30e6..3a6c019 100644 (file)
--- a/examples/msg/app-token-ring/app-token-ring.c
+++ b/examples/msg/app-token-ring/app-token-ring.c
@@ -10,6 +10,7 @@ XBT_LOG_NEW_DEFAULT_CATEGORY(msg_app_token_ring, "Messages specific for this msg
 /* Main function of all processes used in this example */
 static int relay_runner(int argc, char *argv[])
 {
+  xbt_assert(argc==0, "The relay_runner function does not accept any parameter from the XML deployment file");
   unsigned int task_comm_size = 1000000; /* The token is 1MB long*/
   int rank = xbt_str_parse_int(MSG_process_get_name(MSG_process_self()), "Any process of this example must have a numerical name, not %s");
   char mailbox[256];
@@ -21,7 +22,7 @@ static int relay_runner(int argc, char *argv[])
     XBT_INFO("Host \"%d\" send '%s' to Host \"%s\"", rank, task->name,mailbox);
     MSG_task_send(task, mailbox);
     task = NULL;
-    int res = MSG_task_receive(&(task), MSG_process_get_name(MSG_process_self()));
+    int res = MSG_task_receive(&task, MSG_process_get_name(MSG_process_self()));
     xbt_assert(res == MSG_OK, "MSG_task_get failed");
     XBT_INFO("Host \"%d\" received \"%s\"", rank, MSG_task_get_name(task));
     MSG_task_destroy(task);
@@ -29,7 +30,7 @@ static int relay_runner(int argc, char *argv[])
   } else {
     /* The others processes receive from their left neighbor (rank-1) and send to their right neighbor (rank+1) */
     msg_task_t task = NULL;
-    int res = MSG_task_receive(&(task), MSG_process_get_name(MSG_process_self()));
+    int res = MSG_task_receive(&task, MSG_process_get_name(MSG_process_self()));
     xbt_assert(res == MSG_OK, "MSG_task_get failed");
     XBT_INFO("Host \"%d\" received \"%s\"",rank, MSG_task_get_name(task));
 
@@ -46,14 +47,15 @@ static int relay_runner(int argc, char *argv[])
 
 int main(int argc, char *argv[])
 {
-  unsigned int i;
   MSG_init(&argc, argv);
+  xbt_assert(argc>1, "Usage: %s platform.xml\n",argv[0]);
   MSG_create_environment(argv[1]);       /* - Load the platform description */
   xbt_dynar_t hosts = MSG_hosts_as_dynar();
-  msg_host_t h;
 
-  XBT_INFO("Number of hosts '%d'",MSG_get_host_number());
-  xbt_dynar_foreach (hosts, i, h){      /* - Give a unique rank to each host and create a @ref relay_runner process on each */
+  XBT_INFO("Number of hosts '%d'", MSG_get_host_number());
+  unsigned int i;
+  msg_host_t h;
+  xbt_dynar_foreach (hosts, i, h) {      /* - Give a unique rank to each host and create a @ref relay_runner process on each */
     char* name_host = bprintf("%u",i);
     MSG_process_create(name_host, relay_runner, NULL, h);
     free(name_host);