Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
* Cleanup the DTD by renaming:
[simgrid.git] / src / surf / workstation_ptask_L07.c
index fd6967f..8e4711a 100644 (file)
@@ -8,6 +8,7 @@
 #include "xbt/ex.h"
 #include "xbt/dict.h"
 #include "surf_private.h"
+/* extern lmm_system_t maxmin_system; */
 
 typedef enum {
   SURF_WORKSTATION_RESOURCE_CPU,
@@ -28,6 +29,7 @@ typedef struct cpu_L07 {
   e_surf_cpu_state_t state_current;
   tmgr_trace_event_t state_event;
   int id;                      /* cpu and network card are a single object... */
+  xbt_dict_t properties;
 } s_cpu_L07_t, *cpu_L07_t;
 
 /**************************************/
@@ -39,10 +41,14 @@ typedef struct network_link_L07 {
   e_surf_workstation_model_type_t type;        /* Do not move this field */
   char *name;                  /* Do not move this field */
   lmm_constraint_t constraint; /* Do not move this field */
+  double lat_current;
+  tmgr_trace_event_t lat_event;
   double bw_current;
   tmgr_trace_event_t bw_event;
   e_surf_network_link_state_t state_current;
   tmgr_trace_event_t state_event;
+  /*holds the property list that can be associated with the link*/
+  xbt_dict_t properties;
 } s_network_link_L07_t, *network_link_L07_t;
 
 
@@ -57,6 +63,11 @@ typedef struct s_route_L07 {
 typedef struct surf_action_workstation_L07 {
   s_surf_action_t generic_action;
   lmm_variable_t variable;
+  int workstation_nb;
+  cpu_L07_t *workstation_list;
+  double *computation_amount;
+  double *communication_amount;
+  double latency;
   double rate;
   int suspended;
 } s_surf_action_workstation_L07_t, *surf_action_workstation_L07_t;
@@ -71,6 +82,42 @@ static network_link_L07_t loopback = NULL;
 static xbt_dict_t parallel_task_network_link_set = NULL;
 lmm_system_t ptask_maxmin_system = NULL;
 
+
+static void update_action_bound(surf_action_workstation_L07_t action)
+{
+  int workstation_nb = action->workstation_nb;
+  double lat_current = 0.0;
+  double lat_bound = -1.0;
+  int i, j, k;
+  
+  for (i = 0; i < workstation_nb; i++) {
+    for (j = 0; j < workstation_nb; j++) {
+      cpu_L07_t card_src = action->workstation_list[i];
+      cpu_L07_t card_dst = action->workstation_list[j];
+      int route_size = ROUTE(card_src->id, card_dst->id).size;
+      network_link_L07_t *route = ROUTE(card_src->id, card_dst->id).links;
+      double lat = 0.0;
+      
+      if (action->communication_amount[i * workstation_nb + j] > 0) {
+       for (k = 0; k < route_size; k++) {
+         lat += route[k]->lat_current;
+       }
+       lat_current=MAX(lat_current,lat*action->communication_amount[i * workstation_nb + j]);
+      }
+    }
+  }
+  lat_bound = SG_TCP_CTE_GAMMA / (2.0 * lat_current);
+  DEBUG2("action (%p) : lat_bound = %g", action, lat_bound);
+  if ((action->latency == 0.0) && (action->suspended == 0)) {
+    if (action->rate < 0)
+      lmm_update_variable_bound(ptask_maxmin_system, action->variable,
+                               lat_bound);
+    else
+      lmm_update_variable_bound(ptask_maxmin_system, action->variable,
+                               min(action->rate,lat_bound));
+  }
+}
+
 /**************************************/
 /******* Resource Public     **********/
 /**************************************/
@@ -85,6 +132,7 @@ static const char *get_resource_name(void *resource_id)
   /* We can freely cast as a cpu_L07_t because it has the same
      prefix as network_link_L07_t. However, only cpu_L07_t
      will theoretically be given as an argument here. */
+
   return ((cpu_L07_t) resource_id)->name;
 }
 
@@ -106,6 +154,9 @@ static int action_free(surf_action_t action)
       lmm_variable_free(ptask_maxmin_system,
                        ((surf_action_workstation_L07_t) action)->
                        variable);
+    free(((surf_action_workstation_L07_t)action)->workstation_list);
+    free(((surf_action_workstation_L07_t)action)->communication_amount);
+    free(((surf_action_workstation_L07_t)action)->computation_amount);
     free(action);
     return 1;
   }
@@ -141,12 +192,12 @@ static void action_suspend(surf_action_t action)
 
 static void action_resume(surf_action_t action)
 {
-  XBT_IN1("(%p)", action);
-  if (((surf_action_workstation_L07_t) action)->suspended != 2) {
-    lmm_update_variable_weight(ptask_maxmin_system,
-                              ((surf_action_workstation_L07_t)
-                               action)->variable, 1.0);
-    ((surf_action_workstation_L07_t) action)->suspended = 0;
+  surf_action_workstation_L07_t act = (surf_action_workstation_L07_t) action;
+
+  XBT_IN1("(%p)", act);
+  if (act->suspended != 2) {
+    lmm_update_variable_weight(ptask_maxmin_system,act->variable, 1.0);
+    act->suspended = 0;
   }
   XBT_OUT;
 }
@@ -188,14 +239,29 @@ static int resource_used(void *resource_id)
 static double share_resources(double now)
 {
   s_surf_action_workstation_L07_t s_action;
+  surf_action_workstation_L07_t action = NULL;
 
   xbt_swag_t running_actions =
       surf_workstation_model->common_public->states.running_action_set;
-  double min = generic_maxmin_share_resources2(running_actions,
-                                              xbt_swag_offset(s_action,
-                                                              variable),
-                                              ptask_maxmin_system,
-                                              bottleneck_solve);
+  double min = generic_maxmin_share_resources(running_actions,
+                                             xbt_swag_offset(s_action,
+                                                             variable),
+                                             ptask_maxmin_system,
+                                             bottleneck_solve);
+
+  xbt_swag_foreach(action, running_actions) {
+    if (action->latency > 0) {
+      if (min < 0) {
+       min = action->latency;
+       DEBUG3("Updating min (value) with %p (start %f): %f", action,
+              action->generic_action.start, min);
+      } else if (action->latency < min) {
+       min = action->latency;
+       DEBUG3("Updating min (latency) with %p (start %f): %f", action,
+              action->generic_action.start, min);
+      }
+    }
+  }
 
   DEBUG1("min value : %f", min);
 
@@ -204,12 +270,27 @@ static double share_resources(double now)
 
 static void update_actions_state(double now, double delta)
 {
+  double deltap = 0.0;
   surf_action_workstation_L07_t action = NULL;
   surf_action_workstation_L07_t next_action = NULL;
   xbt_swag_t running_actions =
       surf_workstation_model->common_public->states.running_action_set;
 
   xbt_swag_foreach_safe(action, next_action, running_actions) {
+    deltap = delta;
+    if (action->latency > 0) {
+      if (action->latency > deltap) {
+       double_update(&(action->latency), deltap);
+       deltap = 0.0;
+      } else {
+       double_update(&(deltap), action->latency);
+       action->latency = 0.0;
+      }
+      if ((action->latency == 0.0) && (action->suspended == 0)) {
+       update_action_bound(action);
+       lmm_update_variable_weight(ptask_maxmin_system,action->variable, 1.0);
+      }
+    }
     DEBUG3("Action (%p) : remains (%g) updated by %g.",
           action, action->generic_action.remains,
           lmm_variable_getvalue(action->variable) * delta);
@@ -287,6 +368,19 @@ static void update_resource_state(void *id,
       nw_link->bw_current = value;
       lmm_update_constraint_bound(ptask_maxmin_system, nw_link->constraint,
                                  nw_link->bw_current);
+    } else if (event_type == nw_link->lat_event) {
+      lmm_variable_t var = NULL;
+      surf_action_workstation_L07_t action = NULL;
+
+      nw_link->lat_current = value;
+      while (lmm_get_var_from_cnst
+            (ptask_maxmin_system, nw_link->constraint, &var)) {
+       
+
+       action = lmm_variable_id(var);
+       update_action_bound(action);
+      }
+
     } else if (event_type == nw_link->state_event) {
       if (value > 0)
        nw_link->state_current = SURF_NETWORK_LINK_ON;
@@ -376,6 +470,12 @@ static double get_available_speed(void *cpu)
   return ((cpu_L07_t) cpu)->power_current;
 }
 
+static xbt_dict_t get_properties(void *cpu)
+{
+ return ((cpu_L07_t) cpu)->properties;
+}
+
+
 static surf_action_t execute_parallel_task(int workstation_nb,
                                           void **workstation_list,
                                           double *computation_amount,
@@ -386,27 +486,34 @@ static surf_action_t execute_parallel_task(int workstation_nb,
   int i, j, k;
   int nb_link = 0;
   int nb_host = 0;
+  double latency = 0.0;
 
   if (parallel_task_network_link_set == NULL) {
     parallel_task_network_link_set =
        xbt_dict_new_ext(workstation_nb * workstation_nb * 10);
   }
 
-  /* Compute the number of affected models... */
+  xbt_dict_reset(parallel_task_network_link_set);
+
+  /* Compute the number of affected resources... */
   for (i = 0; i < workstation_nb; i++) {
     for (j = 0; j < workstation_nb; j++) {
       cpu_L07_t card_src = workstation_list[i];
       cpu_L07_t card_dst = workstation_list[j];
       int route_size = ROUTE(card_src->id, card_dst->id).size;
       network_link_L07_t *route = ROUTE(card_src->id, card_dst->id).links;
+      double lat = 0.0;
 
       if (communication_amount[i * workstation_nb + j] > 0)
        for (k = 0; k < route_size; k++) {
+         lat += route[k]->lat_current;
          xbt_dict_set(parallel_task_network_link_set, route[k]->name,
                       route[k], NULL);
        }
+      latency=MAX(latency,lat);
     }
   }
+
   nb_link = xbt_dict_length(parallel_task_network_link_set);
   xbt_dict_reset(parallel_task_network_link_set);
 
@@ -421,12 +528,17 @@ static surf_action_t execute_parallel_task(int workstation_nb,
   action->generic_action.cost = amount;
   action->generic_action.remains = amount;
   action->generic_action.max_duration = NO_MAX_DURATION;
-  action->generic_action.start = -1.0;
+  action->generic_action.start = surf_get_clock();
   action->generic_action.finish = -1.0;
   action->generic_action.model_type =
       (surf_model_t) surf_workstation_model;
   action->suspended = 0;       /* Should be useless because of the
                                   calloc but it seems to help valgrind... */
+  action->workstation_nb = workstation_nb;
+  action->workstation_list = (cpu_L07_t *)workstation_list;
+  action->computation_amount = computation_amount;
+  action->communication_amount = communication_amount;
+  action->latency = latency;
   action->generic_action.state_set =
       surf_workstation_model->common_public->states.running_action_set;
 
@@ -442,6 +554,9 @@ static surf_action_t execute_parallel_task(int workstation_nb,
        lmm_variable_new(ptask_maxmin_system, action, 1.0, action->rate,
                         workstation_nb + nb_link);
 
+  if (action->latency > 0) 
+    lmm_update_variable_weight(ptask_maxmin_system,action->variable,0.0);
+
   for (i = 0; i < workstation_nb; i++)
     lmm_expand(ptask_maxmin_system,
               ((cpu_L07_t) workstation_list[i])->constraint,
@@ -474,9 +589,16 @@ static surf_action_t execute_parallel_task(int workstation_nb,
 
 static surf_action_t execute(void *cpu, double size)
 {
-  double val = 0.0;
+  void **workstation_list = xbt_new0(void *, 1);
+  double *computation_amount = xbt_new0(double, 1);
+  double *communication_amount = xbt_new0(double, 1);
+
+  workstation_list[0] = cpu;
+  communication_amount[0] = 0.0;
+  computation_amount[0] = size;
 
-  return execute_parallel_task(1, &cpu, &size, &val, 1, -1);
+  return execute_parallel_task(1, workstation_list, computation_amount,
+                              communication_amount, 1, -1);
 }
 
 static surf_action_t communicate(void *src, void *dst, double size,
@@ -495,10 +617,6 @@ static surf_action_t communicate(void *src, void *dst, double size,
                              computation_amount, communication_amount,
                              1, rate);
 
-  free(computation_amount);
-  free(communication_amount);
-  free(workstation_list);
-
   return res;
 }
 
@@ -547,15 +665,16 @@ static double get_link_bandwidth(const void *link)
 
 static double get_link_latency(const void *link)
 {
-  static int warned = 0;
+  return ((network_link_L07_t) link)->lat_current;
+}
 
-  if(!warned) {
-    WARN0("This model does not take latency into account.");
-    warned = 1;
-  }
-  return 0.0;
+
+static xbt_dict_t get_link_properties(void *link)
+{
+ return ((network_link_L07_t) link)->properties;
 }
 
+
 /**************************************/
 /*** Resource Creation & Destruction **/
 /**************************************/
@@ -570,7 +689,8 @@ static cpu_L07_t cpu_new(const char *name, double power_scale,
                         double power_initial,
                         tmgr_trace_t power_trace,
                         e_surf_cpu_state_t state_initial,
-                        tmgr_trace_t state_trace)
+                        tmgr_trace_t state_trace,
+                         xbt_dict_t cpu_properties)
 {
   cpu_L07_t cpu = xbt_new0(s_cpu_L07_t, 1);
 
@@ -596,12 +716,19 @@ static cpu_L07_t cpu_new(const char *name, double power_scale,
       lmm_constraint_new(ptask_maxmin_system, cpu,
                         cpu->power_current * cpu->power_scale);
 
-  xbt_dict_set(workstation_set, name, cpu, cpu_free);
+  /*add the property set*/
+  cpu->properties =  current_property_set;
 
+  xbt_dict_set(workstation_set, name, cpu, cpu_free);
   return cpu;
 }
 
-static void parse_cpu(void)
+static void create_routing_table(void)
+{
+   routing_table = xbt_new0(s_route_L07_t, nb_workstation * nb_workstation);
+}
+
+static void parse_cpu_init(void)
 {
   double power_scale = 0.0;
   double power_initial = 0.0;
@@ -609,26 +736,22 @@ static void parse_cpu(void)
   e_surf_cpu_state_t state_initial = SURF_CPU_OFF;
   tmgr_trace_t state_trace = NULL;
 
-  surf_parse_get_double(&power_scale, A_surfxml_cpu_power);
-  surf_parse_get_double(&power_initial, A_surfxml_cpu_availability);
-  surf_parse_get_trace(&power_trace, A_surfxml_cpu_availability_file);
+  surf_parse_get_double(&power_scale, A_surfxml_host_power);
+  surf_parse_get_double(&power_initial, A_surfxml_host_availability);
+  surf_parse_get_trace(&power_trace, A_surfxml_host_availability_file);
 
-  xbt_assert0((A_surfxml_cpu_state == A_surfxml_cpu_state_ON) ||
-             (A_surfxml_cpu_state == A_surfxml_cpu_state_OFF),
+  xbt_assert0((A_surfxml_host_state == A_surfxml_host_state_ON) ||
+             (A_surfxml_host_state == A_surfxml_host_state_OFF),
              "Invalid state");
-  if (A_surfxml_cpu_state == A_surfxml_cpu_state_ON)
+  if (A_surfxml_host_state == A_surfxml_host_state_ON)
     state_initial = SURF_CPU_ON;
-  if (A_surfxml_cpu_state == A_surfxml_cpu_state_OFF)
+  if (A_surfxml_host_state == A_surfxml_host_state_OFF)
     state_initial = SURF_CPU_OFF;
-  surf_parse_get_trace(&state_trace, A_surfxml_cpu_state_file);
+  surf_parse_get_trace(&state_trace, A_surfxml_host_state_file);
 
-  cpu_new(A_surfxml_cpu_name, power_scale, power_initial, power_trace,
-         state_initial, state_trace);
-}
-
-static void create_routing_table(void)
-{
-  routing_table = xbt_new0(s_route_L07_t, nb_workstation * nb_workstation);
+  current_property_set = xbt_dict_new();
+  cpu_new(A_surfxml_host_id, power_scale, power_initial, power_trace,
+         state_initial, state_trace,/*add the properties*/current_property_set);
 }
 
 static void network_link_free(void *nw_link)
@@ -640,11 +763,13 @@ static void network_link_free(void *nw_link)
 static network_link_L07_t network_link_new(char *name,
                                           double bw_initial,
                                           tmgr_trace_t bw_trace,
+                                          double lat_initial,
+                                          tmgr_trace_t lat_trace,
                                           e_surf_network_link_state_t
                                           state_initial,
                                           tmgr_trace_t state_trace,
                                           e_surf_network_link_sharing_policy_t
-                                          policy)
+                                          policy, xbt_dict_t properties)
 {
   network_link_L07_t nw_link = xbt_new0(s_network_link_L07_t, 1);
 
@@ -657,6 +782,10 @@ static network_link_L07_t network_link_new(char *name,
     nw_link->bw_event =
        tmgr_history_add_trace(history, bw_trace, 0.0, 0, nw_link);
   nw_link->state_current = state_initial;
+  nw_link->lat_current = lat_initial;
+  if (lat_trace)
+    nw_link->lat_event =
+       tmgr_history_add_trace(history, lat_trace, 0.0, 0, nw_link);
   if (state_trace)
     nw_link->state_event =
        tmgr_history_add_trace(history, state_trace, 0.0, 0, nw_link);
@@ -668,47 +797,54 @@ static network_link_L07_t network_link_new(char *name,
   if (policy == SURF_NETWORK_LINK_FATPIPE)
     lmm_constraint_shared(nw_link->constraint);
 
+  nw_link->properties = properties;
+  
   xbt_dict_set(network_link_set, name, nw_link, network_link_free);
 
   return nw_link;
 }
 
-static void parse_network_link(void)
+static void parse_network_link_init(void)
 {
-  char *name;
+  char *name_link;
   double bw_initial;
   tmgr_trace_t bw_trace;
-  e_surf_network_link_state_t state_initial = SURF_NETWORK_LINK_ON;
-  e_surf_network_link_sharing_policy_t policy_initial =
-      SURF_NETWORK_LINK_SHARED;
+  double lat_initial;
+  tmgr_trace_t lat_trace;
+  e_surf_network_link_state_t state_initial_link = SURF_NETWORK_LINK_ON;
+  e_surf_network_link_sharing_policy_t policy_initial_link = SURF_NETWORK_LINK_SHARED;
   tmgr_trace_t state_trace;
 
-  name = xbt_strdup(A_surfxml_network_link_name);
-  surf_parse_get_double(&bw_initial, A_surfxml_network_link_bandwidth);
-  surf_parse_get_trace(&bw_trace, A_surfxml_network_link_bandwidth_file);
-
-  xbt_assert0((A_surfxml_network_link_state ==
-              A_surfxml_network_link_state_ON)
-             || (A_surfxml_network_link_state ==
-                 A_surfxml_network_link_state_OFF), "Invalid state");
-  if (A_surfxml_network_link_state == A_surfxml_network_link_state_ON)
-    state_initial = SURF_NETWORK_LINK_ON;
-  else if (A_surfxml_network_link_state ==
-          A_surfxml_network_link_state_OFF)
-    state_initial = SURF_NETWORK_LINK_OFF;
-
-  if (A_surfxml_network_link_sharing_policy ==
-      A_surfxml_network_link_sharing_policy_SHARED)
-    policy_initial = SURF_NETWORK_LINK_SHARED;
-  else if (A_surfxml_network_link_sharing_policy ==
-          A_surfxml_network_link_sharing_policy_FATPIPE)
-    policy_initial = SURF_NETWORK_LINK_FATPIPE;
-
-  surf_parse_get_trace(&state_trace, A_surfxml_network_link_state_file);
-
-  network_link_new(name, bw_initial, bw_trace, state_initial, state_trace,
-                  policy_initial);
-}
+  name_link = xbt_strdup(A_surfxml_link_id);
+  surf_parse_get_double(&bw_initial, A_surfxml_link_bandwidth);
+  surf_parse_get_trace(&bw_trace, A_surfxml_link_bandwidth_file);
+  surf_parse_get_double(&lat_initial, A_surfxml_link_latency);
+  surf_parse_get_trace(&lat_trace, A_surfxml_link_latency_file);
+
+  xbt_assert0((A_surfxml_link_state ==
+              A_surfxml_link_state_ON)
+             || (A_surfxml_link_state ==
+                 A_surfxml_link_state_OFF), "Invalid state");
+  if (A_surfxml_link_state == A_surfxml_link_state_ON)
+    state_initial_link = SURF_NETWORK_LINK_ON;
+  else if (A_surfxml_link_state ==
+          A_surfxml_link_state_OFF)
+    state_initial_link = SURF_NETWORK_LINK_OFF;
+
+  if (A_surfxml_link_sharing_policy ==
+      A_surfxml_link_sharing_policy_SHARED)
+    policy_initial_link = SURF_NETWORK_LINK_SHARED;
+  else if (A_surfxml_link_sharing_policy ==
+          A_surfxml_link_sharing_policy_FATPIPE)
+    policy_initial_link = SURF_NETWORK_LINK_FATPIPE;
+
+  surf_parse_get_trace(&state_trace, A_surfxml_link_state_file);
+
+  current_property_set = xbt_dict_new();
+  network_link_new(name_link, bw_initial, bw_trace, lat_initial, lat_trace,
+                  state_initial_link, state_trace, policy_initial_link, current_property_set);
+
+ }
 
 static void route_new(int src_id, int dst_id,
                      network_link_L07_t * link_list, int nb_link)
@@ -725,11 +861,15 @@ static int link_list_capacity;
 static network_link_L07_t *link_list = NULL;
 static int src_id = -1;
 static int dst_id = -1;
+static int is_first =0;
 
 static void parse_route_set_endpoints(void)
 {
   cpu_L07_t cpu_tmp = NULL;
 
+  if (!is_first) create_routing_table();
+  is_first = 1;        
+
   cpu_tmp = (cpu_L07_t) name_service(A_surfxml_route_src);
   xbt_assert1(cpu_tmp, "Invalid cpu %s", A_surfxml_route_src);
   if (cpu_tmp != NULL)
@@ -756,11 +896,11 @@ static void parse_route_elem(void)
   }
   TRY {
     link_list[nb_link++] =
-       xbt_dict_get(network_link_set, A_surfxml_route_element_name);
+       xbt_dict_get(network_link_set, A_surfxml_link_c_ctn_id);
   }
   CATCH(e) {
     RETHROW1("Link %s not found (dict raised this exception: %s)",
-            A_surfxml_route_element_name);
+            A_surfxml_link_c_ctn_id);
   }
 }
 
@@ -774,27 +914,16 @@ static void parse_file(const char *file)
 {
   int i;
 
-  /* Figuring out the cpus */
+  /* Adding callback functions */
   surf_parse_reset_parser();
-  ETag_surfxml_cpu_fun = parse_cpu;
-  surf_parse_open(file);
-  xbt_assert1((!surf_parse()), "Parse error in %s", file);
-  surf_parse_close();
-
-  create_routing_table();
-
-  /* Figuring out the network links */
-  surf_parse_reset_parser();
-  ETag_surfxml_network_link_fun = parse_network_link;
-  surf_parse_open(file);
-  xbt_assert1((!surf_parse()), "Parse error in %s", file);
-  surf_parse_close();
-
-  /* Building the routes */
-  surf_parse_reset_parser();
-  STag_surfxml_route_fun = parse_route_set_endpoints;
-  ETag_surfxml_route_element_fun = parse_route_elem;
-  ETag_surfxml_route_fun = parse_route_set_route;
+  surfxml_add_callback(STag_surfxml_host_cb_list, &parse_cpu_init);
+  surfxml_add_callback(STag_surfxml_prop_cb_list, &parse_properties);
+  surfxml_add_callback(STag_surfxml_link_cb_list, &parse_network_link_init);
+  surfxml_add_callback(STag_surfxml_route_cb_list, &parse_route_set_endpoints);
+  surfxml_add_callback(ETag_surfxml_link_c_ctn_cb_list, &parse_route_elem);
+  surfxml_add_callback(ETag_surfxml_route_cb_list, &parse_route_set_route);
+
+  /* Parse the file */
   surf_parse_open(file);
   xbt_assert1((!surf_parse()), "Parse error in %s", file);
   surf_parse_close();
@@ -804,9 +933,9 @@ static void parse_file(const char *file)
     if (!ROUTE(i, i).size) {
       if (!loopback)
        loopback = network_link_new(xbt_strdup("__MSG_loopback__"),
-                                   498000000, NULL,
+                                   498000000, NULL, 0.000015, NULL,
                                    SURF_NETWORK_LINK_ON, NULL,
-                                   SURF_NETWORK_LINK_FATPIPE);
+                                   SURF_NETWORK_LINK_FATPIPE,NULL);
 
       ROUTE(i, i).size = 1;
       ROUTE(i, i).links = xbt_new0(network_link_L07_t, 1);
@@ -897,6 +1026,9 @@ static void model_init_internal(void)
   surf_workstation_model->extension_public->get_link_latency =
       get_link_latency;
 
+  surf_workstation_model->common_public->get_link_properties = get_link_properties;
+  surf_workstation_model->common_public->get_cpu_properties = get_properties;
+
   workstation_set = xbt_dict_new();
   network_link_set = xbt_dict_new();
 
@@ -914,7 +1046,6 @@ void surf_workstation_model_init_ptask_L07(const char *filename)
              "network model type already defined");
   model_init_internal();
   parse_file(filename);
-  WARN0("This model does not take latency into account.");
 
   update_model_description(surf_workstation_model_description,
                              surf_workstation_model_description_size,