plug some more memleaks. aint bad anymore

[simgrid.git] / src / surf / surf_routing.c

diff --git a/src/surf/surf_routing.c b/src/surf/surf_routing.c
index 7924713..c5b0e2d 100644 (file)
--- a/src/surf/surf_routing.c
+++ b/src/surf/surf_routing.c
@@ -251,6 +251,7 @@ static void routing_parse_E_route(void)
              "no defined method \"set_route\" in \"%s\"",
              current_routing->name);
   current_routing->parse_route(current_routing, src, dst, route);
+  generic_free_route(route);
   parsed_link_list = NULL;
   src = NULL;
   dst = NULL;
@@ -269,6 +270,7 @@ static void routing_parse_E_ASroute(void)
              "no defined method \"set_ASroute\" in \"%s\"",
              current_routing->name);
   current_routing->parse_ASroute(current_routing, src, dst, e_route);
+  generic_free_route(e_route);
   parsed_link_list = NULL;
   src = NULL;
   dst = NULL;
@@ -519,10 +521,10 @@ static void _get_route_and_latency(const char *src, const char *dst,
 
   if (e_route_bypass) { /* Common ancestor is kind enough to declare a bypass route from src to dst -- use it and bail out */
     if (latency)
-      xbt_die("Bypass cannot work yet with get_latency"); // FIXME: that limitation seems supurious to me -- check with alvin
-
-    *links = xbt_dynar_new(global_routing->size_of_link, NULL);
+      xbt_die("Bypass cannot work yet with get_latency"); // FIXME: get_bypass_route should update the latency itself, just like get_route
 
+    // FIXME this path is never tested. I need examples to check the bypass mechanism...
+    THROW_UNIMPLEMENTED; // let's warn the users of the problem
     xbt_dynar_foreach(e_route_bypass->link_list, cpt, link) {
       xbt_dynar_push(*links, &link);
     }
@@ -534,27 +536,20 @@ static void _get_route_and_latency(const char *src, const char *dst,
 
   /* Not in the same AS, no bypass. We'll have to find our path between the ASes recursively*/
 
-  route_t e_route_cnt = xbt_new0(s_route_t, 1);
-  e_route_cnt->link_list = xbt_dynar_new(global_routing->size_of_link, NULL);
-  common_father->get_route_and_latency(common_father, src_father->name, dst_father->name, e_route_cnt,latency);
-
-  xbt_assert(e_route_cnt, "no route between \"%s\" and \"%s\"",
-      src_father->name, dst_father->name);
+  route.link_list = xbt_dynar_new(global_routing->size_of_link, NULL);
+  common_father->get_route_and_latency(common_father, src_father->name, dst_father->name, &route,latency);
 
-  xbt_assert((e_route_cnt->src_gateway == NULL) ==
-      (e_route_cnt->dst_gateway == NULL),
+  xbt_assert((route.src_gateway != NULL) && (route.dst_gateway != NULL),
       "bad gateways for route from \"%s\" to \"%s\"", src, dst);
 
-  *links = xbt_dynar_new(global_routing->size_of_link, NULL);
-
-  char*src_gateway = e_route_cnt->src_gateway;
-  char*dst_gateway = e_route_cnt->dst_gateway;
+  char*src_gateway = route.src_gateway;
+  char*dst_gateway = route.dst_gateway;
 
   /* If source gateway is not our source, we have to recursively find our way up to this point */
   if (strcmp(src, src_gateway))
     _get_route_and_latency(src, src_gateway, links, latency);
 
-  xbt_dynar_foreach(e_route_cnt->link_list, cpt, link) {
+  xbt_dynar_foreach(route.link_list, cpt, link) {
     xbt_dynar_push(*links, &link);
   }
 
@@ -569,10 +564,11 @@ static void _get_route_and_latency(const char *src, const char *dst,
       xbt_dynar_push(*links, &link);
     }
     xbt_dynar_free(&route_dst);
-
   }
 
-  generic_free_route(e_route_cnt);
+  xbt_free(src_gateway);
+  xbt_free_f(dst_gateway);
+  xbt_dynar_free(&route.link_list);
 }
 
 /**