Fix segfault when using parallel contexts

[simgrid.git] / src / simix / smx_context_raw.c

diff --git a/src/simix/smx_context_raw.c b/src/simix/smx_context_raw.c
index 591d65e..37f61d6 100644 (file)
--- a/src/simix/smx_context_raw.c
+++ b/src/simix/smx_context_raw.c
@@ -7,6 +7,8 @@
  * under the terms of the license (GNU LGPL) which comes with this package. */
 
 #include "simix/private.h"
+#include "xbt/parmap.h"
+
 
 #ifdef HAVE_VALGRIND_VALGRIND_H
 #  include <valgrind/valgrind.h>
@@ -19,12 +21,6 @@
 #include "ucontext.h"
 #endif
 
-/* lower this if you want to reduce the memory consumption  */
-#ifndef CONTEXT_STACK_SIZE      /* allow lua to override this */
-#define CONTEXT_STACK_SIZE 128*1024
-#endif                          /*CONTEXT_STACK_SIZE */
-
-
 typedef char * raw_stack_t;
 typedef void (*rawctx_entry_point_t)(void *);
 
@@ -157,23 +153,31 @@ void raw_swapcontext(raw_stack_t* old, raw_stack_t new) {
 
 XBT_LOG_EXTERNAL_DEFAULT_CATEGORY(simix_context);
 
-static void smx_ctx_raw_wrapper(smx_ctx_raw_t context);
+static xbt_parmap_t parmap;
 
+#ifdef CONTEXT_THREADS
+static __thread smx_context_t current_context;
+#endif
+
+static void smx_ctx_raw_wrapper(smx_ctx_raw_t context);
 
 static int smx_ctx_raw_factory_finalize(smx_context_factory_t *factory)
 { 
+  if(parmap)
+      xbt_parmap_destroy(parmap);
   return smx_ctx_base_factory_finalize(factory);
 }
 
+
 static smx_context_t
-smx_ctx_raw_create_context_sized(size_t size, xbt_main_func_t code,
-    int argc, char **argv,
+smx_ctx_raw_create_context(xbt_main_func_t code, int argc, char **argv,
     void_pfn_smxprocess_t cleanup_func,
     void *data)
 {
 
   smx_ctx_raw_t context =
-      (smx_ctx_raw_t) smx_ctx_base_factory_create_context_sized(size,
+      (smx_ctx_raw_t) smx_ctx_base_factory_create_context_sized(
+          sizeof(s_smx_ctx_raw_t),
           code,
           argc,
           argv,
@@ -183,35 +187,23 @@ smx_ctx_raw_create_context_sized(size_t size, xbt_main_func_t code,
   /* If the user provided a function for the process then use it
      otherwise is the context for maestro */
      if (code) {
-       context->malloced_stack = xbt_malloc0(CONTEXT_STACK_SIZE);
+       context->malloced_stack = xbt_malloc0(smx_context_stack_size);
        context->stack_top =
-           raw_makecontext(context->malloced_stack,CONTEXT_STACK_SIZE,
+           raw_makecontext(context->malloced_stack, smx_context_stack_size,
                (void(*)(void*))smx_ctx_raw_wrapper,context);
 
 #ifdef HAVE_VALGRIND_VALGRIND_H
        context->valgrind_stack_id =
            VALGRIND_STACK_REGISTER(context->malloced_stack,
-               context->malloced_stack + CONTEXT_STACK_SIZE);
+               context->malloced_stack + smx_context_stack_size);
 #endif                          /* HAVE_VALGRIND_VALGRIND_H */
 
      }else{
        maestro_raw_context = context;
+       current_context = (smx_context_t) maestro_raw_context;
      }
 
      return (smx_context_t) context;
-
-}
-
-static smx_context_t
-smx_ctx_raw_create_context(xbt_main_func_t code, int argc, char **argv,
-    void_pfn_smxprocess_t cleanup_func,
-    void *data)
-{
-
-  return smx_ctx_raw_create_context_sized(sizeof(s_smx_ctx_raw_t),
-      code, argc, argv, cleanup_func,
-      data);
-
 }
 
 static void smx_ctx_raw_free(smx_context_t context)
@@ -224,6 +216,7 @@ static void smx_ctx_raw_free(smx_context_t context)
         context)->valgrind_stack_id);
 #endif                          /* HAVE_VALGRIND_VALGRIND_H */
 
+    free(((smx_ctx_raw_t)context)->malloced_stack);
   }
   smx_ctx_base_free(context);
 }
@@ -269,24 +262,29 @@ static void smx_ctx_raw_runall(xbt_dynar_t processes)
   xbt_dynar_reset(processes);
 }
 
-static void smx_ctx_raw_resume_parallel(smx_context_t context)
+static void smx_ctx_raw_resume_parallel(smx_process_t process)
 {
-  xbt_os_thread_set_extra_data(context);
+  smx_ctx_raw_t context = (smx_ctx_raw_t)process->context;
+  /*xbt_os_thread_set_extra_data(context);*/
+  current_context = (smx_context_t)context;
   raw_swapcontext(
-      &((smx_ctx_raw_t) context)->old_stack_top,
-      ((smx_ctx_raw_t) context)->stack_top);
-  xbt_os_thread_set_extra_data(NULL);
+      &context->old_stack_top,
+      context->stack_top);
+  current_context = (smx_context_t)maestro_raw_context;
+  /*xbt_os_thread_set_extra_data(NULL);*/
 }
 
 static void smx_ctx_raw_runall_parallel(xbt_dynar_t processes)
 {
-  return;
+  xbt_parmap_apply(parmap, (void_f_pvoid_t)smx_ctx_raw_resume_parallel, processes);
+  xbt_dynar_reset(processes);
 }
 
 static smx_context_t smx_ctx_raw_self_parallel(void)
 {
-  smx_context_t self_context = (smx_context_t) xbt_os_thread_get_extra_data();
-  return self_context ? self_context : (smx_context_t) maestro_raw_context;
+  /*smx_context_t self_context = (smx_context_t) xbt_os_thread_get_extra_data();
+  return self_context ? self_context : (smx_context_t) maestro_raw_context;*/
+  return current_context;
 }
 
 void SIMIX_ctx_raw_factory_init(smx_context_factory_t *factory)
@@ -302,8 +300,9 @@ void SIMIX_ctx_raw_factory_init(smx_context_factory_t *factory)
   (*factory)->suspend = smx_ctx_raw_suspend;
   (*factory)->name = "smx_raw_context_factory";
 
-  if(_surf_parallel_contexts){
+  if (smx_parallel_contexts) {
 #ifdef CONTEXT_THREADS  /* To use parallel ucontexts a thread pool is needed */
+    parmap = xbt_parmap_new(2);
     (*factory)->runall = smx_ctx_raw_runall_parallel;
     (*factory)->self = smx_ctx_raw_self_parallel;
 #else