Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
Lots of bugfixes for the fat trees, it should at least not crash when using it
[simgrid.git] / src / surf / surf_routing.cpp
index 6216697..1129d13 100644 (file)
@@ -1,4 +1,4 @@
-/* Copyright (c) 2009, 2010, 2011, 2013. The SimGrid Team.
+/* Copyright (c) 2009-2011, 2013-2014. The SimGrid Team.
  * All rights reserved.                                                     */
 
 /* This program is free software; you can redistribute it and/or modify it
@@ -6,12 +6,17 @@
 
 #include "surf_routing.hpp"
 #include "surf_routing_private.hpp"
+#include "surf_routing_cluster.hpp"
+#include "surf_routing_cluster_torus.hpp"
+#include "surf_routing_cluster_fat_tree.hpp"
 
 #include "simgrid/platf_interface.h"    // platform creation API internal interface
 #include "simgrid/sg_config.h"
+#include "storage_interface.hpp"
 
 #include "surf/surfxml_parse_values.h"
 
+
 /**
  * @ingroup SURF_build_api
  * @brief A library containing all known workstations
@@ -25,6 +30,7 @@ int SIMIX_HOST_LEVEL;           //Simix host level
 int SIMIX_STORAGE_LEVEL;        //Simix storage level
 int MSG_HOST_LEVEL;             //Msg host level
 int MSG_STORAGE_LEVEL;          //Msg storage level
+int MSG_FILE_LEVEL;             //Msg file level
 int SD_HOST_LEVEL;              //Simdag host level
 int SD_STORAGE_LEVEL;           //Simdag storage level
 int COORD_HOST_LEVEL=0;         //Coordinates level
@@ -66,12 +72,10 @@ AsPtr current_routing = NULL;
 /* global parse functions */
 extern xbt_dynar_t mount_list;
 
-extern "C" {
 XBT_LOG_NEW_DEFAULT_SUBCATEGORY(surf_route, surf, "Routing part of surf");
-}
 
 static void routing_parse_peer(sg_platf_peer_cbarg_t peer);     /* peer bypass */
-static void routing_parse_Srandom(void);        /* random bypass */
+// static void routing_parse_Srandom(void);        /* random bypass */
 
 static void routing_parse_postparse(void);
 
@@ -83,7 +87,9 @@ typedef enum {
   SURF_MODEL_DIJKSTRACACHE,
   SURF_MODEL_NONE,
   SURF_MODEL_VIVALDI,
-  SURF_MODEL_CLUSTER
+  SURF_MODEL_CLUSTER,
+  SURF_MODEL_TORUS_CLUSTER,
+  SURF_MODEL_FAT_TREE_CLUSTER,
 } e_routing_types;
 
 struct s_model_type routing_models[] = {
@@ -105,6 +111,10 @@ struct s_model_type routing_models[] = {
    model_vivaldi_create, NULL},
   {"Cluster", "Cluster routing",
    model_cluster_create, NULL},
+  {"Torus_Cluster", "Torus Cluster routing",
+   model_torus_cluster_create, NULL},
+  {"Fat_Tree_Cluster", "Fat Tree Cluster routing",
+   model_fat_tree_cluster_create, NULL},
   {NULL, NULL, NULL, NULL}
 };
 
@@ -122,8 +132,6 @@ static void parse_S_host_link(sg_platf_host_link_cbarg_t host)
   s_surf_parsing_link_up_down_t link_up_down;
   link_up_down.link_up = xbt_lib_get_or_null(link_lib, host->link_up, SURF_LINK_LEVEL);
   link_up_down.link_down = xbt_lib_get_or_null(link_lib, host->link_down, SURF_LINK_LEVEL);
-  link_up_down.limiter_link = NULL;
-  link_up_down.loopback_link = NULL;
 
   xbt_assert(link_up_down.link_up, "Link '%s' not found!",host->link_up);
   xbt_assert(link_up_down.link_down, "Link '%s' not found!",host->link_down);
@@ -132,12 +140,12 @@ static void parse_S_host_link(sg_platf_host_link_cbarg_t host)
     current_routing->p_linkUpDownList = xbt_dynar_new(sizeof(s_surf_parsing_link_up_down_t),NULL);
 
   // If dynar is is greater than edge id and if the host_link is already defined
-  if((int)xbt_dynar_length(current_routing->p_linkUpDownList) > info->m_id &&
-      xbt_dynar_get_as(current_routing->p_linkUpDownList, info->m_id, void*))
-    xbt_die("Host_link for '%s' is already defined!",host->id);
+  if((int)xbt_dynar_length(current_routing->p_linkUpDownList) > info->getId() &&
+      xbt_dynar_get_as(current_routing->p_linkUpDownList, info->getId(), void*))
+       surf_parse_error("Host_link for '%s' is already defined!",host->id);
 
-  XBT_DEBUG("Push Host_link for host '%s' to position %d", info->p_name, info->m_id);
-  xbt_dynar_set_as(current_routing->p_linkUpDownList, info->m_id, s_surf_parsing_link_up_down_t, link_up_down);
+  XBT_DEBUG("Push Host_link for host '%s' to position %d", info->getName(), info->getId());
+  xbt_dynar_set_as(current_routing->p_linkUpDownList, info->getId(), s_surf_parsing_link_up_down_t, link_up_down);
 }
 
 /**
@@ -150,13 +158,13 @@ static void parse_S_host(sg_platf_host_cbarg_t host)
   xbt_assert(!xbt_lib_get_or_null(host_lib, host->id, ROUTING_HOST_LEVEL),
              "Reading a host, processing unit \"%s\" already exists", host->id);
 
-  RoutingEdgePtr info = new RoutingEdge();
-  info->p_rcComponent = current_routing;
-  info->p_rcType = SURF_NETWORK_ELEMENT_HOST;
-  info->p_name = xbt_strdup(host->id);
-  info->m_id = current_routing->parsePU(info);
+  RoutingEdgePtr info = new RoutingEdgeImpl(xbt_strdup(host->id),
+                                                   -1,
+                                                   SURF_NETWORK_ELEMENT_HOST,
+                                                   current_routing);
+  info->setId(current_routing->parsePU(info));
   xbt_lib_set(host_lib, host->id, ROUTING_HOST_LEVEL, (void *) info);
-  XBT_DEBUG("Having set name '%s' id '%d'", host->id, info->m_id);
+  XBT_DEBUG("Having set name '%s' id '%d'", host->id, info->getId());
 
   if(mount_list){
     xbt_lib_set(storage_lib, host->id, ROUTING_STORAGE_HOST_LEVEL, (void *) mount_list);
@@ -194,13 +202,13 @@ static void parse_S_router(sg_platf_router_cbarg_t router)
              "Reading a router, processing unit \"%s\" already exists",
              router->id);
 
-  RoutingEdgePtr info = new RoutingEdge();
-  info->p_rcComponent = current_routing;
-  info->p_rcType = SURF_NETWORK_ELEMENT_ROUTER;
-  info->p_name = xbt_strdup(router->id);
-  info->m_id = current_routing->parsePU(info);
+  RoutingEdgePtr info = new RoutingEdgeImpl(xbt_strdup(router->id),
+                                            -1,
+                                            SURF_NETWORK_ELEMENT_ROUTER,
+                                            current_routing);
+  info->setId(current_routing->parsePU(info));
   xbt_lib_set(as_router_lib, router->id, ROUTING_ASR_LEVEL, (void *) info);
-  XBT_DEBUG("Having set name '%s' id '%d'", router->id, info->m_id);
+  XBT_DEBUG("Having set name '%s' id '%d'", router->id, info->getId());
 
   if (router->coord && strcmp(router->coord, "")) {
     unsigned int cursor;
@@ -316,7 +324,7 @@ static void routing_parse_trace_connect(sg_platf_trace_connect_cbarg_t trace_con
         xbt_strdup(trace_connect->element), NULL);
     break;
   default:
-    xbt_die("Cannot connect trace %s to %s: kind of trace unknown",
+       surf_parse_error("Cannot connect trace %s to %s: kind of trace unknown",
         trace_connect->trace, trace_connect->element);
     break;
   }
@@ -350,13 +358,15 @@ void routing_AS_begin(sg_platf_AS_cbarg_t AS)
 
   /* search the routing model */
   switch(AS->routing){
-    case A_surfxml_AS_routing_Cluster:       model = &routing_models[SURF_MODEL_CLUSTER];break;
-    case A_surfxml_AS_routing_Dijkstra:      model = &routing_models[SURF_MODEL_DIJKSTRA];break;
-    case A_surfxml_AS_routing_DijkstraCache: model = &routing_models[SURF_MODEL_DIJKSTRACACHE];break;
-    case A_surfxml_AS_routing_Floyd:         model = &routing_models[SURF_MODEL_FLOYD];break;
-    case A_surfxml_AS_routing_Full:          model = &routing_models[SURF_MODEL_FULL];break;
-    case A_surfxml_AS_routing_None:          model = &routing_models[SURF_MODEL_NONE];break;
-    case A_surfxml_AS_routing_Vivaldi:       model = &routing_models[SURF_MODEL_VIVALDI];break;
+    case A_surfxml_AS_routing_Cluster:               model = &routing_models[SURF_MODEL_CLUSTER];break;
+    case A_surfxml_AS_routing_Cluster___torus:       model = &routing_models[SURF_MODEL_TORUS_CLUSTER];break;
+    case A_surfxml_AS_routing_Cluster___fat___tree:  model = &routing_models[SURF_MODEL_FAT_TREE_CLUSTER];break;
+    case A_surfxml_AS_routing_Dijkstra:              model = &routing_models[SURF_MODEL_DIJKSTRA];break;
+    case A_surfxml_AS_routing_DijkstraCache:         model = &routing_models[SURF_MODEL_DIJKSTRACACHE];break;
+    case A_surfxml_AS_routing_Floyd:                 model = &routing_models[SURF_MODEL_FLOYD];break;
+    case A_surfxml_AS_routing_Full:                  model = &routing_models[SURF_MODEL_FULL];break;
+    case A_surfxml_AS_routing_None:                  model = &routing_models[SURF_MODEL_NONE];break;
+    case A_surfxml_AS_routing_Vivaldi:               model = &routing_models[SURF_MODEL_VIVALDI];break;
     default: xbt_die("Not a valid model!!!");
     break;
   }
@@ -368,14 +378,16 @@ void routing_AS_begin(sg_platf_AS_cbarg_t AS)
   new_as->p_hierarchy = SURF_ROUTING_NULL;
   new_as->p_name = xbt_strdup(AS->id);
 
-  RoutingEdgePtr info = new RoutingEdge();
-
+  RoutingEdgePtr info = new RoutingEdgeImpl(xbt_strdup(new_as->p_name),
+                                            -1,
+                                            SURF_NETWORK_ELEMENT_AS,
+                                            current_routing);
   if (current_routing == NULL && routing_platf->p_root == NULL) {
 
     /* it is the first one */
     new_as->p_routingFather = NULL;
     routing_platf->p_root = new_as;
-    info->m_id = -1;
+    info->setId(-1);
   } else if (current_routing != NULL && routing_platf->p_root != NULL) {
 
     xbt_assert(!xbt_dict_get_or_null
@@ -390,18 +402,14 @@ void routing_AS_begin(sg_platf_AS_cbarg_t AS)
     xbt_dict_set(current_routing->p_routingSons, AS->id,
                  (void *) new_as, NULL);
     /* add to the father element list */
-    info->m_id = current_routing->parseAS(info);
+    info->setId(current_routing->parseAS(info));
   } else {
-    THROWF(arg_error, 0, "All defined components must be belong to a AS");
+    THROWF(arg_error, 0, "All defined components must belong to a AS");
   }
 
-  info->p_rcComponent = new_as->p_routingFather;
-  info->p_rcType = SURF_NETWORK_ELEMENT_AS;
-  info->p_name = xbt_strdup(new_as->p_name);
-
-  xbt_lib_set(as_router_lib, info->p_name, ROUTING_ASR_LEVEL,
+  xbt_lib_set(as_router_lib, info->getName(), ROUTING_ASR_LEVEL,
               (void *) info);
-  XBT_DEBUG("Having set name '%s' id '%d'", new_as->p_name, info->m_id);
+  XBT_DEBUG("Having set name '%s' id '%d'", new_as->p_name, info->getId());
 
   /* set the new current component of the tree */
   current_routing = new_as;
@@ -463,11 +471,11 @@ static void elements_father(sg_routing_edge_t src, sg_routing_edge_t dst,
   /* (1) find the as where the src and dst are located */
   sg_routing_edge_t src_data = src;
   sg_routing_edge_t dst_data = dst;
-  src_as = src_data->p_rcComponent;
-  dst_as = dst_data->p_rcComponent;
+  src_as = src_data->getRcComponent();
+  dst_as = dst_data->getRcComponent();
 #ifndef NDEBUG
-  char* src_name = src_data->p_name;
-  char* dst_name = dst_data->p_name;
+  char* src_name = src_data->getName();
+  char* dst_name = dst_data->getName();
 #endif
 
   xbt_assert(src_as && dst_as,
@@ -525,7 +533,7 @@ static void _get_route_and_latency(RoutingEdgePtr src, RoutingEdgePtr dst,
   memset(&route,0,sizeof(route));
 
   xbt_assert(src && dst, "bad parameters for \"_get_route_latency\" method");
-  XBT_DEBUG("Solve route/latency  \"%s\" to \"%s\"", src->p_name, dst->p_name);
+  XBT_DEBUG("Solve route/latency  \"%s\" to \"%s\"", src->getName(), dst->getName());
 
   /* Find how src and dst are interconnected */
   AsPtr common_father, src_father, dst_father;
@@ -542,7 +550,7 @@ static void _get_route_and_latency(RoutingEdgePtr src, RoutingEdgePtr dst,
   /* Common ancestor is kind enough to declare a bypass route from src to dst -- use it and bail out */
   if (e_route_bypass) {
     xbt_dynar_merge(links, &e_route_bypass->link_list);
-    //FIXME:generic_free_route(e_route_bypass);
+    generic_free_route(e_route_bypass);
     return;
   }
 
@@ -565,7 +573,7 @@ static void _get_route_and_latency(RoutingEdgePtr src, RoutingEdgePtr dst,
                                     &route, latency);
 
   xbt_assert((route.gw_src != NULL) && (route.gw_dst != NULL),
-      "bad gateways for route from \"%s\" to \"%s\"", src->p_name, dst->p_name);
+      "bad gateways for route from \"%s\" to \"%s\"", src->getName(), dst->getName());
 
   sg_routing_edge_t src_gateway_net_elm = route.gw_src;
   sg_routing_edge_t dst_gateway_net_elm = route.gw_dst;
@@ -587,7 +595,7 @@ AS_t surf_platf_get_root(routing_platf_t platf){
 }
 
 e_surf_network_element_type_t surf_routing_edge_get_rc_type(sg_routing_edge_t edge){
-  return edge->p_rcType;
+  return edge->getRcType();
 }
 
 
@@ -608,7 +616,7 @@ e_surf_network_element_type_t surf_routing_edge_get_rc_type(sg_routing_edge_t ed
 void RoutingPlatf::getRouteAndLatency(RoutingEdgePtr src, RoutingEdgePtr dst,
                                    xbt_dynar_t* route, double *latency)
 {
-  XBT_DEBUG("routing_get_route_and_latency from %s to %s", src->p_name, dst->p_name);
+  XBT_DEBUG("routing_get_route_and_latency from %s to %s", src->getName(), dst->getName());
   if (!*route) {
     xbt_dynar_reset(routing_platf->p_lastRoute);
     *route = routing_platf->p_lastRoute;
@@ -617,7 +625,7 @@ void RoutingPlatf::getRouteAndLatency(RoutingEdgePtr src, RoutingEdgePtr dst,
   _get_route_and_latency(src, dst, route, latency);
 
   xbt_assert(!latency || *latency >= 0.0,
-             "negative latency on route between \"%s\" and \"%s\"", src->p_name, dst->p_name);
+             "negative latency on route between \"%s\" and \"%s\"", src->getName(), dst->getName());
 }
 
 xbt_dynar_t RoutingPlatf::getOneLinkRoutes(){
@@ -649,7 +657,7 @@ e_surf_network_element_type_t routing_get_network_element_type(const char *name)
 {
   RoutingEdgePtr rc = sg_routing_edge_by_name_or_null(name);
   if (rc)
-    return rc->p_rcType;
+    return rc->getRcType();
 
   return SURF_NETWORK_ELEMENT_NULL;
 }
@@ -801,6 +809,7 @@ static void routing_parse_cluster(sg_platf_cluster_cbarg_t cluster)
 {
   char *host_id, *groups, *link_id = NULL;
   xbt_dict_t patterns = NULL;
+  int rankId=0;
 
   s_sg_platf_host_cbarg_t host;
   s_sg_platf_link_cbarg_t link;
@@ -818,11 +827,43 @@ static void routing_parse_cluster(sg_platf_cluster_cbarg_t cluster)
     xbt_dict_set(patterns, "suffix", xbt_strdup(cluster->suffix), NULL);
   }
 
-  XBT_DEBUG("<AS id=\"%s\"\trouting=\"Cluster\">", cluster->id);
+  /* parse the topology attribute. If we are not in a flat cluster,
+   * switch to the right mode and initialize the routing with
+   * the parameters in topo_parameters attribute
+   */
   s_sg_platf_AS_cbarg_t AS = SG_PLATF_AS_INITIALIZER;
   AS.id = cluster->id;
-  AS.routing = A_surfxml_AS_routing_Cluster;
-  sg_platf_new_AS_begin(&AS);
+
+  if(cluster->topology == SURF_CLUSTER_TORUS){
+    XBT_DEBUG("<AS id=\"%s\"\trouting=\"Torus_Cluster\">", cluster->id);
+    AS.routing = A_surfxml_AS_routing_Cluster___torus;
+    sg_platf_new_AS_begin(&AS);
+    ((AsClusterTorusPtr)current_routing)->parse_specific_arguments(cluster);
+  }
+  else if (cluster->topology == SURF_CLUSTER_FAT_TREE) {
+    XBT_DEBUG("<AS id=\"%s\"\trouting=\"Fat_Tree_Cluster\">", cluster->id);
+    AS.routing = A_surfxml_AS_routing_Cluster___fat___tree;
+    sg_platf_new_AS_begin(&AS);
+    ((AsClusterFatTree*)current_routing)->parse_specific_arguments(cluster);
+  }
+  
+  else{
+    XBT_DEBUG("<AS id=\"%s\"\trouting=\"Cluster\">", cluster->id);
+    AS.routing = A_surfxml_AS_routing_Cluster;
+    sg_platf_new_AS_begin(&AS);
+  }
+
+  if(cluster->loopback_bw!=0 || cluster->loopback_lat!=0){
+      ((AsClusterPtr)current_routing)->p_nb_links_per_node++;
+      ((AsClusterPtr)current_routing)->p_has_loopback=1;
+  }
+
+  if(cluster->limiter_link!=0){
+      ((AsClusterPtr)current_routing)->p_nb_links_per_node++;
+      ((AsClusterPtr)current_routing)->p_has_limiter=1;
+  }
+
+
 
   current_routing->p_linkUpDownList
             = xbt_dynar_new(sizeof(s_surf_parsing_link_up_down_t),NULL);
@@ -872,7 +913,7 @@ static void routing_parse_cluster(sg_platf_cluster_cbarg_t cluster)
       } else {
         XBT_DEBUG("\tstate_file=\"\"");
       }
-
+      
       xbt_dynar_t power_state_list = xbt_dynar_new(sizeof(double), NULL);
       xbt_dynar_push(power_state_list,&cluster->power);
       host.power_peak = power_state_list;
@@ -889,30 +930,37 @@ static void routing_parse_cluster(sg_platf_cluster_cbarg_t cluster)
       XBT_DEBUG("<link\tid=\"%s\"\tbw=\"%f\"\tlat=\"%f\"/>", link_id,
                 cluster->bw, cluster->lat);
 
-      memset(&link, 0, sizeof(link));
-      link.id = link_id;
-      link.bandwidth = cluster->bw;
-      link.latency = cluster->lat;
-      link.state = SURF_RESOURCE_ON;
-      link.policy = cluster->sharing_policy;
-      sg_platf_new_link(&link);
 
-      s_surf_parsing_link_up_down_t info;
+      s_surf_parsing_link_up_down_t info_lim, info_loop;
+      // All links are saved in a matrix;
+      // every row describes a single node; every node
+      // may have multiple links.
+      // the first column may store a link from x to x if p_has_loopback is set
+      // the second column may store a limiter link if p_has_limiter is set
+      // other columns are to store one or more link for the node
 
-      if (link.policy == SURF_LINK_FULLDUPLEX) {
-        char *tmp_link = bprintf("%s_UP", link_id);
-        info.link_up =
-            xbt_lib_get_or_null(link_lib, tmp_link, SURF_LINK_LEVEL);
-        free(tmp_link);
-        tmp_link = bprintf("%s_DOWN", link_id);
-        info.link_down =
+      //add a loopback link
+      if(cluster->loopback_bw!=0 || cluster->loopback_lat!=0){
+        char *tmp_link = bprintf("%s_loopback", link_id);
+        XBT_DEBUG("<loopback\tid=\"%s\"\tbw=\"%f\"/>", tmp_link,
+                cluster->limiter_link);
+
+
+        memset(&link, 0, sizeof(link));
+        link.id = tmp_link;
+        link.bandwidth = cluster->loopback_bw;
+        link.latency = cluster->loopback_lat;
+        link.state = SURF_RESOURCE_ON;
+        link.policy = SURF_LINK_FATPIPE;
+        sg_platf_new_link(&link);
+        info_loop.link_up =
             xbt_lib_get_or_null(link_lib, tmp_link, SURF_LINK_LEVEL);
+        info_loop.link_down = info_loop.link_up;
         free(tmp_link);
-      } else {
-        info.link_up = xbt_lib_get_or_null(link_lib, link_id, SURF_LINK_LEVEL);
-        info.link_down = info.link_up;
+        xbt_dynar_set(current_routing->p_linkUpDownList, rankId*((AsClusterPtr)current_routing)->p_nb_links_per_node, &info_loop);
       }
 
+      //add a limiter link (shared link to account for maximal bandwidth of the node)
       if(cluster->limiter_link!=0){
         char *tmp_link = bprintf("%s_limiter", link_id);
         XBT_DEBUG("<limiter\tid=\"%s\"\tbw=\"%f\"/>", tmp_link,
@@ -926,42 +974,40 @@ static void routing_parse_cluster(sg_platf_cluster_cbarg_t cluster)
         link.state = SURF_RESOURCE_ON;
         link.policy = SURF_LINK_SHARED;
         sg_platf_new_link(&link);
-         info.limiter_link =
+        info_lim.link_up =
             xbt_lib_get_or_null(link_lib, tmp_link, SURF_LINK_LEVEL);
+        info_lim.link_down = info_lim.link_up;
         free(tmp_link);
-      }else{
-        info.limiter_link =NULL;
-      }
+        xbt_dynar_set(current_routing->p_linkUpDownList,
+            rankId*((AsClusterPtr)current_routing)->p_nb_links_per_node + ((AsClusterPtr)current_routing)->p_has_loopback ,
+            &info_lim);
 
-      if(cluster->loopback_bw!=0 || cluster->loopback_lat!=0){
-        char *tmp_link = bprintf("%s_loopback", link_id);
-        XBT_DEBUG("<loopback\tid=\"%s\"\tbw=\"%f\"/>", tmp_link,
-                cluster->limiter_link);
+      }
 
 
-        memset(&link, 0, sizeof(link));
-        link.id = tmp_link;
-        link.bandwidth = cluster->loopback_bw;
-        link.latency = cluster->loopback_lat;
-        link.state = SURF_RESOURCE_ON;
-        link.policy = SURF_LINK_FATPIPE;
-        sg_platf_new_link(&link);
-         info.loopback_link =
-            xbt_lib_get_or_null(link_lib, tmp_link, SURF_LINK_LEVEL);
-        free(tmp_link);
-      }else{
-        info.loopback_link =NULL;
+      //call the cluster function that adds the others links
+      if (cluster->topology == SURF_CLUSTER_FAT_TREE) {
+        ((AsClusterFatTree*) current_routing)->addProcessingNode(i);
+      }
+      else {
+      ((AsClusterPtr)current_routing)->create_links_for_node(cluster, i, rankId, rankId*
+          ((AsClusterPtr)current_routing)->p_nb_links_per_node
+          + ((AsClusterPtr)current_routing)->p_has_loopback
+          + ((AsClusterPtr)current_routing)->p_has_limiter );
       }
-
-      xbt_dynar_push(current_routing->p_linkUpDownList, &info);
       xbt_free(link_id);
       xbt_free(host_id);
+      rankId++;
     }
 
     xbt_dynar_free(&radical_ends);
   }
   xbt_dynar_free(&radical_elements);
-
+  
+  // For fat trees, the links must be created once all nodes have been added
+  if(cluster->topology == SURF_CLUSTER_FAT_TREE) {
+    ((AsClusterFatTree*)current_routing)->create_links(cluster);
+  }
   // Add a router. It is magically used thanks to the way in which surf_routing_cluster is written,
   // and it's very useful to connect clusters together
   XBT_DEBUG(" ");
@@ -1093,123 +1139,139 @@ static void routing_parse_peer(sg_platf_peer_cbarg_t peer)
   free(link_down);
 }
 
-static void routing_parse_Srandom(void)
+// static void routing_parse_Srandom(void)
+// {
+//   double mean, std, min, max, seed;
+//   char *random_id = A_surfxml_random_id;
+//   char *random_radical = A_surfxml_random_radical;
+//   char *rd_name = NULL;
+//   char *rd_value;
+//   mean = surf_parse_get_double(A_surfxml_random_mean);
+//   std = surf_parse_get_double(A_surfxml_random_std___deviation);
+//   min = surf_parse_get_double(A_surfxml_random_min);
+//   max = surf_parse_get_double(A_surfxml_random_max);
+//   seed = surf_parse_get_double(A_surfxml_random_seed);
+
+//   double res = 0;
+//   int i = 0;
+//   random_data_t random = xbt_new0(s_random_data_t, 1);
+//   char *tmpbuf;
+
+//   xbt_dynar_t radical_elements;
+//   unsigned int iter;
+//   char *groups;
+//   int start, end;
+//   xbt_dynar_t radical_ends;
+
+//   switch (A_surfxml_random_generator) {
+//   case AU_surfxml_random_generator:
+//   case A_surfxml_random_generator_NONE:
+//     random->generator = NONE;
+//     break;
+//   case A_surfxml_random_generator_DRAND48:
+//     random->generator = DRAND48;
+//     break;
+//   case A_surfxml_random_generator_RAND:
+//     random->generator = RAND;
+//     break;
+//   case A_surfxml_random_generator_RNGSTREAM:
+//     random->generator = RNGSTREAM;
+//     break;
+//   default:
+//     surf_parse_error("Invalid random generator");
+//     break;
+//   }
+//   random->seed = seed;
+//   random->min = min;
+//   random->max = max;
+
+//   /* Check user stupidities */
+//   if (max < min)
+//     THROWF(arg_error, 0, "random->max < random->min (%f < %f)", max, min);
+//   if (mean < min)
+//     THROWF(arg_error, 0, "random->mean < random->min (%f < %f)", mean, min);
+//   if (mean > max)
+//     THROWF(arg_error, 0, "random->mean > random->max (%f > %f)", mean, max);
+
+//   /* normalize the mean and standard deviation before storing */
+//   random->mean = (mean - min) / (max - min);
+//   random->std = std / (max - min);
+
+//   if (random->mean * (1 - random->mean) < random->std * random->std)
+//     THROWF(arg_error, 0, "Invalid mean and standard deviation (%f and %f)",
+//            random->mean, random->std);
+
+//   XBT_DEBUG
+//       ("id = '%s' min = '%f' max = '%f' mean = '%f' std_deviatinon = '%f' generator = '%d' seed = '%ld' radical = '%s'",
+//        random_id, random->min, random->max, random->mean, random->std,
+//        (int)random->generator, random->seed, random_radical);
+
+//   if (!random_value)
+//     random_value = xbt_dict_new_homogeneous(free);
+
+//   if (!strcmp(random_radical, "")) {
+//     res = random_generate(random);
+//     rd_value = bprintf("%f", res);
+//     xbt_dict_set(random_value, random_id, rd_value, NULL);
+//   } else {
+//     radical_elements = xbt_str_split(random_radical, ",");
+//     xbt_dynar_foreach(radical_elements, iter, groups) {
+//       radical_ends = xbt_str_split(groups, "-");
+//       switch (xbt_dynar_length(radical_ends)) {
+//       case 1:
+//         xbt_assert(!xbt_dict_get_or_null(random_value, random_id),
+//                    "Custom Random '%s' already exists !", random_id);
+//         res = random_generate(random);
+//         tmpbuf =
+//             bprintf("%s%d", random_id,
+//                     atoi(xbt_dynar_getfirst_as(radical_ends, char *)));
+//         xbt_dict_set(random_value, tmpbuf, bprintf("%f", res), NULL);
+//         xbt_free(tmpbuf);
+//         break;
+
+//       case 2:
+//         start = surf_parse_get_int(xbt_dynar_get_as(radical_ends, 0, char *));
+//         end = surf_parse_get_int(xbt_dynar_get_as(radical_ends, 1, char *));
+//         for (i = start; i <= end; i++) {
+//           xbt_assert(!xbt_dict_get_or_null(random_value, random_id),
+//                      "Custom Random '%s' already exists !", bprintf("%s%d",
+//                                                                     random_id,
+//                                                                     i));
+//           res = random_generate(random);
+//           tmpbuf = bprintf("%s%d", random_id, i);
+//           xbt_dict_set(random_value, tmpbuf, bprintf("%f", res), NULL);
+//           xbt_free(tmpbuf);
+//         }
+//         break;
+//       default:
+//         XBT_CRITICAL("Malformed radical");
+//         break;
+//       }
+//       res = random_generate(random);
+//       rd_name = bprintf("%s_router", random_id);
+//       rd_value = bprintf("%f", res);
+//       xbt_dict_set(random_value, rd_name, rd_value, NULL);
+
+//       xbt_dynar_free(&radical_ends);
+//     }
+//     free(rd_name);
+//     xbt_dynar_free(&radical_elements);
+//   }
+// }
+
+static void check_disk_attachment()
 {
-  double mean, std, min, max, seed;
-  char *random_id = A_surfxml_random_id;
-  char *random_radical = A_surfxml_random_radical;
-  char *rd_name = NULL;
-  char *rd_value;
-  mean = surf_parse_get_double(A_surfxml_random_mean);
-  std = surf_parse_get_double(A_surfxml_random_std___deviation);
-  min = surf_parse_get_double(A_surfxml_random_min);
-  max = surf_parse_get_double(A_surfxml_random_max);
-  seed = surf_parse_get_double(A_surfxml_random_seed);
-
-  double res = 0;
-  int i = 0;
-  random_data_t random = xbt_new0(s_random_data_t, 1);
-  char *tmpbuf;
-
-  xbt_dynar_t radical_elements;
-  unsigned int iter;
-  char *groups;
-  int start, end;
-  xbt_dynar_t radical_ends;
-
-  switch (A_surfxml_random_generator) {
-  case AU_surfxml_random_generator:
-  case A_surfxml_random_generator_NONE:
-    random->generator = NONE;
-    break;
-  case A_surfxml_random_generator_DRAND48:
-    random->generator = DRAND48;
-    break;
-  case A_surfxml_random_generator_RAND:
-    random->generator = RAND;
-    break;
-  case A_surfxml_random_generator_RNGSTREAM:
-    random->generator = RNGSTREAM;
-    break;
-  default:
-    surf_parse_error("Invalid random generator");
-    break;
-  }
-  random->seed = seed;
-  random->min = min;
-  random->max = max;
-
-  /* Check user stupidities */
-  if (max < min)
-    THROWF(arg_error, 0, "random->max < random->min (%f < %f)", max, min);
-  if (mean < min)
-    THROWF(arg_error, 0, "random->mean < random->min (%f < %f)", mean, min);
-  if (mean > max)
-    THROWF(arg_error, 0, "random->mean > random->max (%f > %f)", mean, max);
-
-  /* normalize the mean and standard deviation before storing */
-  random->mean = (mean - min) / (max - min);
-  random->std = std / (max - min);
-
-  if (random->mean * (1 - random->mean) < random->std * random->std)
-    THROWF(arg_error, 0, "Invalid mean and standard deviation (%f and %f)",
-           random->mean, random->std);
-
-  XBT_DEBUG
-      ("id = '%s' min = '%f' max = '%f' mean = '%f' std_deviatinon = '%f' generator = '%d' seed = '%ld' radical = '%s'",
-       random_id, random->min, random->max, random->mean, random->std,
-       (int)random->generator, random->seed, random_radical);
-
-  if (!random_value)
-    random_value = xbt_dict_new_homogeneous(free);
-
-  if (!strcmp(random_radical, "")) {
-    res = random_generate(random);
-    rd_value = bprintf("%f", res);
-    xbt_dict_set(random_value, random_id, rd_value, NULL);
-  } else {
-    radical_elements = xbt_str_split(random_radical, ",");
-    xbt_dynar_foreach(radical_elements, iter, groups) {
-      radical_ends = xbt_str_split(groups, "-");
-      switch (xbt_dynar_length(radical_ends)) {
-      case 1:
-        xbt_assert(!xbt_dict_get_or_null(random_value, random_id),
-                   "Custom Random '%s' already exists !", random_id);
-        res = random_generate(random);
-        tmpbuf =
-            bprintf("%s%d", random_id,
-                    atoi(xbt_dynar_getfirst_as(radical_ends, char *)));
-        xbt_dict_set(random_value, tmpbuf, bprintf("%f", res), NULL);
-        xbt_free(tmpbuf);
-        break;
-
-      case 2:
-        start = surf_parse_get_int(xbt_dynar_get_as(radical_ends, 0, char *));
-        end = surf_parse_get_int(xbt_dynar_get_as(radical_ends, 1, char *));
-        for (i = start; i <= end; i++) {
-          xbt_assert(!xbt_dict_get_or_null(random_value, random_id),
-                     "Custom Random '%s' already exists !", bprintf("%s%d",
-                                                                    random_id,
-                                                                    i));
-          res = random_generate(random);
-          tmpbuf = bprintf("%s%d", random_id, i);
-          xbt_dict_set(random_value, tmpbuf, bprintf("%f", res), NULL);
-          xbt_free(tmpbuf);
-        }
-        break;
-      default:
-        XBT_CRITICAL("Malformed radical");
-        break;
-      }
-      res = random_generate(random);
-      rd_name = bprintf("%s_router", random_id);
-      rd_value = bprintf("%f", res);
-      xbt_dict_set(random_value, rd_name, rd_value, NULL);
-
-      xbt_dynar_free(&radical_ends);
+  xbt_lib_cursor_t cursor;
+  char *key;
+  void **data;
+  RoutingEdgePtr host_elm;
+  xbt_lib_foreach(storage_lib, cursor, key, data) {
+    if(xbt_lib_get_level(xbt_lib_get_elm_or_null(storage_lib, key), SURF_STORAGE_LEVEL) != NULL) {
+         StoragePtr storage = static_cast<StoragePtr>(xbt_lib_get_level(xbt_lib_get_elm_or_null(storage_lib, key), SURF_STORAGE_LEVEL));
+         host_elm = sg_routing_edge_by_name_or_null(storage->p_attach);
+         if(!host_elm)
+                 surf_parse_error("Unable to attach storage %s: host %s doesn't exist.", storage->getName(), storage->p_attach);
     }
-    free(rd_name);
-    xbt_dynar_free(&radical_elements);
   }
 }
 
@@ -1228,6 +1290,7 @@ void routing_register_callbacks()
 
   sg_platf_peer_add_cb(routing_parse_peer);
   sg_platf_postparse_add_cb(routing_parse_postparse);
+  sg_platf_postparse_add_cb(check_disk_attachment);
 
   /* we care about the ASes while parsing the platf. Incredible, isnt it? */
   sg_platf_AS_end_add_cb(routing_AS_end);
@@ -1280,6 +1343,32 @@ const char *surf_AS_get_name(AsPtr as) {
   return as->p_name;
 }
 
+static AsPtr surf_AS_recursive_get_by_name(AsPtr current, const char * name) {
+  xbt_dict_cursor_t cursor = NULL;
+  char *key;
+  AS_t elem;
+  AsPtr tmp = NULL;
+
+  if(!strcmp(current->p_name, name))
+    return current;
+
+  xbt_dict_foreach(current->p_routingSons, cursor, key, elem) {
+    tmp = surf_AS_recursive_get_by_name(elem, name);
+    if(tmp != NULL ) {
+        break;
+    }
+  }
+  return tmp;
+}
+
+
+AsPtr surf_AS_get_by_name(const char * name) {
+  AsPtr as = surf_AS_recursive_get_by_name(routing_platf->p_root, name);
+  if(as == NULL)
+    XBT_WARN("Impossible to find an AS with name %s, please check your input", name);
+  return as;
+}
+
 xbt_dict_t surf_AS_get_routing_sons(AsPtr as) {
   return as->p_routingSons;
 }
@@ -1297,7 +1386,7 @@ xbt_dynar_t surf_AS_get_hosts(AsPtr as) {
   xbt_dynar_t res =  xbt_dynar_new(sizeof(xbt_dictelm_t), NULL);
   for (index = 0; index < count; index++) {
      relm = xbt_dynar_get_as(elms, index, RoutingEdgePtr);
-     delm = xbt_lib_get_elm_or_null(host_lib, relm->p_name);
+     delm = xbt_lib_get_elm_or_null(host_lib, relm->getName());
      if (delm!=NULL) {
        xbt_dynar_push(res, &delm);
      }