classes can actually be created on demand

[simgrid.git] / src / surf / HostImpl.hpp

diff --git a/src/surf/HostImpl.hpp b/src/surf/HostImpl.hpp
index 058140b..b02cb26 100644 (file)
--- a/src/surf/HostImpl.hpp
+++ b/src/surf/HostImpl.hpp
@@ -52,7 +52,7 @@ public:
   HostModel() : Model() {}
   ~HostModel() override {}
 
-  HostImpl *createHost(const char *name, NetCard *net, Cpu *cpu);
+  HostImpl *createHost(const char *name, kernel::routing::NetCard *net, Cpu *cpu);
 
   virtual void adjustWeightOfDummyCpuActions();
   virtual Action *executeParallelTask(int host_nb, sg_host_t *host_list,
@@ -75,13 +75,11 @@ public:
   static simgrid::xbt::Extension<simgrid::s4u::Host, HostImpl> EXTENSION_ID;
 
 public:
-  static void classInit(); // must be called before the first use of that class
   /**
    * @brief Host constructor
    *
    * @param model HostModel associated to this Host
    * @param name The name of the Host
-   * @param props Dictionary of properties associated to this Host
    * @param storage The Storage associated to this Host
    * @param cpu The Cpu associated to this Host
    */
@@ -92,7 +90,6 @@ public:
    *
    * @param model HostModel associated to this Host
    * @param name The name of the Host
-   * @param props Dictionary of properties associated to this Host
    * @param constraint The lmm constraint associated to this Host if it is part of a LMM component
    * @param storage The Storage associated to this Host
    * @param cpu The Cpu associated to this Host
@@ -102,9 +99,10 @@ public:
 
   /* Host destruction logic */
   /**************************/
-  ~HostImpl();
+  ~HostImpl() override;
 
 public:
+  // Overload the method for covariant return type:
   HostModel *getModel()
   {
     return static_cast<HostModel*>(Resource::getModel());
@@ -177,7 +175,7 @@ public:
   virtual Action *write(surf_file_t fd, sg_size_t size);
 
   /**
-   * @brief Get the informations of a file descriptor
+   * @brief Get the information of a file descriptor
    * @details The returned xbt_dynar_t contains:
    *  - the size of the file,
    *  - the mount point,
@@ -186,7 +184,7 @@ public:
    *  - the storage content type
    *
    * @param fd The file descriptor
-   * @return An xbt_dynar_t with the file informations
+   * @return An xbt_dynar_t with the file information
    */
   virtual xbt_dynar_t getInfo(surf_file_t fd);
 
@@ -230,7 +228,7 @@ public:
 public:
   xbt_dynar_t p_storage;
   Cpu *p_cpu;
-  simgrid::s4u::Host* p_host = nullptr;
+  simgrid::s4u::Host* piface = nullptr;
 
   /** @brief Get the list of virtual machines on the current Host */
   xbt_dynar_t getVms();
@@ -241,7 +239,7 @@ public:
   void getParams(vm_params_t params);
   /** @brief Sets the params of that VM/PM */
   void setParams(vm_params_t params);
-  simgrid::s4u::Host* getHost() { return p_host; }
+  simgrid::s4u::Host* getHost() { return piface; }
 private:
   s_vm_params_t p_params;
 };