Also avoid to leak the stub under windows

[simgrid.git] / src / xbt / xbt_thread.c

diff --git a/src/xbt/xbt_thread.c b/src/xbt/xbt_thread.c
index 024e50f..7936071 100644 (file)
--- a/src/xbt/xbt_thread.c
+++ b/src/xbt/xbt_thread.c
@@ -22,6 +22,8 @@
 
 typedef struct xbt_thread_ {
    pthread_t t;
+   void *param;
+   pvoid_f_pvoid_t *start_routine;
 } s_xbt_thread_t ;
 
 /* thread-specific data containing the xbt_thread_t structure */
@@ -35,7 +37,7 @@ static void xbt_thread_free_thread_data(void*d){
 void xbt_thread_mod_init(void) {
    int errcode;
    
-   if ((errcode=pthread_key_create(&xbt_self_thread_key, &xbt_thread_free_thread_data)))
+   if ((errcode=pthread_key_create(&xbt_self_thread_key, NULL)))
      THROW0(system_error,errcode,"pthread_key_create failed for xbt_self_thread_key");
 }
 void xbt_thread_mod_exit(void) {
@@ -46,23 +48,43 @@ void xbt_thread_mod_exit(void) {
 //     THROW0(system_error,errcode,"pthread_key_delete failed for xbt_self_thread_key");
 }
 
+static void * wrapper_start_routine(void *s) {
+  xbt_thread_t t = s;   
+  int errcode;
+
+  if ((errcode=pthread_setspecific(xbt_self_thread_key,t)))
+    THROW0(system_error,errcode,"pthread_setspecific failed for xbt_self_thread_key");   
+  return t->start_routine(t->param);
+}
 
 xbt_thread_t xbt_thread_create(pvoid_f_pvoid_t start_routine,
                               void* param)  {
-   xbt_thread_t res = xbt_new(s_xbt_thread_t,1);
    int errcode;
 
-   if ((errcode=pthread_setspecific(xbt_self_thread_key,res)))
-     THROW0(system_error,errcode,"pthread_setspecific failed for xbt_self_thread_key");
-      
-   if ((errcode = pthread_create(&(res->t), NULL, start_routine, param)))
-     THROW0(system_error,errcode, "pthread_create failed");
+   xbt_thread_t res_thread=xbt_new(s_xbt_thread_t,1);
+   res_thread->start_routine = start_routine;
+   res_thread->param = param;
+
    
-   return res;
+   if ((errcode = pthread_create(&(res_thread->t), NULL, wrapper_start_routine, res_thread)))
+     THROW0(system_error,errcode, "pthread_create failed");
+
+   return res_thread;
+}
+
+void 
+xbt_thread_join(xbt_thread_t thread,void ** thread_return) {
+       
+       int errcode;   
+       
+       if ((errcode = pthread_join(thread->t,thread_return)))
+               THROW0(system_error,errcode, "pthread_join failed");
 }                     
+
 void xbt_thread_exit(int *retval) {
    pthread_exit(retval);
 }
+
 xbt_thread_t xbt_thread_self(void) {
    return pthread_getspecific(xbt_self_thread_key);
 }
@@ -156,8 +178,10 @@ void xbt_thcond_destroy(xbt_thcond_t cond){
 #elif defined(WIN32)
 
 typedef struct xbt_thread_ {
-   HANDLE handle;                  /* the win thread handle        */
-   unsigned long id;               /* the win thread id            */
+  HANDLE handle;                  /* the win thread handle        */
+  unsigned long id;               /* the win thread id            */
+  pvoid_f_pvoid_t *start_routine;
+  void* param;
 } s_xbt_thread_t ;
 
 /* key to the TLS containing the xbt_thread_t structure */
@@ -167,38 +191,61 @@ void xbt_thread_mod_init(void) {
    xbt_self_thread_key = TlsAlloc();
 }
 void xbt_thread_mod_exit(void) {
-   int errcode;
-   if (!(errcode = TlsFree(xbt_self_thread_key))) 
-     THROW0(system_error,errcode,"TlsFree() failed to cleanup the thread submodule");
+   
+   if (!TlsFree(xbt_self_thread_key)) 
+     THROW0(system_error,(int)GetLastError(),"TlsFree() failed to cleanup the thread submodule");
 }
 
+static DWORD WINAPI  wrapper_start_routine(void *s) {
+  xbt_thread_t t = (xbt_thread_t)s;
+ 
+    if(!TlsSetValue(xbt_self_thread_key,t))
+     THROW0(system_error,(int)GetLastError(),"TlsSetValue of data describing the created thread failed");
+   
+   return (DWORD)t->start_routine(t->param);
+}
+
+
 xbt_thread_t xbt_thread_create(pvoid_f_pvoid_t start_routine,
                               void* param)  {
    
-   xbt_thread_t res = xbt_new(s_xbt_thread_t,1);
+   xbt_thread_t t = xbt_new(s_xbt_thread_t,1);
+
+   t->start_routine = start_routine ;
+   t->param = param;
    
-   res->handle = CreateThread(NULL,0, 
-                             (LPTHREAD_START_ROUTINE)start_routine,
-                             param,0,& res->id);
+   t->handle = CreateThread(NULL,0,
+                           (LPTHREAD_START_ROUTINE)wrapper_start_routine,
+                           t,0,&(t->id));
        
-   if(!res->handle) {
-     xbt_free(res);
-     THROW0(system_error,0,"CreateThread failed");
+   if(!t->handle) {
+     xbt_free(t);
+     THROW0(system_error,(int)GetLastError(),"CreateThread failed");
    }
    
-   if(!TlsSetValue(xbt_self_thread_key,res))
-     THROW0(system_error,0,"TlsSetValue of data describing the created thread failed");
-     
-   return res;
+   return t;
+}
+
+void 
+xbt_thread_join(xbt_thread_t thread,void ** thread_return) {
+
+       if(WAIT_OBJECT_0 != WaitForSingleObject(thread->handle,INFINITE))  
+               THROW0(system_error,(int)GetLastError(), "WaitForSingleObject failed");
+               
+       if(thread_return){
+               
+               if(!GetExitCodeThread(thread->handle,(DWORD*)(*thread_return)))
+                       THROW0(system_error,(int)GetLastError(), "GetExitCodeThread failed");
+       }
+       
+       CloseHandle(thread->handle);
 }
 
 void xbt_thread_exit(int *retval) {
-   xbt_thread_t self = xbt_thread_self();
-   
-   CloseHandle(self->handle);
-   free(self);
-   
-   ExitThread(*retval);
+   if(retval)
+       ExitThread(*retval);
+   else
+       ExitThread(0);
 }
 
 xbt_thread_t xbt_thread_self(void) {