Avoid looping over single, constant value (codefactor.io/ShellCheck).

[simgrid.git] / tools / jenkins / Flags.sh

diff --git a/tools/jenkins/Flags.sh b/tools/jenkins/Flags.sh
index 40d12df..44ffae8 100755 (executable)
--- a/tools/jenkins/Flags.sh
+++ b/tools/jenkins/Flags.sh
@@ -2,29 +2,11 @@
 
 set -e
 
 
 set -e
 

-if [ $# -lt 4 ]
-  then
-    echo "Needs 4 arguments : JAVA MC SMPI DEBUG"
-    exit -1
-fi
-
-
-

 die() {
     echo "$@"
     exit 1
 }
 
 die() {
     echo "$@"
     exit 1
 }
 

-do_cleanup() {
-  for d in "$WORKSPACE/build"
-  do
-    if [ -d "$d" ]
-    then
-      rm -rf "$d" || die "Could not remote $d"
-    fi
-  done
-}
-

 # Get an ON/OFF string from a command:
 onoff() {
   if "$@" > /dev/null ; then
 # Get an ON/OFF string from a command:
 onoff() {
   if "$@" > /dev/null ; then


@@ -34,17 +16,25 @@ onoff() {
   fi
 }
 
   fi
 }
 

+[ $# -eq 4 ] || die "Needs 4 arguments : JAVA MC SMPI DEBUG"
+

 ### Cleanup previous runs
 
 ! [ -z "$WORKSPACE" ] || die "No WORKSPACE"
 [ -d "$WORKSPACE" ] || die "WORKSPACE ($WORKSPACE) does not exist"
 
 ### Cleanup previous runs
 
 ! [ -z "$WORKSPACE" ] || die "No WORKSPACE"
 [ -d "$WORKSPACE" ] || die "WORKSPACE ($WORKSPACE) does not exist"
 

-do_cleanup
+do_cleanup() {
+  for d
+  do
+    if [ -d "$d" ]
+    then
+      rm -rf "$d" || die "Could not remove $d"
+    fi
+    mkdir "$d" || die "Could not create $d"
+  done
+}

 
 

-for d in "$WORKSPACE/build"
-do
-  mkdir "$d" || die "Could not create $d"
-done
+do_cleanup "$WORKSPACE/build"

 
 NUMPROC="$(nproc)" || NUMPROC=1
 
 
 NUMPROC="$(nproc)" || NUMPROC=1