What ActivityImpl child should look like IMHO

[simgrid.git] / src / kernel / activity / ActivityImpl.hpp

diff --git a/src/kernel/activity/ActivityImpl.hpp b/src/kernel/activity/ActivityImpl.hpp
index 6d14c86..58e146c 100644 (file)
--- a/src/kernel/activity/ActivityImpl.hpp
+++ b/src/kernel/activity/ActivityImpl.hpp
@@ -23,7 +23,7 @@ namespace activity {
 class XBT_PUBLIC ActivityImpl {
 public:
   ActivityImpl() = default;
-  explicit ActivityImpl(std::string name) : name_(std::move(name)) {}
+  explicit ActivityImpl(const std::string& name) : name_(name) {}
   virtual ~ActivityImpl() = default;
   e_smx_state_t state_ = SIMIX_WAITING; /* State of the activity */
   std::list<smx_simcall_t> simcalls_;   /* List of simcalls waiting for this activity */
@@ -31,12 +31,13 @@ public:
 
   const std::string& get_name() const { return name_; }
   const char* get_cname() const { return name_.c_str(); }
+  void set_name(const std::string& name) { name_ = name; }
 
   virtual void suspend();
   virtual void resume();
-  virtual void post()    = 0; // What to do when a simcall terminates
-
-  void set_category(std::string category);
+  virtual void post()   = 0; // What to do when a simcall terminates
+  virtual void finish() = 0;
+  void set_category(const std::string& category);
 
   // boost::intrusive_ptr<ActivityImpl> support:
   friend XBT_PUBLIC void intrusive_ptr_add_ref(ActivityImpl* activity);
@@ -47,9 +48,11 @@ private:
   std::string name_;                    /* Activity name if any */
 
 public:
-  static simgrid::xbt::signal<void(ActivityImplPtr)> on_suspended;
-  static simgrid::xbt::signal<void(ActivityImplPtr)> on_resumed;
+  static xbt::signal<void(ActivityImplPtr)> on_suspended;
+  static xbt::signal<void(ActivityImplPtr)> on_resumed;
 };
-}}} // namespace simgrid::kernel::activity
+} // namespace activity
+} // namespace kernel
+} // namespace simgrid
 
 #endif /* SIMGRID_KERNEL_ACTIVITY_ACTIVITYIMPL_HPP */