Avoid looping over single, constant value (codefactor.io/ShellCheck).

[simgrid.git] / tools / jenkins / Flags.sh

diff --git a/tools/jenkins/Flags.sh b/tools/jenkins/Flags.sh
index 100cc16..44ffae8 100755 (executable)
--- a/tools/jenkins/Flags.sh
+++ b/tools/jenkins/Flags.sh
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/usr/bin/env sh

 
 set -e
 
 
 set -e
 


@@ -7,16 +7,6 @@ die() {
     exit 1
 }
 
     exit 1
 }
 

-do_cleanup() {
-  for d in "$WORKSPACE/build"
-  do
-    if [ -d "$d" ]
-    then
-      rm -rf "$d" || die "Could not remote $d"
-    fi
-  done
-}
-

 # Get an ON/OFF string from a command:
 onoff() {
   if "$@" > /dev/null ; then
 # Get an ON/OFF string from a command:
 onoff() {
   if "$@" > /dev/null ; then


@@ -26,41 +16,70 @@ onoff() {
   fi
 }
 
   fi
 }
 

-### Cleanup previous runs
+[ $# -eq 4 ] || die "Needs 4 arguments : JAVA MC SMPI DEBUG"
+
+### Cleanup previous runs

 
 ! [ -z "$WORKSPACE" ] || die "No WORKSPACE"
 [ -d "$WORKSPACE" ] || die "WORKSPACE ($WORKSPACE) does not exist"
 
 
 ! [ -z "$WORKSPACE" ] || die "No WORKSPACE"
 [ -d "$WORKSPACE" ] || die "WORKSPACE ($WORKSPACE) does not exist"
 

-do_cleanup
+do_cleanup() {
+  for d
+  do
+    if [ -d "$d" ]
+    then
+      rm -rf "$d" || die "Could not remove $d"
+    fi
+    mkdir "$d" || die "Could not create $d"
+  done
+}

 
 

-for d in "$WORKSPACE/build"
-do
-  mkdir "$d" || die "Could not create $d"
-done
+do_cleanup "$WORKSPACE/build"

 
 NUMPROC="$(nproc)" || NUMPROC=1
 
 cd $WORKSPACE/build
 
 
 NUMPROC="$(nproc)" || NUMPROC=1
 
 cd $WORKSPACE/build
 

-for buildjava in ON OFF
-do
-  for builddebug in ON OFF
-  do
-    for buildsmpi in ON OFF
-    do
-      for buildmc in ON OFF
-      do
-        echo "build with java=${buildjava}, debug=${builddebug}, SMPI=${buildsmpi}, MC=${buildmc}"
-        cmake -Denable_documentation=OFF -Denable_lua=ON -Denable_java=${buildjava} \
-              -Denable_compile_optimizations=OFF -Denable_compile_warnings=ON \
-              -Denable_jedule=ON -Denable_mallocators=ON -Denable_debug=${builddebug} \
-              -Denable_smpi=${buildsmpi} -Denable_smpi_MPICH3_testsuite=${buildsmpi} -Denable_model-checking=${buildmc} \
-              -Denable_memcheck=OFF -Denable_memcheck_xml=OFF -Denable_smpi_ISP_testsuite=OFF \
-              -Denable_ns3=$(onoff test "$buildmc" != "ON") -Denable_coverage=OFF $WORKSPACE
-        make -j$NUMPROC
-        make clean
-      done
-    done
-  done
-done 
+#we can't just receive ON or OFF as values as display is bad in the resulting jenkins matrix
+
+if [ $1 = "JAVA" ]
+then
+  buildjava="ON"
+else
+  buildjava="OFF"
+fi
+
+if [ $2 = "MC" ]
+then
+  buildmc="ON"
+else
+  buildmc="OFF"
+fi
+
+if [ $3 = "SMPI" ]
+then
+  buildsmpi="ON"
+else
+  buildsmpi="OFF"
+fi
+
+if [ $4 = "DEBUG" ]
+then
+  builddebug="ON"
+else
+  builddebug="OFF"
+fi
+
+
+echo "Step ${STEP}/${NSTEPS} - Building with java=${buildjava}, debug=${builddebug}, SMPI=${buildsmpi}, MC=${buildmc}"
+cmake -Denable_documentation=OFF -Denable_lua=ON -Denable_java=${buildjava} \
+      -Denable_compile_optimizations=OFF -Denable_compile_warnings=ON \
+      -Denable_jedule=ON -Denable_mallocators=ON -Denable_debug=${builddebug} \
+      -Denable_smpi=${buildsmpi} -Denable_smpi_MPICH3_testsuite=${buildsmpi} -Denable_model-checking=${buildmc} \
+      -Denable_memcheck=OFF -Denable_memcheck_xml=OFF -Denable_smpi_ISP_testsuite=OFF \
+      -Denable_ns3=$(onoff test "$buildmc" != "ON") -Denable_coverage=OFF $WORKSPACE
+
+make -j$NUMPROC tests
+make clean
+