#include <xbt/backtrace.hpp>
#include "xbt/ex.h"
#include "xbt/log.h"
-#include "xbt/str.h"
#include "xbt/module.h" /* xbt_binary_name */
#include "src/xbt_modinter.h" /* backtrace initialization headers */
-#if HAVE_MC
+#if SIMGRID_HAVE_MC
#define UNW_LOCAL_ONLY
#include <libunwind.h>
#endif
#include <unwind.h>
struct trace_arg {
- void **array;
- int cnt, size;
+ void** array;
+ int cnt;
+ int size;
};
static _Unwind_Reason_Code
std::vector<std::string> addrs(count);
for (std::size_t i = 0; i < count; i++) {
/* retrieve this address */
- XBT_DEBUG("Retrieving address number %zd from '%s'", i, backtrace_syms[i]);
+ XBT_DEBUG("Retrieving address number %zu from '%s'", i, backtrace_syms[i]);
char buff[256];
snprintf(buff, 256, "%s", strchr(backtrace_syms[i], '[') + 1);
char* p = strchr(buff, ']');
addrs[i] = buff;
else
addrs[i] = "0x0";
- XBT_DEBUG("Set up a new address: %zd, '%s'", i, addrs[i].c_str());
+ XBT_DEBUG("Set up a new address: %zu, '%s'", i, addrs[i].c_str());
/* Add it to the command line args */
stream << addrs[i] << ' ';
}
XBT_VERB("Fire a first command: '%s'", cmd.c_str());
FILE* pipe = popen(cmd.c_str(), "r");
- if (!pipe) {
+ if (not pipe) {
xbt_die("Cannot fork addr2line to display the backtrace");
}
/* To read the output of addr2line */
- char line_func[1024], line_pos[1024];
+ char line_func[1024];
+ char line_pos[1024];
for (std::size_t i = 0; i < count; i++) {
- XBT_DEBUG("Looking for symbol %zd, addr = '%s'", i, addrs[i].c_str());
+ XBT_DEBUG("Looking for symbol %zu, addr = '%s'", i, addrs[i].c_str());
if (fgets(line_func, 1024, pipe)) {
line_func[strlen(line_func) - 1] = '\0';
} else {
- XBT_VERB("Cannot run fgets to look for symbol %zd, addr %s", i, addrs[i].c_str());
+ XBT_VERB("Cannot run fgets to look for symbol %zu, addr %s", i, addrs[i].c_str());
strncpy(line_func, "???",3);
}
if (fgets(line_pos, 1024, pipe)) {
line_pos[strlen(line_pos) - 1] = '\0';
} else {
- XBT_VERB("Cannot run fgets to look for symbol %zd, addr %s", i, addrs[i].c_str());
+ XBT_VERB("Cannot run fgets to look for symbol %zu, addr %s", i, addrs[i].c_str());
strncpy(line_pos, backtrace_syms[i],1024);
}
/* Damn. The symbol is in a dynamic library. Let's get wild */
char maps_buff[512];
- long int offset = 0;
- char *p, *p2;
+ unsigned long int offset = 0;
+ char* p;
int found = 0;
/* let's look for the offset of this library in our addressing space */
- char* maps_name = bprintf("/proc/%d/maps", (int) getpid());
- FILE* maps = fopen(maps_name, "r");
+ std::string maps_name = std::string("/proc/") + std::to_string(getpid()) + "maps";
+ FILE* maps = fopen(maps_name.c_str(), "r");
- long int addr = strtol(addrs[i].c_str(), &p, 16);
+ unsigned long int addr = strtoul(addrs[i].c_str(), &p, 16);
if (*p != '\0') {
- XBT_CRITICAL("Cannot parse backtrace address '%s' (addr=%#lx)",
- addrs[i].c_str(), addr);
+ XBT_CRITICAL("Cannot parse backtrace address '%s' (addr=%#lx)", addrs[i].c_str(), addr);
}
- XBT_DEBUG("addr=%s (as string) =%#lx (as number)",
- addrs[i].c_str(), addr);
+ XBT_DEBUG("addr=%s (as string) =%#lx (as number)", addrs[i].c_str(), addr);
- while (!found) {
- long int first, last;
+ while (not found) {
+ unsigned long int first;
+ unsigned long int last;
if (fgets(maps_buff, 512, maps) == nullptr)
break;
}
}
fclose(maps);
- free(maps_name);
addrs[i].clear();
- if (!found) {
+ if (not found) {
XBT_VERB("Problem while reading the maps file. Following backtrace will be mangled.");
XBT_DEBUG("No dynamic. Static symbol: %s", backtrace_syms[i]);
result.push_back(simgrid::xbt::string_printf("?? (%s)", backtrace_syms[i]));
free(p);
snprintf(line_func,3, "??");
} else {
- p2 = strrchr(p, '(');
+ char* p2 = strrchr(p, '(');
if (p2)
*p2 = '\0';
p2 = strrchr(p, ' ');
*p2 = '\0';
/* Here we go, fire an addr2line up */
- char* subcmd = bprintf("%s -f -e %s %s", ADDR2LINE, p, addrs[i].c_str());
+ std::string subcmd = std::string(ADDR2LINE) + " -f -e " + p + " " + addrs[i];
free(p);
- XBT_VERB("Fire a new command: '%s'", subcmd);
- FILE* subpipe = popen(subcmd, "r");
- if (!subpipe) {
+ XBT_VERB("Fire a new command: '%s'", subcmd.c_str());
+ FILE* subpipe = popen(subcmd.c_str(), "r");
+ if (not subpipe) {
xbt_die("Cannot fork addr2line to display the backtrace");
}
if (fgets(line_func, 1024, subpipe)) {
line_func[strlen(line_func) - 1] = '\0';
} else {
- XBT_VERB("Cannot read result of subcommand %s", subcmd);
+ XBT_VERB("Cannot read result of subcommand %s", subcmd.c_str());
strncpy(line_func, "???",3);
}
if (fgets(line_pos, 1024, subpipe)) {
line_pos[strlen(line_pos) - 1] = '\0';
} else {
- XBT_VERB("Cannot read result of subcommand %s", subcmd);
+ XBT_VERB("Cannot read result of subcommand %s", subcmd.c_str());
strncpy(line_pos, backtrace_syms[i],1024);
}
pclose(subpipe);
- free(subcmd);
}
/* check whether the trick worked */
addrs[i].clear();
/* Mask the bottom of the stack */
- if (!strncmp("main", line_func, strlen("main")) ||
- !strncmp("xbt_thread_context_wrapper", line_func, strlen("xbt_thread_context_wrapper"))
- || !strncmp("smx_ctx_sysv_wrapper", line_func, strlen("smx_ctx_sysv_wrapper")))
+ if (not strncmp("main", line_func, strlen("main")) ||
+ not strncmp("xbt_thread_context_wrapper", line_func, strlen("xbt_thread_context_wrapper")) ||
+ not strncmp("smx_ctx_sysv_wrapper", line_func, strlen("smx_ctx_sysv_wrapper")))
break;
}
pclose(pipe);
}
}
-#if HAVE_MC
+#if SIMGRID_HAVE_MC
int xbt_libunwind_backtrace(void** bt, int size){
for (int i = 0; i < size; i++)
bt[i] = nullptr;
