-/* Copyright (c) 2013-2015. The SimGrid Team.
- * All rights reserved. */
+/* Copyright (c) 2013-2017. The SimGrid Team. All rights reserved. */
/* This program is free software; you can redistribute it and/or modify it
* under the terms of the license (GNU LGPL) which comes with this package. */
#include <algorithm>
-#include "network_cm02.hpp"
#include "maxmin_private.hpp"
+#include "network_cm02.hpp"
+#include "simgrid/s4u/Host.hpp"
#include "simgrid/sg_config.h"
#include "src/instr/instr_private.h" // TRACE_is_enabled(). FIXME: remove by subscribing tracing to the surf signals
XBT_LOG_EXTERNAL_DEFAULT_CATEGORY(surf_network);
-double sg_sender_gap = 0.0;
double sg_latency_factor = 1.0; /* default value; can be set by model or from command line */
double sg_bandwidth_factor = 1.0; /* default value; can be set by model or from command line */
double sg_weight_S_parameter = 0.0; /* default value; can be set by model or from command line */
/* month = Nov, */
/* pdf = {http://hal.inria.fr/hal-00646896/PDF/rr-validity.pdf}, */
/* } */
-void surf_network_model_init_LegrandVelho(void)
+void surf_network_model_init_LegrandVelho()
{
if (surf_network_model)
return;
surf_network_model = new simgrid::surf::NetworkCm02Model();
- xbt_dynar_push(all_existing_models, &surf_network_model);
+ all_existing_models->push_back(surf_network_model);
xbt_cfg_setdefault_double("network/latency-factor", 13.01);
xbt_cfg_setdefault_double("network/bandwidth-factor", 0.97);
/* month = {oct}, */
/* year = {2002} */
/* } */
-void surf_network_model_init_CM02(void)
+void surf_network_model_init_CM02()
{
if (surf_network_model)
return;
- surf_network_model = new simgrid::surf::NetworkCm02Model();
- xbt_dynar_push(all_existing_models, &surf_network_model);
-
xbt_cfg_setdefault_double("network/latency-factor", 1.0);
xbt_cfg_setdefault_double("network/bandwidth-factor", 1.0);
xbt_cfg_setdefault_double("network/weight-S", 0.0);
+
+ surf_network_model = new simgrid::surf::NetworkCm02Model();
+ all_existing_models->push_back(surf_network_model);
}
/***************************************************************************/
/* journal={{IEEE/ACM} Transactions on Networking}, */
/* volume={11}, number={4}, */
/* } */
-void surf_network_model_init_Reno(void)
+void surf_network_model_init_Reno()
{
if (surf_network_model)
return;
- surf_network_model = new simgrid::surf::NetworkCm02Model();
- xbt_dynar_push(all_existing_models, &surf_network_model);
-
lmm_set_default_protocol_function(func_reno_f, func_reno_fp, func_reno_fpi);
- surf_network_model->f_networkSolve = lagrange_solve;
- xbt_cfg_setdefault_double("network/latency-factor", 10.4);
- xbt_cfg_setdefault_double("network/bandwidth-factor", 0.92);
- xbt_cfg_setdefault_double("network/weight-S", 8775);
+ xbt_cfg_setdefault_double("network/latency-factor", 13.01);
+ xbt_cfg_setdefault_double("network/bandwidth-factor", 0.97);
+ xbt_cfg_setdefault_double("network/weight-S", 20537);
+
+ surf_network_model = new simgrid::surf::NetworkCm02Model(&lagrange_solve);
+ all_existing_models->push_back(surf_network_model);
}
-void surf_network_model_init_Reno2(void)
+void surf_network_model_init_Reno2()
{
if (surf_network_model)
return;
- surf_network_model = new simgrid::surf::NetworkCm02Model();
- xbt_dynar_push(all_existing_models, &surf_network_model);
-
lmm_set_default_protocol_function(func_reno2_f, func_reno2_fp, func_reno2_fpi);
- surf_network_model->f_networkSolve = lagrange_solve;
- xbt_cfg_setdefault_double("network/latency-factor", 10.4);
- xbt_cfg_setdefault_double("network/bandwidth-factor", 0.92);
- xbt_cfg_setdefault_double("network/weight-S", 8775);
+ xbt_cfg_setdefault_double("network/latency-factor", 13.01);
+ xbt_cfg_setdefault_double("network/bandwidth-factor", 0.97);
+ xbt_cfg_setdefault_double("network/weight-S", 20537);
+
+ surf_network_model = new simgrid::surf::NetworkCm02Model(&lagrange_solve);
+ all_existing_models->push_back(surf_network_model);
}
-void surf_network_model_init_Vegas(void)
+void surf_network_model_init_Vegas()
{
if (surf_network_model)
return;
- surf_network_model = new simgrid::surf::NetworkCm02Model();
- xbt_dynar_push(all_existing_models, &surf_network_model);
-
lmm_set_default_protocol_function(func_vegas_f, func_vegas_fp, func_vegas_fpi);
- surf_network_model->f_networkSolve = lagrange_solve;
- xbt_cfg_setdefault_double("network/latency-factor", 10.4);
- xbt_cfg_setdefault_double("network/bandwidth-factor", 0.92);
- xbt_cfg_setdefault_double("network/weight-S", 8775);
+ xbt_cfg_setdefault_double("network/latency-factor", 13.01);
+ xbt_cfg_setdefault_double("network/bandwidth-factor", 0.97);
+ xbt_cfg_setdefault_double("network/weight-S", 20537);
+
+ surf_network_model = new simgrid::surf::NetworkCm02Model(&lagrange_solve);
+ all_existing_models->push_back(surf_network_model);
}
namespace simgrid {
:NetworkModel()
{
char *optim = xbt_cfg_get_string("network/optim");
- int select = xbt_cfg_get_boolean("network/maxmin-selective-update");
+ bool select = xbt_cfg_get_boolean("network/maxmin-selective-update");
- if (!strcmp(optim, "Full")) {
+ if (not strcmp(optim, "Full")) {
updateMechanism_ = UM_FULL;
selectiveUpdate_ = select;
- } else if (!strcmp(optim, "Lazy")) {
+ } else if (not strcmp(optim, "Lazy")) {
updateMechanism_ = UM_LAZY;
- selectiveUpdate_ = 1;
- xbt_assert((select == 1) || (xbt_cfg_is_default_value("network/maxmin-selective-update")),
- "Disabling selective update while using the lazy update mechanism is dumb!");
+ selectiveUpdate_ = true;
+ xbt_assert(select || (xbt_cfg_is_default_value("network/maxmin-selective-update")),
+ "You cannot disable selective update when using the lazy update mechanism");
} else {
- xbt_die("Unsupported optimization (%s) for this model", optim);
+ xbt_die("Unsupported optimization (%s) for this model. Accepted: Full, Lazy.", optim);
}
- if (!maxminSystem_)
- maxminSystem_ = lmm_system_new(selectiveUpdate_);
-
- routing_model_create(createLink("__loopback__", 498000000, 0.000015, SURF_LINK_FATPIPE, NULL));
+ maxminSystem_ = lmm_system_new(selectiveUpdate_);
+ loopback_ = createLink("__loopback__", 498000000, 0.000015, SURF_LINK_FATPIPE);
if (updateMechanism_ == UM_LAZY) {
- actionHeap_ = xbt_heap_new(8, NULL);
- xbt_heap_set_update_callback(actionHeap_, surf_action_lmm_update_index_heap);
- modifiedSet_ = new ActionLmmList();
- maxminSystem_->keep_track = modifiedSet_;
+ actionHeap_ = xbt_heap_new(8, nullptr);
+ xbt_heap_set_update_callback(actionHeap_, surf_action_lmm_update_index_heap);
+ modifiedSet_ = new ActionLmmList();
+ maxminSystem_->keep_track = modifiedSet_;
}
}
+NetworkCm02Model::NetworkCm02Model(void (*specificSolveFun)(lmm_system_t self))
+ : NetworkCm02Model()
+{
+ maxminSystem_->solve_fun = specificSolveFun;
+}
-NetworkCm02Model::~NetworkCm02Model() {}
-
-Link* NetworkCm02Model::createLink(const char *name, double bandwidth, double latency, e_surf_link_sharing_policy_t policy,
- xbt_dict_t properties)
+LinkImpl* NetworkCm02Model::createLink(const std::string& name, double bandwidth, double latency,
+ e_surf_link_sharing_policy_t policy)
{
- return new NetworkCm02Link(this, name, properties, bandwidth, latency, policy, maxminSystem_);
+ return new NetworkCm02Link(this, name, bandwidth, latency, policy, maxminSystem_);
}
void NetworkCm02Model::updateActionsStateLazy(double now, double /*delta*/)
{
- NetworkCm02Action *action;
while ((xbt_heap_size(actionHeap_) > 0)
&& (double_equals(xbt_heap_maxkey(actionHeap_), now, sg_surf_precision))) {
- action = static_cast<NetworkCm02Action*> (xbt_heap_pop(actionHeap_));
+
+ NetworkCm02Action *action = static_cast<NetworkCm02Action*> (xbt_heap_pop(actionHeap_));
XBT_DEBUG("Something happened to action %p", action);
if (TRACE_is_enabled()) {
int n = lmm_get_number_of_cnst_from_var(maxminSystem_, action->getVariable());
for (int i = 0; i < n; i++){
lmm_constraint_t constraint = lmm_get_cnst_from_var(maxminSystem_, action->getVariable(), i);
NetworkCm02Link *link = static_cast<NetworkCm02Link*>(lmm_constraint_id(constraint));
- TRACE_surf_link_set_utilization(link->getName(),
- action->getCategory(),
- (lmm_variable_getvalue(action->getVariable())*
- lmm_get_cnst_weight_from_var(maxminSystem_,
- action->getVariable(),
- i)),
- action->getLastUpdate(),
+ double value = lmm_variable_getvalue(action->getVariable())*
+ lmm_get_cnst_weight_from_var(maxminSystem_, action->getVariable(), i);
+ TRACE_surf_link_set_utilization(link->cname(), action->getCategory(), value, action->getLastUpdate(),
now - action->getLastUpdate());
}
}
action->refreshLastUpdate();
// if I am wearing a max_duration or normal hat
- } else if (action->getHat() == MAX_DURATION ||
- action->getHat() == NORMAL) {
+ } else if (action->getHat() == MAX_DURATION || action->getHat() == NORMAL) {
// no need to communicate anymore
// assume that flows that reached max_duration have remaining of 0
XBT_DEBUG("Action %p finished", action);
action->setRemains(0);
- action->finish();
- action->setState(Action::State::done);
+ action->finish(Action::State::done);
action->heapRemove(actionHeap_);
-
- action->gapRemove();
}
}
- return;
}
void NetworkCm02Model::updateActionsStateFull(double now, double delta)
{
- NetworkCm02Action *action;
ActionList *running_actions = getRunningActionSet();
for(ActionList::iterator it(running_actions->begin()), itNext=it, itend(running_actions->end())
; it != itend ; it=itNext) {
- ++itNext;
+ ++itNext;
- action = static_cast<NetworkCm02Action*> (&*it);
+ NetworkCm02Action *action = static_cast<NetworkCm02Action*> (&*it);
XBT_DEBUG("Something happened to action %p", action);
double deltap = delta;
if (action->latency_ > 0) {
double_update(&(deltap), action->latency_, sg_surf_precision);
action->latency_ = 0.0;
}
- if (action->latency_ == 0.0 && !(action->isSuspended()))
- lmm_update_variable_weight(maxminSystem_, action->getVariable(),
- action->weight_);
+ if (action->latency_ <= 0.0 && not action->isSuspended())
+ lmm_update_variable_weight(maxminSystem_, action->getVariable(), action->weight_);
}
if (TRACE_is_enabled()) {
int n = lmm_get_number_of_cnst_from_var(maxminSystem_, action->getVariable());
lmm_constraint_t constraint = lmm_get_cnst_from_var(maxminSystem_, action->getVariable(), i);
NetworkCm02Link* link = static_cast<NetworkCm02Link*>(lmm_constraint_id(constraint));
- TRACE_surf_link_set_utilization(link->getName(),
- action->getCategory(),
- (lmm_variable_getvalue(action->getVariable())*
- lmm_get_cnst_weight_from_var(maxminSystem_,
- action->getVariable(),
- i)),
- action->getLastUpdate(),
- now - action->getLastUpdate());
+ TRACE_surf_link_set_utilization(link->cname(), action->getCategory(),
+ (lmm_variable_getvalue(action->getVariable()) *
+ lmm_get_cnst_weight_from_var(maxminSystem_, action->getVariable(), i)),
+ action->getLastUpdate(), now - action->getLastUpdate());
}
}
- if (!lmm_get_number_of_cnst_from_var (maxminSystem_, action->getVariable())) {
- /* There is actually no link used, hence an infinite bandwidth.
- * This happens often when using models like vivaldi.
- * In such case, just make sure that the action completes immediately.
+ if (not lmm_get_number_of_cnst_from_var(maxminSystem_, action->getVariable())) {
+ /* There is actually no link used, hence an infinite bandwidth. This happens often when using models like
+ * vivaldi. In such case, just make sure that the action completes immediately.
*/
action->updateRemains(action->getRemains());
}
action->updateRemains(lmm_variable_getvalue(action->getVariable()) * delta);
-
- if (action->getMaxDuration() != NO_MAX_DURATION)
+
+ if (action->getMaxDuration() > NO_MAX_DURATION)
action->updateMaxDuration(delta);
-
- if ((action->getRemains() <= 0) &&
- (lmm_get_variable_weight(action->getVariable()) > 0)) {
- action->finish();
- action->setState(Action::State::done);
- action->gapRemove();
- } else if (((action->getMaxDuration() != NO_MAX_DURATION)
- && (action->getMaxDuration() <= 0))) {
- action->finish();
- action->setState(Action::State::done);
- action->gapRemove();
+
+ if (((action->getRemains() <= 0) && (lmm_get_variable_weight(action->getVariable()) > 0)) ||
+ ((action->getMaxDuration() > NO_MAX_DURATION) && (action->getMaxDuration() <= 0))) {
+ action->finish(Action::State::done);
}
}
}
-Action *NetworkCm02Model::communicate(NetCard *src, NetCard *dst, double size, double rate)
+Action* NetworkCm02Model::communicate(s4u::Host* src, s4u::Host* dst, double size, double rate)
{
int failed = 0;
- double bandwidth_bound;
double latency = 0.0;
- std::vector<Link*> * back_route = NULL;
- int constraints_per_variable = 0;
+ std::vector<LinkImpl*>* back_route = nullptr;
+ std::vector<LinkImpl*>* route = new std::vector<LinkImpl*>();
- std::vector<Link*> *route = new std::vector<Link*>();
+ XBT_IN("(%s,%s,%g,%g)", src->getCname(), dst->getCname(), size, rate);
- XBT_IN("(%s,%s,%g,%g)", src->name(), dst->name(), size, rate);
-
- routing_platf->getRouteAndLatency(src, dst, route, &latency);
- xbt_assert(! route->empty() || latency,
+ src->routeTo(dst, route, &latency);
+ xbt_assert(not route->empty() || latency,
"You're trying to send data from %s to %s but there is no connecting path between these two hosts.",
- src->name(), dst->name());
+ src->getCname(), dst->getCname());
- for (auto link: *route)
+ for (auto const& link : *route)
if (link->isOff())
failed = 1;
if (sg_network_crosstraffic == 1) {
- back_route = new std::vector<Link*>();
- routing_platf->getRouteAndLatency(dst, src, back_route, NULL);
- for (auto link: *back_route)
+ back_route = new std::vector<LinkImpl*>();
+ dst->routeTo(src, back_route, nullptr);
+ for (auto const& link : *back_route)
if (link->isOff())
failed = 1;
}
NetworkCm02Action *action = new NetworkCm02Action(this, size, failed);
- action->weight_ = action->latency_ = latency;
-
+ action->weight_ = latency;
+ action->latency_ = latency;
action->rate_ = rate;
if (updateMechanism_ == UM_LAZY) {
action->indexHeap_ = -1;
action->lastUpdate_ = surf_get_clock();
}
- bandwidth_bound = -1.0;
+ double bandwidth_bound = -1.0;
if (sg_weight_S_parameter > 0)
- for (auto link : *route)
- action->weight_ += sg_weight_S_parameter / link->getBandwidth();
+ for (auto const& link : *route)
+ action->weight_ += sg_weight_S_parameter / link->bandwidth();
- for (auto link : *route) {
- double bb = bandwidthFactor(size) * link->getBandwidth();
+ for (auto const& link : *route) {
+ double bb = bandwidthFactor(size) * link->bandwidth();
bandwidth_bound = (bandwidth_bound < 0.0) ? bb : std::min(bandwidth_bound, bb);
}
action->latCurrent_ = action->latency_;
action->latency_ *= latencyFactor(size);
action->rate_ = bandwidthConstraint(action->rate_, bandwidth_bound, size);
- if (haveGap_) {
- xbt_assert(! route->empty(),
- "Using a model with a gap (e.g., SMPI) with a platform without links (e.g. vivaldi)!!!");
-
- gapAppend(size, route->at(0), action);
- XBT_DEBUG("Comm %p: %s -> %s gap=%f (lat=%f)", action, src->name(), dst->name(), action->senderGap_, action->latency_);
- }
- constraints_per_variable = route->size();
- if (back_route != NULL)
+ int constraints_per_variable = route->size();
+ if (back_route != nullptr)
constraints_per_variable += back_route->size();
if (action->latency_ > 0) {
lmm_update_variable_bound(maxminSystem_, action->getVariable(), (action->latCurrent_ > 0) ? std::min(action->rate_, sg_tcp_gamma / (2.0 * action->latCurrent_)) : action->rate_);
}
- for (auto link: *route)
- lmm_expand(maxminSystem_, link->getConstraint(), action->getVariable(), 1.0);
+ for (auto const& link : *route)
+ lmm_expand(maxminSystem_, link->constraint(), action->getVariable(), 1.0);
- if (sg_network_crosstraffic == 1) {
+ if (back_route != nullptr) { // sg_network_crosstraffic was activated
XBT_DEBUG("Fullduplex active adding backward flow using 5%%");
- for (auto link : *back_route)
- lmm_expand(maxminSystem_, link->getConstraint(), action->getVariable(), .05);
-
+ for (auto const& link : *back_route)
+ lmm_expand(maxminSystem_, link->constraint(), action->getVariable(), .05);
+
//Change concurrency_share here, if you want that cross-traffic is included in the SURF concurrency
//(You would also have to change lmm_element_concurrency())
//lmm_variable_concurrency_share_set(action->getVariable(),2);
delete back_route;
XBT_OUT();
- Link::onCommunicate(action, src, dst);
+ simgrid::s4u::Link::onCommunicate(action, src, dst);
return action;
}
-bool NetworkCm02Model::next_occuring_event_isIdempotent()
-{
- return true;
-}
-
-void NetworkCm02Model::gapAppend(double size, const Link* link, NetworkAction* action)
-{
- // Nothing
-};
-
/************
* Resource *
************/
-NetworkCm02Link::NetworkCm02Link(NetworkCm02Model *model, const char *name, xbt_dict_t props,
- double bandwidth, double latency, e_surf_link_sharing_policy_t policy,
- lmm_system_t system)
-: Link(model, name, props, lmm_constraint_new(system, this, sg_bandwidth_factor * bandwidth))
+NetworkCm02Link::NetworkCm02Link(NetworkCm02Model* model, const std::string& name, double bandwidth, double latency,
+ e_surf_link_sharing_policy_t policy, lmm_system_t system)
+ : LinkImpl(model, name, lmm_constraint_new(system, this, sg_bandwidth_factor * bandwidth))
{
- m_bandwidth.scale = 1.0;
- m_bandwidth.peak = bandwidth;
+ bandwidth_.scale = 1.0;
+ bandwidth_.peak = bandwidth;
- m_latency.scale = 1.0;
- m_latency.peak = latency;
+ latency_.scale = 1.0;
+ latency_.peak = latency;
if (policy == SURF_LINK_FATPIPE)
- lmm_constraint_shared(getConstraint());
+ lmm_constraint_shared(constraint());
- Link::onCreation(this);
+ simgrid::s4u::Link::onCreation(this->piface_);
}
-
-
-void NetworkCm02Link::apply_event(tmgr_trace_iterator_t triggered, double value)
+void NetworkCm02Link::apply_event(tmgr_trace_event_t triggered, double value)
{
-
/* Find out which of my iterators was triggered, and react accordingly */
- if (triggered == m_bandwidth.event) {
- updateBandwidth(value);
- tmgr_trace_event_unref(&m_bandwidth.event);
+ if (triggered == bandwidth_.event) {
+ setBandwidth(value);
+ tmgr_trace_event_unref(&bandwidth_.event);
- } else if (triggered == m_latency.event) {
- updateLatency(value);
- tmgr_trace_event_unref(&m_latency.event);
+ } else if (triggered == latency_.event) {
+ setLatency(value);
+ tmgr_trace_event_unref(&latency_.event);
- } else if (triggered == m_stateEvent) {
+ } else if (triggered == stateEvent_) {
if (value > 0)
turnOn();
else {
- lmm_variable_t var = NULL;
- lmm_element_t elem = NULL;
+ lmm_variable_t var = nullptr;
+ lmm_element_t elem = nullptr;
double now = surf_get_clock();
turnOff();
- while ((var = lmm_get_var_from_cnst(getModel()->getMaxminSystem(), getConstraint(), &elem))) {
+ while ((var = lmm_get_var_from_cnst(model()->getMaxminSystem(), constraint(), &elem))) {
Action *action = static_cast<Action*>( lmm_variable_id(var) );
if (action->getState() == Action::State::running ||
}
}
}
- tmgr_trace_event_unref(&m_stateEvent);
+ tmgr_trace_event_unref(&stateEvent_);
} else {
xbt_die("Unknown event!\n");
}
- XBT_DEBUG("There was a resource state event, need to update actions related to the constraint (%p)",
- getConstraint());
+ XBT_DEBUG("There was a resource state event, need to update actions related to the constraint (%p)", constraint());
}
-void NetworkCm02Link::updateBandwidth(double value) {
+void NetworkCm02Link::setBandwidth(double value)
+{
- m_bandwidth.peak = value;
+ bandwidth_.peak = value;
- lmm_update_constraint_bound(getModel()->getMaxminSystem(), getConstraint(),
- sg_bandwidth_factor * (m_bandwidth.peak * m_bandwidth.scale));
- TRACE_surf_link_set_bandwidth(surf_get_clock(), getName(), sg_bandwidth_factor * m_bandwidth.peak * m_bandwidth.scale);
+ lmm_update_constraint_bound(model()->getMaxminSystem(), constraint(),
+ sg_bandwidth_factor * (bandwidth_.peak * bandwidth_.scale));
+ TRACE_surf_link_set_bandwidth(surf_get_clock(), cname(), sg_bandwidth_factor * bandwidth_.peak * bandwidth_.scale);
if (sg_weight_S_parameter > 0) {
- double delta = sg_weight_S_parameter / value - sg_weight_S_parameter / (m_bandwidth.peak * m_bandwidth.scale);
+ double delta = sg_weight_S_parameter / value - sg_weight_S_parameter / (bandwidth_.peak * bandwidth_.scale);
lmm_variable_t var;
- lmm_element_t elem = NULL, nextelem = NULL;
+ lmm_element_t elem = nullptr;
+ lmm_element_t nextelem = nullptr;
int numelem = 0;
- while ((var = lmm_get_var_from_cnst_safe(getModel()->getMaxminSystem(), getConstraint(), &elem, &nextelem, &numelem))) {
- NetworkCm02Action *action = (NetworkCm02Action*) lmm_variable_id(var);
+ while ((var = lmm_get_var_from_cnst_safe(model()->getMaxminSystem(), constraint(), &elem, &nextelem, &numelem))) {
+ NetworkCm02Action *action = static_cast<NetworkCm02Action*>(lmm_variable_id(var));
action->weight_ += delta;
- if (!action->isSuspended())
- lmm_update_variable_weight(getModel()->getMaxminSystem(), action->getVariable(), action->weight_);
+ if (not action->isSuspended())
+ lmm_update_variable_weight(model()->getMaxminSystem(), action->getVariable(), action->weight_);
}
}
}
-void NetworkCm02Link::updateLatency(double value){
- double delta = value - m_latency.peak;
- lmm_variable_t var = NULL;
- lmm_element_t elem = NULL;
- lmm_element_t nextelem = NULL;
+void NetworkCm02Link::setLatency(double value)
+{
+ double delta = value - latency_.peak;
+ lmm_variable_t var = nullptr;
+ lmm_element_t elem = nullptr;
+ lmm_element_t nextelem = nullptr;
int numelem = 0;
- m_latency.peak = value;
+ latency_.peak = value;
- while ((var = lmm_get_var_from_cnst_safe(getModel()->getMaxminSystem(), getConstraint(), &elem, &nextelem, &numelem))) {
- NetworkCm02Action *action = (NetworkCm02Action*) lmm_variable_id(var);
+ while ((var = lmm_get_var_from_cnst_safe(model()->getMaxminSystem(), constraint(), &elem, &nextelem, &numelem))) {
+ NetworkCm02Action *action = static_cast<NetworkCm02Action*>(lmm_variable_id(var));
action->latCurrent_ += delta;
action->weight_ += delta;
if (action->rate_ < 0)
- lmm_update_variable_bound(getModel()->getMaxminSystem(), action->getVariable(), sg_tcp_gamma / (2.0 * action->latCurrent_));
+ lmm_update_variable_bound(model()->getMaxminSystem(), action->getVariable(),
+ sg_tcp_gamma / (2.0 * action->latCurrent_));
else {
- lmm_update_variable_bound(getModel()->getMaxminSystem(), action->getVariable(),
+ lmm_update_variable_bound(model()->getMaxminSystem(), action->getVariable(),
std::min(action->rate_, sg_tcp_gamma / (2.0 * action->latCurrent_)));
if (action->rate_ < sg_tcp_gamma / (2.0 * action->latCurrent_)) {
XBT_INFO("Flow is limited BYLATENCY, latency of flow is %f", action->latCurrent_);
}
}
- if (!action->isSuspended())
- lmm_update_variable_weight(getModel()->getMaxminSystem(), action->getVariable(), action->weight_);
+ if (not action->isSuspended())
+ lmm_update_variable_weight(model()->getMaxminSystem(), action->getVariable(), action->weight_);
}
}
-NetworkCm02Link::~NetworkCm02Link() {}
-
/**********
* Action *
**********/
-NetworkCm02Action::~NetworkCm02Action() {}
-
void NetworkCm02Action::updateRemainingLazy(double now)
{
- double delta = 0.0;
-
if (suspended_ != 0)
return;
- delta = now - lastUpdate_;
+ double delta = now - lastUpdate_;
if (remains_ > 0) {
XBT_DEBUG("Updating action(%p): remains was %f, last_update was: %f", this, remains_, lastUpdate_);
XBT_DEBUG("Updating action(%p): remains is now %f", this, remains_);
}
- if (maxDuration_ != NO_MAX_DURATION)
+ if (maxDuration_ > NO_MAX_DURATION)
double_update(&maxDuration_, delta, sg_surf_precision);
- if (remains_ <= 0 &&
- (lmm_get_variable_weight(getVariable()) > 0)) {
- finish();
- setState(Action::State::done);
-
- heapRemove(getModel()->getActionHeap());
- } else if (((maxDuration_ != NO_MAX_DURATION)
- && (maxDuration_ <= 0))) {
- finish();
- setState(Action::State::done);
+ if ((remains_ <= 0 && (lmm_get_variable_weight(getVariable()) > 0)) ||
+ ((maxDuration_ > NO_MAX_DURATION) && (maxDuration_ <= 0))) {
+ finish(Action::State::done);
heapRemove(getModel()->getActionHeap());
}
lastValue_ = lmm_variable_getvalue(getVariable());
}
-void NetworkCm02Link::gapAppend(double size, const Link* link, NetworkAction* action)
-{
- // Nothing
-};
-
}
}
