[sonar] Extract nested conditionals.

[simgrid.git] / teshsuite / simdag / is-router / is-router.cpp

diff --git a/teshsuite/simdag/is-router/is-router.cpp b/teshsuite/simdag/is-router/is-router.cpp
index ffef43b..35441df 100644 (file)
--- a/teshsuite/simdag/is-router/is-router.cpp
+++ b/teshsuite/simdag/is-router/is-router.cpp
@@ -1,13 +1,15 @@
-/* Copyright (c) 2008-2016. The SimGrid Team. All rights reserved.          */
+/* Copyright (c) 2008-2019. The SimGrid Team. All rights reserved.          */
 
 /* This program is free software; you can redistribute it and/or modify it
  * under the terms of the license (GNU LGPL) which comes with this package. */
 
-#include "simgrid/s4u/host.hpp"
+#include "simgrid/kernel/routing/NetPoint.hpp"
+#include "simgrid/s4u/Engine.hpp"
+#include "simgrid/s4u/Host.hpp"
 #include "simgrid/simdag.h"
-#include "src/kernel/routing/NetCard.hpp"
-#include "surf/surf_routing.h"
-#include <stdio.h>
+
+#include <algorithm>
+#include <cstdio>
 
 int main(int argc, char **argv)
 {
@@ -15,27 +17,42 @@ int main(int argc, char **argv)
   SD_create_environment(argv[1]);
 
   xbt_dynar_t hosts = sg_hosts_as_dynar();
-  int size          = sg_host_count() + xbt_dict_length(netcards_dict);
+  std::printf("Host count: %zu, link number: %d\n", sg_host_count(), sg_link_count());
 
-  printf("Host number: %zu, link number: %d, elmts number: %d\n", sg_host_count(), sg_link_count(), size);
+  std::vector<simgrid::kernel::routing::NetPoint*> netpoints =
+      simgrid::s4u::Engine::get_instance()->get_all_netpoints();
+  std::sort(netpoints.begin(), netpoints.end(),
+            [](simgrid::kernel::routing::NetPoint* a, simgrid::kernel::routing::NetPoint* b) {
+              return a->get_name() < b->get_name();
+            });
 
   int it;
   sg_host_t host;
   xbt_dynar_foreach(hosts, it, host) {
-    simgrid::kernel::routing::NetCard * nc = host->pimpl_netcard;
-    printf("   - Seen: \"%s\". Type: %s\n", host->cname(),
-           nc->isRouter() ? "router" : (nc->isNetZone() ? "netzone" : "host"));
+    simgrid::kernel::routing::NetPoint* nc = host->pimpl_netpoint;
+    const char *type = "buggy";
+    if (nc->is_router())
+      type = "router";
+    if (nc->is_netzone())
+      type = "netzone";
+    if (nc->is_host())
+      type = "host";
+    std::printf("   - Seen: \"%s\". Type: %s\n", host->get_cname(), type);
   }
   xbt_dynar_free(&hosts);
 
-  xbt_lib_cursor_t cursor = nullptr;
-  char* key;
-  void *ignored;
-  xbt_dict_foreach (netcards_dict, cursor, key, ignored) {
-    simgrid::kernel::routing::NetCard * nc = sg_netcard_by_name_or_null(key);
-    printf("   - Seen: \"%s\". Type: %s\n", key, nc->isRouter() ? "router" : (nc->isNetZone() ? "netzone" : "host"));
+  std::printf("NetCards count: %zu\n", netpoints.size());
+  for (auto const& nc : netpoints) {
+    const char* type;
+    if (nc->is_router())
+      type = "router";
+    else if (nc->is_netzone())
+      type = "netzone";
+    else if (nc->is_host())
+      type = "host";
+    else
+      type = "buggy";
+    std::printf("   - Seen: \"%s\". Type: %s\n", nc->get_cname(), type);
   }
-
-  SD_exit();
   return 0;
 }