further cleanup the files provided with the tuto

[simgrid.git] / doc / msg-tuto-src / masterworker1.c

diff --git a/doc/msg-tuto-src/masterworker1.c b/doc/msg-tuto-src/masterworker1.c
index 89ad922..35deb99 100644 (file)
--- a/doc/msg-tuto-src/masterworker1.c
+++ b/doc/msg-tuto-src/masterworker1.c
@@ -1,5 +1,4 @@
-/* Copyright (c) 2007-2010, 2013-2015. The SimGrid Team.
- * All rights reserved.                                                     */
+/* Copyright (c) 2007-2017. The SimGrid Team. All rights reserved.          */
 
 /* This program is free software; you can redistribute it and/or modify it
  * under the terms of the license (GNU LGPL) which comes with this package. */
@@ -24,49 +23,43 @@ static int worker(int argc, char* argv[]);
 
 static int master(int argc, char *argv[])
 {
-  int workers_count = 0;
-  msg_host_t *workers = NULL;
-  msg_task_t *todo = NULL;
   msg_host_t host_self = MSG_host_self();
-  char *master_name = (char *) MSG_host_get_name(host_self);
+  const char* master_name = MSG_host_get_name(host_self);
   char channel[1024];
 
   long number_of_tasks = xbt_str_parse_int(argv[1], "Invalid amount of tasks: %s");    /** - Number of tasks      */
   double comp_size = xbt_str_parse_double(argv[2], "Invalid computational size: %s");  /** - Task compute cost    */
   double comm_size = xbt_str_parse_double(argv[3], "Invalid communication size: %s");  /** - Task communication size */
 
-  {                             /*  Task creation */
-    char sprintf_buffer[64];
-
-    todo = xbt_new0(msg_task_t, number_of_tasks);
+  /* Create the tasks in advance */
+  msg_task_t* todo = xbt_new0(msg_task_t, number_of_tasks);
 
-    for (int i = 0; i < number_of_tasks; i++) {
-      sprintf(sprintf_buffer, "Task_%d", i);
-      todo[i] = MSG_task_create(sprintf_buffer, comp_size, comm_size, NULL);
-    }
+  for (int i = 0; i < number_of_tasks; i++) {
+    char sprintf_buffer[64];
+    sprintf(sprintf_buffer, "Task_%d", i);
+    todo[i] = MSG_task_create(sprintf_buffer, comp_size, comm_size, NULL);
   }
 
-  {                             /* Process organization */
-    workers_count = MSG_get_host_number();
-    workers = xbt_dynar_to_array(MSG_hosts_as_dynar());
+  /* Get the info about the worker processes (directly from SimGrid) */
+  int workers_count   = argc - 4;
+  msg_host_t* workers = xbt_dynar_to_array(MSG_hosts_as_dynar());
 
-    for (int i = 0; i < workers_count; i++)
-      if(host_self == workers[i]) {
-         workers[i] = workers[workers_count-1];
-         workers_count--;
-         break;
-      }
-
-    for (int i = 0; i < workers_count; i++)
-      MSG_process_create("worker", worker, master_name, workers[i]);
-  }
+  for (int i = 0; i < workers_count; i++)
+    if (host_self == workers[i]) {
+      workers[i] = workers[workers_count - 1];
+      workers_count--;
+      break;
+    }
 
-  XBT_INFO("Got %d workers and %Ld tasks to process", workers_count, number_of_tasks);
+  for (int i = 0; i < workers_count; i++)
+    MSG_process_create("worker", worker, (void*)master_name, workers[i]);
+  XBT_INFO("Got %d workers and %ld tasks to process", workers_count, number_of_tasks);
 
+  /* Dispatch the tasks */
   for (int i = 0; i < number_of_tasks; i++) {
     build_channel_name(channel, master_name, MSG_host_get_name(workers[i % workers_count]));
 
-    XBT_INFO("Sending \"%s\" to channel \"%s\"", todo[i]->name, channel);
+    XBT_INFO("Sending '%s' to channel '%s'", todo[i]->name, channel);
 
     MSG_task_send(todo[i], channel);
     XBT_INFO("Sent");
@@ -87,28 +80,27 @@ static int master(int argc, char *argv[])
 /** Receiver function  */
 static int worker(int argc, char *argv[])
 {
-  msg_task_t task = NULL;
   char channel[1024];
 
   build_channel_name(channel, MSG_process_get_data(MSG_process_self()), MSG_host_get_name(MSG_host_self()));
 
-  XBT_INFO("Receiving on channel \"%s\"", channel);
+  XBT_INFO("Receiving on channel '%s'", channel);
 
   while (1) {
+    msg_task_t task = NULL;
     int res = MSG_task_receive(&(task), channel);
     xbt_assert(res == MSG_OK, "MSG_task_receive failed");
-    
-    XBT_INFO("Received \"%s\"", MSG_task_get_name(task));
+
+    XBT_INFO("Received '%s'", MSG_task_get_name(task));
     if (!strcmp(MSG_task_get_name(task), "finalize")) {
       MSG_task_destroy(task);
       break;
     }
 
-    XBT_INFO("Processing \"%s\"", MSG_task_get_name(task));
+    XBT_INFO("Processing '%s'", MSG_task_get_name(task));
     MSG_task_execute(task);
-    XBT_INFO("\"%s\" done", MSG_task_get_name(task));
+    XBT_INFO("'%s' done", MSG_task_get_name(task));
     MSG_task_destroy(task);
-    task = NULL;
   }
   XBT_INFO("I'm done. See you!");
   return 0;
@@ -117,20 +109,21 @@ static int worker(int argc, char *argv[])
 /** Main function */
 int main(int argc, char *argv[])
 {
-
   MSG_init(&argc, argv);
   xbt_assert(argc > 2, "Usage: %s platform_file deployment_file\n"
              "\tExample: %s msg_platform.xml msg_deployment.xml\n", argv[0], argv[0]);
-  {                             /*  Simulation setting */
-    MSG_create_environment(argv[1]);
-  }
-  {                             /*   Application deployment */
-    MSG_function_register("master", master);
-    MSG_function_register("worker", worker);
-    MSG_launch_application(argv[2]);
-  }
+
+  /*  Create a simulated platform */
+  MSG_create_environment(argv[1]);
+
+  /*   Application deployment */
+  MSG_function_register("master", master);
+  MSG_function_register("worker", worker);
+  MSG_launch_application(argv[2]);
+
+  /* Run the simulation */
   msg_error_t res = MSG_main();
 
   XBT_INFO("Simulation time %g", MSG_get_clock());
   return (res != MSG_OK);
-}                               /* end_of_main */
+}