1 /* Copyright (c) 2004-2011. The SimGrid Team.
2 * All rights reserved. */
4 /* This program is free software; you can redistribute it and/or modify it
5 * under the terms of the license (GNU LGPL) which comes with this package. */
8 #include "xbt/sysdep.h"
10 #include "xbt/mallocator.h"
11 #include "maxmin_private.h"
13 #include <stdio.h> /* sprintf */
15 XBT_LOG_NEW_DEFAULT_SUBCATEGORY(surf_maxmin, surf,
16 "Logging specific to SURF (maxmin)");
18 double sg_maxmin_precision = 0.00001;
20 static void *lmm_variable_mallocator_new_f(void);
21 static void lmm_variable_mallocator_free_f(void *var);
22 #define lmm_variable_mallocator_reset_f ((void_f_pvoid_t)NULL)
23 static void lmm_update_modified_set(lmm_system_t sys,
24 lmm_constraint_t cnst);
25 static void lmm_remove_all_modified_set(lmm_system_t sys);
26 static int Global_debug_id = 1;
27 static int Global_const_debug_id = 1;
29 lmm_system_t lmm_system_new(int selective_update)
31 lmm_system_t l = NULL;
33 s_lmm_constraint_t cnst;
35 l = xbt_new0(s_lmm_system_t, 1);
38 l->selective_update_active = selective_update;
39 l->visited_counter = 1;
41 XBT_DEBUG("Setting selective_update_active flag to %d\n",
42 l->selective_update_active);
44 xbt_swag_init(&(l->variable_set),
45 xbt_swag_offset(var, variable_set_hookup));
46 xbt_swag_init(&(l->constraint_set),
47 xbt_swag_offset(cnst, constraint_set_hookup));
49 xbt_swag_init(&(l->active_constraint_set),
50 xbt_swag_offset(cnst, active_constraint_set_hookup));
52 xbt_swag_init(&(l->modified_constraint_set),
53 xbt_swag_offset(cnst, modified_constraint_set_hookup));
54 xbt_swag_init(&(l->saturated_variable_set),
55 xbt_swag_offset(var, saturated_variable_set_hookup));
56 xbt_swag_init(&(l->saturated_constraint_set),
57 xbt_swag_offset(cnst, saturated_constraint_set_hookup));
59 l->variable_mallocator = xbt_mallocator_new(65536,
60 lmm_variable_mallocator_new_f,
61 lmm_variable_mallocator_free_f,
62 lmm_variable_mallocator_reset_f);
67 void lmm_system_free(lmm_system_t sys)
69 lmm_variable_t var = NULL;
70 lmm_constraint_t cnst = NULL;
72 while ((var = extract_variable(sys))) {
74 ("Variable %p (%d) still in LMM system when freing it: this may be a bug",
76 lmm_var_free(sys, var);
79 while ((cnst = extract_constraint(sys)))
80 lmm_cnst_free(sys, cnst);
82 xbt_mallocator_free(sys->variable_mallocator);
86 XBT_INLINE void lmm_variable_disable(lmm_system_t sys, lmm_variable_t var)
91 lmm_element_t elem = NULL;
93 XBT_IN("(sys=%p, var=%p)", sys, var);
97 for (i = 0; i < var->cnsts_number; i++) {
98 elem = &var->cnsts[i];
99 xbt_swag_remove(elem, &(elem->constraint->element_set));
100 xbt_swag_remove(elem, &(elem->constraint->active_element_set));
101 if (!xbt_swag_size(&(elem->constraint->element_set)))
102 make_constraint_inactive(sys, elem->constraint);
105 var->cnsts[n].constraint = elem->constraint;
110 var->cnsts_number = n;
111 lmm_update_modified_set(sys, var->cnsts[0].constraint);
114 var->cnsts_number = 0;
118 static void lmm_var_free(lmm_system_t sys, lmm_variable_t var)
121 lmm_variable_disable(sys, var);
122 xbt_mallocator_release(sys->variable_mallocator, var);
125 static XBT_INLINE void lmm_cnst_free(lmm_system_t sys,
126 lmm_constraint_t cnst)
128 /* xbt_assert(xbt_swag_size(&(cnst->element_set)), */
129 /* "This list should be empty!"); */
130 make_constraint_inactive(sys, cnst);
134 lmm_constraint_t lmm_constraint_new(lmm_system_t sys, void *id,
137 lmm_constraint_t cnst = NULL;
138 s_lmm_element_t elem;
140 cnst = xbt_new0(s_lmm_constraint_t, 1);
142 cnst->id_int = Global_const_debug_id++;
143 xbt_swag_init(&(cnst->element_set),
144 xbt_swag_offset(elem, element_set_hookup));
145 xbt_swag_init(&(cnst->active_element_set),
146 xbt_swag_offset(elem, active_element_set_hookup));
148 cnst->bound = bound_value;
151 insert_constraint(sys, cnst);
156 XBT_INLINE void lmm_constraint_shared(lmm_constraint_t cnst)
161 XBT_INLINE int lmm_constraint_is_shared(lmm_constraint_t cnst)
163 return (cnst->shared);
166 XBT_INLINE void lmm_constraint_free(lmm_system_t sys,
167 lmm_constraint_t cnst)
169 remove_constraint(sys, cnst);
170 lmm_cnst_free(sys, cnst);
173 static void *lmm_variable_mallocator_new_f(void)
175 lmm_variable_t var = xbt_new(s_lmm_variable_t, 1);
176 var->cnsts = NULL; /* will be created by realloc */
180 static void lmm_variable_mallocator_free_f(void *var)
182 xbt_free(((lmm_variable_t) var)->cnsts);
186 lmm_variable_t lmm_variable_new(lmm_system_t sys, void *id,
188 double bound, int number_of_constraints)
190 lmm_variable_t var = NULL;
193 XBT_IN("(sys=%p, id=%p, weight=%f, bound=%f, num_cons =%d)",
194 sys, id, weight, bound, number_of_constraints);
196 var = xbt_mallocator_get(sys->variable_mallocator);
198 var->id_int = Global_debug_id++;
199 var->cnsts = xbt_realloc(var->cnsts, number_of_constraints * sizeof(s_lmm_element_t));
200 for (i = 0; i < number_of_constraints; i++) {
201 var->cnsts[i].element_set_hookup.next = NULL;
202 var->cnsts[i].element_set_hookup.prev = NULL;
203 var->cnsts[i].active_element_set_hookup.next = NULL;
204 var->cnsts[i].active_element_set_hookup.prev = NULL;
205 var->cnsts[i].constraint = NULL;
206 var->cnsts[i].variable = NULL;
207 var->cnsts[i].value = 0.0;
209 var->cnsts_size = number_of_constraints;
210 var->cnsts_number = 0;
211 var->weight = weight;
214 var->visited = sys->visited_counter - 1;
217 var->func_f = func_f_def;
218 var->func_fp = func_fp_def;
219 var->func_fpi = func_fpi_def;
221 var->variable_set_hookup.next = NULL;
222 var->variable_set_hookup.prev = NULL;
223 var->saturated_variable_set_hookup.next = NULL;
224 var->saturated_variable_set_hookup.prev = NULL;
227 xbt_swag_insert_at_head(var, &(sys->variable_set));
229 xbt_swag_insert_at_tail(var, &(sys->variable_set));
234 void lmm_variable_free(lmm_system_t sys, lmm_variable_t var)
236 remove_variable(sys, var);
237 lmm_var_free(sys, var);
240 XBT_INLINE double lmm_variable_getvalue(lmm_variable_t var)
245 XBT_INLINE double lmm_variable_getbound(lmm_variable_t var)
250 void lmm_expand(lmm_system_t sys, lmm_constraint_t cnst,
251 lmm_variable_t var, double value)
253 lmm_element_t elem = NULL;
257 xbt_assert(var->cnsts_number < var->cnsts_size, "Too much constraints");
259 elem = &(var->cnsts[var->cnsts_number++]);
262 elem->constraint = cnst;
263 elem->variable = var;
266 xbt_swag_insert_at_head(elem, &(elem->constraint->element_set));
268 xbt_swag_insert_at_tail(elem, &(elem->constraint->element_set));
270 make_constraint_active(sys, cnst);
271 lmm_update_modified_set(sys, cnst);
272 if (var->cnsts_number > 1)
273 lmm_update_modified_set(sys, var->cnsts[0].constraint);
276 void lmm_expand_add(lmm_system_t sys, lmm_constraint_t cnst,
277 lmm_variable_t var, double value)
282 for (i = 0; i < var->cnsts_number; i++)
283 if (var->cnsts[i].constraint == cnst)
286 if (i < var->cnsts_number) {
288 var->cnsts[i].value += value;
290 var->cnsts[i].value = MAX(var->cnsts[i].value, value);
291 lmm_update_modified_set(sys, cnst);
293 lmm_expand(sys, cnst, var, value);
296 void lmm_elem_set_value(lmm_system_t sys, lmm_constraint_t cnst,
297 lmm_variable_t var, double value)
301 for (i = 0; i < var->cnsts_number; i++)
302 if (var->cnsts[i].constraint == cnst)
305 if (i < var->cnsts_number) {
306 var->cnsts[i].value = value;
308 lmm_update_modified_set(sys, cnst);
313 XBT_INLINE lmm_constraint_t lmm_get_cnst_from_var(lmm_system_t sys,
317 if (num < var->cnsts_number)
318 return (var->cnsts[num].constraint);
323 XBT_INLINE double lmm_get_cnst_weight_from_var(lmm_system_t sys,
327 if (num < var->cnsts_number)
328 return (var->cnsts[num].value);
333 XBT_INLINE int lmm_get_number_of_cnst_from_var(lmm_system_t sys,
336 return (var->cnsts_number);
339 lmm_variable_t lmm_get_var_from_cnst(lmm_system_t sys,
340 lmm_constraint_t cnst,
341 lmm_element_t * elem)
344 *elem = xbt_swag_getFirst(&(cnst->element_set));
346 *elem = xbt_swag_getNext(*elem, cnst->element_set.offset);
348 return (*elem)->variable;
353 XBT_INLINE void *lmm_constraint_id(lmm_constraint_t cnst)
358 XBT_INLINE void *lmm_variable_id(lmm_variable_t var)
363 static XBT_INLINE int saturated_constraint_set_update(lmm_system_t sys,
368 lmm_constraint_t useless_cnst = NULL;
370 XBT_IN("sys=%p, cnst=%p, min_usage=%f", sys, cnst, *min_usage);
371 if (cnst->usage <= 0) {
375 if (cnst->remaining <= 0) {
379 if ((*min_usage < 0) || (*min_usage > cnst->remaining / cnst->usage)) {
380 *min_usage = cnst->remaining / cnst->usage;
381 XBT_LOG(xbt_log_priority_trace,
382 "min_usage=%f (cnst->remaining=%f, cnst->usage=%f)", *min_usage,
383 cnst->remaining, cnst->usage);
384 while ((useless_cnst =
385 xbt_swag_getFirst(&(sys->saturated_constraint_set))))
386 xbt_swag_remove(useless_cnst, &(sys->saturated_constraint_set));
388 xbt_swag_insert(cnst, &(sys->saturated_constraint_set));
389 } else if (*min_usage == cnst->remaining / cnst->usage) {
390 xbt_swag_insert(cnst, &(sys->saturated_constraint_set));
396 static XBT_INLINE void saturated_variable_set_update(lmm_system_t sys)
398 lmm_constraint_t cnst = NULL;
399 xbt_swag_t cnst_list = NULL;
400 lmm_element_t elem = NULL;
401 xbt_swag_t elem_list = NULL;
403 cnst_list = &(sys->saturated_constraint_set);
404 while ((cnst = xbt_swag_getFirst(cnst_list))) {
405 elem_list = &(cnst->active_element_set);
406 xbt_swag_foreach(elem, elem_list) {
407 if (elem->variable->weight <= 0)
409 if ((elem->value > 0))
410 xbt_swag_insert(elem->variable, &(sys->saturated_variable_set));
412 xbt_swag_remove(cnst, cnst_list);
416 void lmm_print(lmm_system_t sys)
418 lmm_constraint_t cnst = NULL;
419 lmm_element_t elem = NULL;
420 lmm_variable_t var = NULL;
421 xbt_swag_t cnst_list = NULL;
422 xbt_swag_t var_list = NULL;
423 xbt_swag_t elem_list = NULL;
424 char print_buf[1024];
425 char *trace_buf = xbt_malloc0(sizeof(char));
428 /* Printing Objective */
429 var_list = &(sys->variable_set);
430 sprintf(print_buf, "MAX-MIN ( ");
432 xbt_realloc(trace_buf, strlen(trace_buf) + strlen(print_buf) + 1);
433 strcat(trace_buf, print_buf);
434 xbt_swag_foreach(var, var_list) {
435 sprintf(print_buf, "'%d'(%f) ", var->id_int, var->weight);
437 xbt_realloc(trace_buf, strlen(trace_buf) + strlen(print_buf) + 1);
438 strcat(trace_buf, print_buf);
440 sprintf(print_buf, ")");
442 xbt_realloc(trace_buf, strlen(trace_buf) + strlen(print_buf) + 1);
443 strcat(trace_buf, print_buf);
444 XBT_DEBUG("%20s", trace_buf);
445 trace_buf[0] = '\000';
447 XBT_DEBUG("Constraints");
448 /* Printing Constraints */
449 cnst_list = &(sys->active_constraint_set);
450 xbt_swag_foreach(cnst, cnst_list) {
452 elem_list = &(cnst->element_set);
453 sprintf(print_buf, "\t");
455 xbt_realloc(trace_buf, strlen(trace_buf) + strlen(print_buf) + 1);
456 strcat(trace_buf, print_buf);
457 sprintf(print_buf, "%s(",(cnst->shared)?"":"max");
459 xbt_realloc(trace_buf,
460 strlen(trace_buf) + strlen(print_buf) + 1);
461 strcat(trace_buf, print_buf);
462 xbt_swag_foreach(elem, elem_list) {
463 sprintf(print_buf, "%f.'%d'(%f) %s ", elem->value,
464 elem->variable->id_int, elem->variable->value,(cnst->shared)?"+":",");
466 xbt_realloc(trace_buf,
467 strlen(trace_buf) + strlen(print_buf) + 1);
468 strcat(trace_buf, print_buf);
470 sum += elem->value * elem->variable->value;
472 sum = MAX(sum,elem->value * elem->variable->value);
474 sprintf(print_buf, "0) <= %f ('%d')", cnst->bound, cnst->id_int);
476 xbt_realloc(trace_buf, strlen(trace_buf) + strlen(print_buf) + 1);
477 strcat(trace_buf, print_buf);
480 sprintf(print_buf, " [MAX-Constraint]");
482 xbt_realloc(trace_buf,
483 strlen(trace_buf) + strlen(print_buf) + 1);
484 strcat(trace_buf, print_buf);
486 XBT_DEBUG("%s", trace_buf);
487 trace_buf[0] = '\000';
488 xbt_assert(!double_positive(sum - cnst->bound),
489 "Incorrect value (%f is not smaller than %f): %g",
490 sum, cnst->bound, sum - cnst->bound);
493 XBT_DEBUG("Variables");
494 /* Printing Result */
495 xbt_swag_foreach(var, var_list) {
496 if (var->bound > 0) {
497 XBT_DEBUG("'%d'(%f) : %f (<=%f)", var->id_int, var->weight, var->value,
499 xbt_assert(!double_positive(var->value - var->bound),
500 "Incorrect value (%f is not smaller than %f",
501 var->value, var->bound);
503 XBT_DEBUG("'%d'(%f) : %f", var->id_int, var->weight, var->value);
510 void lmm_solve(lmm_system_t sys)
512 lmm_variable_t var = NULL;
513 lmm_constraint_t cnst = NULL;
514 lmm_constraint_t cnst_next = NULL;
515 lmm_element_t elem = NULL;
516 xbt_swag_t cnst_list = NULL;
517 xbt_swag_t var_list = NULL;
518 xbt_swag_t elem_list = NULL;
519 double min_usage = -1;
520 double min_bound = -1;
522 if (!(sys->modified))
525 XBT_IN("(sys=%p)", sys);
528 * Compute Usage and store the variables that reach the maximum.
532 selective_update_active ? &(sys->modified_constraint_set) :
533 &(sys->active_constraint_set);
535 XBT_DEBUG("Active constraints : %d", xbt_swag_size(cnst_list));
536 /* Init: Only modified code portions */
537 xbt_swag_foreach(cnst, cnst_list) {
538 elem_list = &(cnst->element_set);
539 //XBT_DEBUG("Variable set : %d", xbt_swag_size(elem_list));
540 xbt_swag_foreach(elem, elem_list) {
541 var = elem->variable;
542 if (var->weight <= 0.0)
548 xbt_swag_foreach_safe(cnst, cnst_next, cnst_list) {
550 cnst->remaining = cnst->bound;
551 if (cnst->remaining == 0)
554 elem_list = &(cnst->element_set);
555 xbt_swag_foreach(elem, elem_list) {
556 /* 0-weighted elements (ie, sleep actions) are at the end of the swag and we don't want to consider them */
557 if (elem->variable->weight <= 0)
559 if ((elem->value > 0)) {
561 cnst->usage += elem->value / elem->variable->weight;
562 else if (cnst->usage < elem->value / elem->variable->weight)
563 cnst->usage = elem->value / elem->variable->weight;
565 make_elem_active(elem);
567 xbt_swag_insert(elem->variable->id, sys->keep_track);
570 XBT_DEBUG("Constraint Usage '%d' : %f", cnst->id_int, cnst->usage);
571 /* Saturated constraints update */
573 xbt_swag_remove(cnst, cnst_list);
574 xbt_swag_insert_at_head(cnst, cnst_list);
576 saturated_constraint_set_update(sys, cnst, &min_usage);
578 saturated_variable_set_update(sys);
580 /* Saturated variables update */
583 /* Fix the variables that have to be */
584 var_list = &(sys->saturated_variable_set);
586 xbt_swag_foreach(var, var_list) {
587 if (var->weight <= 0.0)
589 /* First check if some of these variables have reach their upper
590 bound and update min_usage accordingly. */
592 ("var=%d, var->bound=%f, var->weight=%f, min_usage=%f, var->bound*var->weight=%f",
593 var->id_int, var->bound, var->weight, min_usage,
594 var->bound * var->weight);
595 if ((var->bound > 0) && (var->bound * var->weight < min_usage)) {
597 min_bound = var->bound;
599 min_bound = MIN(min_bound, var->bound);
600 XBT_DEBUG("Updated min_bound=%f", min_bound);
605 while ((var = xbt_swag_getFirst(var_list))) {
609 var->value = min_usage / var->weight;
611 if (min_bound == var->bound)
612 var->value = var->bound;
614 xbt_swag_remove(var, var_list);
618 XBT_DEBUG("Min usage: %f, Var(%d)->weight: %f, Var(%d)->value: %f ",
619 min_usage, var->id_int, var->weight, var->id_int, var->value);
624 for (i = 0; i < var->cnsts_number; i++) {
625 elem = &var->cnsts[i];
626 cnst = elem->constraint;
628 double_update(&(cnst->remaining), elem->value * var->value);
629 double_update(&(cnst->usage), elem->value / var->weight);
630 if(cnst->usage<=0 || cnst->remaining<=0) {
631 xbt_swag_remove(cnst, cnst_list);
632 xbt_swag_insert_at_tail(cnst, cnst_list);
634 make_elem_inactive(elem);
635 } else { /* FIXME one day: We recompute usage.... :( */
637 make_elem_inactive(elem);
638 elem_list = &(cnst->element_set);
639 xbt_swag_foreach(elem, elem_list) {
640 if (elem->variable->weight <= 0)
642 if (elem->variable->value > 0)
644 if ((elem->value > 0)) {
646 MAX(cnst->usage, elem->value / elem->variable->weight);
647 XBT_DEBUG("Constraint Usage %d : %f", cnst->id_int,
649 make_elem_active(elem);
654 xbt_swag_remove(var, var_list);
657 /* Find out which variables reach the maximum */
661 xbt_swag_foreach(cnst, cnst_list) {
662 if(saturated_constraint_set_update(sys, cnst, &min_usage)) break;
664 saturated_variable_set_update(sys);
666 } while (xbt_swag_size(&(sys->saturated_variable_set)));
669 if (sys->selective_update_active)
670 lmm_remove_all_modified_set(sys);
672 if (XBT_LOG_ISENABLED(surf_maxmin, xbt_log_priority_debug)) {
678 /* Not a O(1) function */
680 void lmm_update(lmm_system_t sys, lmm_constraint_t cnst,
681 lmm_variable_t var, double value)
685 for (i = 0; i < var->cnsts_number; i++)
686 if (var->cnsts[i].constraint == cnst) {
687 var->cnsts[i].value = value;
689 lmm_update_modified_set(sys, cnst);
694 /** \brief Attribute the value bound to var->bound.
696 * \param sys the lmm_system_t
697 * \param var the lmm_variable_t
698 * \param bound the new bound to associate with var
700 * Makes var->bound equal to bound. Whenever this function is called
701 * a change is signed in the system. To
702 * avoid false system changing detection it is a good idea to test
703 * (bound != 0) before calling it.
706 void lmm_update_variable_bound(lmm_system_t sys, lmm_variable_t var,
712 if (var->cnsts_number)
713 lmm_update_modified_set(sys, var->cnsts[0].constraint);
717 void lmm_update_variable_weight(lmm_system_t sys, lmm_variable_t var,
723 if (weight == var->weight)
725 XBT_IN("(sys=%p, var=%p, weight=%f)", sys, var, weight);
727 var->weight = weight;
728 xbt_swag_remove(var, &(sys->variable_set));
730 xbt_swag_insert_at_head(var, &(sys->variable_set));
732 xbt_swag_insert_at_tail(var, &(sys->variable_set));
734 for (i = 0; i < var->cnsts_number; i++) {
735 elem = &var->cnsts[i];
736 xbt_swag_remove(elem, &(elem->constraint->element_set));
738 xbt_swag_insert_at_head(elem, &(elem->constraint->element_set));
740 xbt_swag_insert_at_tail(elem, &(elem->constraint->element_set));
743 lmm_update_modified_set(sys, elem->constraint);
751 XBT_INLINE double lmm_get_variable_weight(lmm_variable_t var)
756 XBT_INLINE void lmm_update_constraint_bound(lmm_system_t sys,
757 lmm_constraint_t cnst,
761 lmm_update_modified_set(sys, cnst);
765 XBT_INLINE int lmm_constraint_used(lmm_system_t sys, lmm_constraint_t cnst)
767 return xbt_swag_belongs(cnst, &(sys->active_constraint_set));
770 XBT_INLINE lmm_constraint_t lmm_get_first_active_constraint(lmm_system_t
773 return xbt_swag_getFirst(&(sys->active_constraint_set));
776 XBT_INLINE lmm_constraint_t lmm_get_next_active_constraint(lmm_system_t
781 return xbt_swag_getNext(cnst, (sys->active_constraint_set).offset);
784 #ifdef HAVE_LATENCY_BOUND_TRACKING
785 XBT_INLINE int lmm_is_variable_limited_by_latency(lmm_variable_t var)
787 return (double_equals(var->bound, var->value));
792 /** \brief Update the constraint set propagating recursively to
793 * other constraints so the system should not be entirely computed.
795 * \param sys the lmm_system_t
796 * \param cnst the lmm_constraint_t affected by the change
798 * A recursive algorithm to optimize the system recalculation selecting only
799 * constraints that have changed. Each constraint change is propagated
800 * to the list of constraints for each variable.
802 static void lmm_update_modified_set_rec(lmm_system_t sys,
803 lmm_constraint_t cnst)
807 xbt_swag_foreach(elem, &cnst->element_set) {
808 lmm_variable_t var = elem->variable;
809 s_lmm_element_t *cnsts = var->cnsts;
811 for (i = 0; var->visited != sys->visited_counter
812 && i < var->cnsts_number ; i++) {
813 if (cnsts[i].constraint != cnst
814 && !xbt_swag_belongs(cnsts[i].constraint,
815 &sys->modified_constraint_set)) {
816 xbt_swag_insert(cnsts[i].constraint, &sys->modified_constraint_set);
817 lmm_update_modified_set_rec(sys, cnsts[i].constraint);
820 var->visited = sys->visited_counter;
824 static void lmm_update_modified_set(lmm_system_t sys,
825 lmm_constraint_t cnst)
827 /* nothing to do if selective update isn't active */
828 if (sys->selective_update_active
829 && !xbt_swag_belongs(cnst, &sys->modified_constraint_set)) {
830 xbt_swag_insert(cnst, &sys->modified_constraint_set);
831 lmm_update_modified_set_rec(sys, cnst);
835 /** \brief Remove all constraints of the modified_constraint_set.
837 * \param sys the lmm_system_t
839 static void lmm_remove_all_modified_set(lmm_system_t sys)
841 if (++sys->visited_counter == 1) {
842 /* the counter wrapped around, reset each variable->visited */
844 xbt_swag_foreach(var, &sys->variable_set)
847 xbt_swag_reset(&sys->modified_constraint_set);