Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
1f075189ca923bde90ec4b2a8d2f82694aef90dd
[simgrid.git] / src / surf / network_cm02.cpp
1 /* Copyright (c) 2013-2015. The SimGrid Team.
2  * All rights reserved.                                                     */
3
4 /* This program is free software; you can redistribute it and/or modify it
5  * under the terms of the license (GNU LGPL) which comes with this package. */
6
7 #include <algorithm>
8
9 #include "network_cm02.hpp"
10 #include "maxmin_private.hpp"
11 #include "simgrid/sg_config.h"
12 #include "src/instr/instr_private.h" // TRACE_is_enabled(). FIXME: remove by subscribing tracing to the surf signals
13
14 XBT_LOG_EXTERNAL_DEFAULT_CATEGORY(surf_network);
15
16 double sg_sender_gap = 0.0;
17 double sg_latency_factor = 1.0; /* default value; can be set by model or from command line */
18 double sg_bandwidth_factor = 1.0;       /* default value; can be set by model or from command line */
19 double sg_weight_S_parameter = 0.0;     /* default value; can be set by model or from command line */
20
21 double sg_tcp_gamma = 0.0;
22 int sg_network_crosstraffic = 0;
23
24 /************************************************************************/
25 /* New model based on optimizations discussed during Pedro Velho's thesis*/
26 /************************************************************************/
27 /* @techreport{VELHO:2011:HAL-00646896:1, */
28 /*      url = {http://hal.inria.fr/hal-00646896/en/}, */
29 /*      title = {{Flow-level network models: have we reached the limits?}}, */
30 /*      author = {Velho, Pedro and Schnorr, Lucas and Casanova, Henri and Legrand, Arnaud}, */
31 /*      type = {Rapport de recherche}, */
32 /*      institution = {INRIA}, */
33 /*      number = {RR-7821}, */
34 /*      year = {2011}, */
35 /*      month = Nov, */
36 /*      pdf = {http://hal.inria.fr/hal-00646896/PDF/rr-validity.pdf}, */
37 /*  } */
38 void surf_network_model_init_LegrandVelho(void)
39 {
40   if (surf_network_model)
41     return;
42
43   simgrid::surf::on_link.connect(netlink_parse_init);
44   surf_network_model = new simgrid::surf::NetworkCm02Model();
45   xbt_dynar_push(all_existing_models, &surf_network_model);
46
47   xbt_cfg_setdefault_double(_sg_cfg_set, "network/latency_factor",      13.01);
48   xbt_cfg_setdefault_double(_sg_cfg_set, "network/bandwidth_factor",     0.97);
49   xbt_cfg_setdefault_double(_sg_cfg_set, "network/weight_S",         20537);
50 }
51
52 /***************************************************************************/
53 /* The nice TCP sharing model designed by Loris Marchal and Henri Casanova */
54 /***************************************************************************/
55 /* @TechReport{      rr-lip2002-40, */
56 /*   author        = {Henri Casanova and Loris Marchal}, */
57 /*   institution   = {LIP}, */
58 /*   title         = {A Network Model for Simulation of Grid Application}, */
59 /*   number        = {2002-40}, */
60 /*   month         = {oct}, */
61 /*   year          = {2002} */
62 /* } */
63 void surf_network_model_init_CM02(void)
64 {
65
66   if (surf_network_model)
67     return;
68
69   simgrid::surf::on_link.connect(netlink_parse_init);
70   surf_network_model = new simgrid::surf::NetworkCm02Model();
71   xbt_dynar_push(all_existing_models, &surf_network_model);
72
73   xbt_cfg_setdefault_double(_sg_cfg_set, "network/latency_factor",   1.0);
74   xbt_cfg_setdefault_double(_sg_cfg_set, "network/bandwidth_factor", 1.0);
75   xbt_cfg_setdefault_double(_sg_cfg_set, "network/weight_S",         0.0);
76 }
77
78 /***************************************************************************/
79 /* The models from Steven H. Low                                           */
80 /***************************************************************************/
81 /* @article{Low03,                                                         */
82 /*   author={Steven H. Low},                                               */
83 /*   title={A Duality Model of {TCP} and Queue Management Algorithms},     */
84 /*   year={2003},                                                          */
85 /*   journal={{IEEE/ACM} Transactions on Networking},                      */
86 /*    volume={11}, number={4},                                             */
87 /*  }                                                                      */
88 void surf_network_model_init_Reno(void)
89 {
90   if (surf_network_model)
91     return;
92
93   simgrid::surf::on_link.connect(netlink_parse_init);
94   surf_network_model = new simgrid::surf::NetworkCm02Model();
95   xbt_dynar_push(all_existing_models, &surf_network_model);
96
97   lmm_set_default_protocol_function(func_reno_f, func_reno_fp, func_reno_fpi);
98   surf_network_model->f_networkSolve = lagrange_solve;
99
100   xbt_cfg_setdefault_double(_sg_cfg_set, "network/latency_factor",     10.4);
101   xbt_cfg_setdefault_double(_sg_cfg_set, "network/bandwidth_factor",    0.92);
102   xbt_cfg_setdefault_double(_sg_cfg_set, "network/weight_S",         8775);
103 }
104
105
106 void surf_network_model_init_Reno2(void)
107 {
108   if (surf_network_model)
109     return;
110
111   simgrid::surf::on_link.connect(netlink_parse_init);
112   surf_network_model = new simgrid::surf::NetworkCm02Model();
113   xbt_dynar_push(all_existing_models, &surf_network_model);
114
115   lmm_set_default_protocol_function(func_reno2_f, func_reno2_fp, func_reno2_fpi);
116   surf_network_model->f_networkSolve = lagrange_solve;
117
118   xbt_cfg_setdefault_double(_sg_cfg_set, "network/latency_factor",    10.4);
119   xbt_cfg_setdefault_double(_sg_cfg_set, "network/bandwidth_factor",   0.92);
120   xbt_cfg_setdefault_double(_sg_cfg_set, "network/weight_S",        8775);
121 }
122
123 void surf_network_model_init_Vegas(void)
124 {
125   if (surf_network_model)
126     return;
127
128   simgrid::surf::on_link.connect(netlink_parse_init);
129   surf_network_model = new simgrid::surf::NetworkCm02Model();
130   xbt_dynar_push(all_existing_models, &surf_network_model);
131
132   lmm_set_default_protocol_function(func_vegas_f, func_vegas_fp, func_vegas_fpi);
133   surf_network_model->f_networkSolve = lagrange_solve;
134
135   xbt_cfg_setdefault_double(_sg_cfg_set, "network/latency_factor",    10.4);
136   xbt_cfg_setdefault_double(_sg_cfg_set, "network/bandwidth_factor",   0.92);
137   xbt_cfg_setdefault_double(_sg_cfg_set, "network/weight_S",        8775);
138 }
139
140 namespace simgrid {
141 namespace surf {
142
143 NetworkCm02Model::NetworkCm02Model()
144   :NetworkModel()
145 {
146   char *optim = xbt_cfg_get_string(_sg_cfg_set, "network/optim");
147   int select = xbt_cfg_get_boolean(_sg_cfg_set, "network/maxmin_selective_update");
148
149   if (!strcmp(optim, "Full")) {
150     p_updateMechanism = UM_FULL;
151     m_selectiveUpdate = select;
152   } else if (!strcmp(optim, "Lazy")) {
153     p_updateMechanism = UM_LAZY;
154     m_selectiveUpdate = 1;
155     xbt_assert((select == 1) || (xbt_cfg_is_default_value(_sg_cfg_set, "network/maxmin_selective_update")),
156                "Disabling selective update while using the lazy update mechanism is dumb!");
157   } else {
158     xbt_die("Unsupported optimization (%s) for this model", optim);
159   }
160
161   if (!p_maxminSystem)
162     p_maxminSystem = lmm_system_new(m_selectiveUpdate);
163
164   routing_model_create(createLink("__loopback__",
165                                 498000000, NULL, 0.000015, NULL,
166                                 NULL,
167                                 SURF_LINK_FATPIPE, NULL));
168
169   if (p_updateMechanism == UM_LAZY) {
170   p_actionHeap = xbt_heap_new(8, NULL);
171   xbt_heap_set_update_callback(p_actionHeap, surf_action_lmm_update_index_heap);
172   p_modifiedSet = new ActionLmmList();
173   p_maxminSystem->keep_track = p_modifiedSet;
174   }
175 }
176
177 Link* NetworkCm02Model::createLink(const char *name,
178     double bw_initial, tmgr_trace_t bw_trace,
179     double lat_initial, tmgr_trace_t lat_trace,
180     tmgr_trace_t state_trace,
181     e_surf_link_sharing_policy_t policy, xbt_dict_t properties)
182 {
183   xbt_assert(NULL == Link::byName(name),
184              "Link '%s' declared several times in the platform",
185              name);
186
187   Link* link = new NetworkCm02Link(this, name, properties, p_maxminSystem, sg_bandwidth_factor * bw_initial,
188                      state_trace, bw_initial, bw_trace, lat_initial, lat_trace, policy);
189   Link::onCreation(link);
190   return link;
191 }
192
193 void NetworkCm02Model::updateActionsStateLazy(double now, double /*delta*/)
194 {
195   NetworkCm02Action *action;
196   while ((xbt_heap_size(p_actionHeap) > 0)
197          && (double_equals(xbt_heap_maxkey(p_actionHeap), now, sg_surf_precision))) {
198     action = static_cast<NetworkCm02Action*> (xbt_heap_pop(p_actionHeap));
199     XBT_DEBUG("Something happened to action %p", action);
200     if (TRACE_is_enabled()) {
201       int n = lmm_get_number_of_cnst_from_var(p_maxminSystem, action->getVariable());
202
203       for (int i = 0; i < n; i++){
204         lmm_constraint_t constraint = lmm_get_cnst_from_var(p_maxminSystem, action->getVariable(), i);
205         NetworkCm02Link *link = static_cast<NetworkCm02Link*>(lmm_constraint_id(constraint));
206         TRACE_surf_link_set_utilization(link->getName(),
207                                         action->getCategory(),
208                                         (lmm_variable_getvalue(action->getVariable())*
209                                             lmm_get_cnst_weight_from_var(p_maxminSystem,
210                                                 action->getVariable(),
211                                                 i)),
212                                         action->getLastUpdate(),
213                                         now - action->getLastUpdate());
214       }
215     }
216
217     // if I am wearing a latency hat
218     if (action->getHat() == LATENCY) {
219       XBT_DEBUG("Latency paid for action %p. Activating", action);
220       lmm_update_variable_weight(p_maxminSystem, action->getVariable(), action->m_weight);
221       action->heapRemove(p_actionHeap);
222       action->refreshLastUpdate();
223
224         // if I am wearing a max_duration or normal hat
225     } else if (action->getHat() == MAX_DURATION ||
226         action->getHat() == NORMAL) {
227         // no need to communicate anymore
228         // assume that flows that reached max_duration have remaining of 0
229       XBT_DEBUG("Action %p finished", action);
230       action->setRemains(0);
231       action->finish();
232       action->setState(SURF_ACTION_DONE);
233       action->heapRemove(p_actionHeap);
234
235       action->gapRemove();
236     }
237   }
238   return;
239 }
240
241
242 void NetworkCm02Model::updateActionsStateFull(double now, double delta)
243 {
244   NetworkCm02Action *action;
245   ActionList *running_actions = getRunningActionSet();
246
247   for(ActionList::iterator it(running_actions->begin()), itNext=it, itend(running_actions->end())
248      ; it != itend ; it=itNext) {
249   ++itNext;
250
251     action = static_cast<NetworkCm02Action*> (&*it);
252     XBT_DEBUG("Something happened to action %p", action);
253       double deltap = delta;
254       if (action->m_latency > 0) {
255         if (action->m_latency > deltap) {
256           double_update(&(action->m_latency), deltap, sg_surf_precision);
257           deltap = 0.0;
258         } else {
259           double_update(&(deltap), action->m_latency, sg_surf_precision);
260           action->m_latency = 0.0;
261         }
262         if (action->m_latency == 0.0 && !(action->isSuspended()))
263           lmm_update_variable_weight(p_maxminSystem, action->getVariable(),
264               action->m_weight);
265       }
266       if (TRACE_is_enabled()) {
267         int n = lmm_get_number_of_cnst_from_var(p_maxminSystem, action->getVariable());
268         for (int i = 0; i < n; i++){
269           lmm_constraint_t constraint = lmm_get_cnst_from_var(p_maxminSystem, action->getVariable(), i);
270
271           NetworkCm02Link* link = static_cast<NetworkCm02Link*>(lmm_constraint_id(constraint));
272           TRACE_surf_link_set_utilization(link->getName(),
273                                         action->getCategory(),
274                                         (lmm_variable_getvalue(action->getVariable())*
275                                             lmm_get_cnst_weight_from_var(p_maxminSystem,
276                                                 action->getVariable(),
277                                                 i)),
278                                         action->getLastUpdate(),
279                                         now - action->getLastUpdate());
280         }
281       }
282       if (!lmm_get_number_of_cnst_from_var (p_maxminSystem, action->getVariable())) {
283         /* There is actually no link used, hence an infinite bandwidth.
284          * This happens often when using models like vivaldi.
285          * In such case, just make sure that the action completes immediately.
286          */
287         action->updateRemains(action->getRemains());
288       }
289     action->updateRemains(lmm_variable_getvalue(action->getVariable()) * delta);
290                   
291     if (action->getMaxDuration() != NO_MAX_DURATION)
292       action->updateMaxDuration(delta);
293       
294     if ((action->getRemains() <= 0) &&
295         (lmm_get_variable_weight(action->getVariable()) > 0)) {
296       action->finish();
297       action->setState(SURF_ACTION_DONE);
298       action->gapRemove();
299     } else if (((action->getMaxDuration() != NO_MAX_DURATION)
300         && (action->getMaxDuration() <= 0))) {
301       action->finish();
302       action->setState(SURF_ACTION_DONE);
303       action->gapRemove();
304     }
305   }
306 }
307
308 Action *NetworkCm02Model::communicate(NetCard *src, NetCard *dst,
309                                                 double size, double rate)
310 {
311   int failed = 0;
312   NetworkCm02Action *action = NULL;
313   double bandwidth_bound;
314   double latency = 0.0;
315   std::vector<Link*> * back_route = NULL;
316   int constraints_per_variable = 0;
317
318   std::vector<Link*> *route = new std::vector<Link*>();
319
320   XBT_IN("(%s,%s,%g,%g)", src->name(), dst->name(), size, rate);
321
322   routing_platf->getRouteAndLatency(src, dst, route, &latency);
323   xbt_assert(! route->empty() || latency,
324              "You're trying to send data from %s to %s but there is no connecting path between these two hosts.",
325              src->name(), dst->name());
326
327   for (auto link: *route)
328     if (link->isOff())
329       failed = 1;
330
331   if (sg_network_crosstraffic == 1) {
332     back_route = new std::vector<Link*>();
333     routing_platf->getRouteAndLatency(dst, src, back_route, NULL);
334     for (auto link: *back_route)
335       if (link->isOff())
336         failed = 1;
337   }
338
339   action = new NetworkCm02Action(this, size, failed);
340
341 #ifdef HAVE_LATENCY_BOUND_TRACKING
342   action->m_latencyLimited = 0;
343 #endif
344   action->m_weight = action->m_latency = latency;
345
346   action->m_rate = rate;
347   if (p_updateMechanism == UM_LAZY) {
348     action->m_indexHeap = -1;
349     action->m_lastUpdate = surf_get_clock();
350   }
351
352   bandwidth_bound = -1.0;
353   if (sg_weight_S_parameter > 0)
354     for (auto link : *route)
355       action->m_weight += sg_weight_S_parameter / link->getBandwidth();
356
357   for (auto link : *route) {
358     double bb = bandwidthFactor(size) * link->getBandwidth();
359     bandwidth_bound = (bandwidth_bound < 0.0) ? bb : std::min(bandwidth_bound, bb);
360   }
361
362   action->m_latCurrent = action->m_latency;
363   action->m_latency *= latencyFactor(size);
364   action->m_rate = bandwidthConstraint(action->m_rate, bandwidth_bound, size);
365   if (m_haveGap) {
366     xbt_assert(! route->empty(),
367                "Using a model with a gap (e.g., SMPI) with a platform without links (e.g. vivaldi)!!!");
368
369     gapAppend(size, route->at(0), action);
370     XBT_DEBUG("Comm %p: %s -> %s gap=%f (lat=%f)", action, src->name(), dst->name(), action->m_senderGap, action->m_latency);
371   }
372
373   constraints_per_variable = route->size();
374   if (back_route != NULL)
375     constraints_per_variable += back_route->size();
376
377   if (action->m_latency > 0) {
378     action->p_variable = lmm_variable_new(p_maxminSystem, action, 0.0, -1.0,
379                          constraints_per_variable);
380     if (p_updateMechanism == UM_LAZY) {
381       // add to the heap the event when the latency is payed
382       XBT_DEBUG("Added action (%p) one latency event at date %f", action, action->m_latency + action->m_lastUpdate);
383       action->heapInsert(p_actionHeap, action->m_latency + action->m_lastUpdate, route->empty() ? NORMAL : LATENCY);
384     }
385   } else
386     action->p_variable = lmm_variable_new(p_maxminSystem, action, 1.0, -1.0, constraints_per_variable);
387
388   if (action->m_rate < 0) {
389     lmm_update_variable_bound(p_maxminSystem, action->getVariable(), (action->m_latCurrent > 0) ? sg_tcp_gamma / (2.0 * action->m_latCurrent) : -1.0);
390   } else {
391     lmm_update_variable_bound(p_maxminSystem, action->getVariable(), (action->m_latCurrent > 0) ? std::min(action->m_rate, sg_tcp_gamma / (2.0 * action->m_latCurrent)) : action->m_rate);
392   }
393
394   for (auto link: *route)
395     lmm_expand(p_maxminSystem, link->getConstraint(), action->getVariable(), 1.0);
396
397   if (sg_network_crosstraffic == 1) {
398     XBT_DEBUG("Fullduplex active adding backward flow using 5%%");
399     for (auto link : *back_route)
400       lmm_expand(p_maxminSystem, link->getConstraint(), action->getVariable(), .05);
401      
402     //Change concurrency_share here, if you want that cross-traffic is included in the SURF concurrency
403     //(You would also have to change lmm_element_concurrency())
404     //lmm_variable_concurrency_share_set(action->getVariable(),2);
405   }
406
407   delete route;
408   XBT_OUT();
409
410   networkCommunicateCallbacks(action, src, dst, size, rate);
411   return action;
412 }
413
414 /************
415  * Resource *
416  ************/
417 NetworkCm02Link::NetworkCm02Link(NetworkCm02Model *model, const char *name, xbt_dict_t props,
418     lmm_system_t system,
419     double constraint_value,
420     tmgr_trace_t state_trace,
421     double bw_peak, tmgr_trace_t bw_trace,
422     double lat_initial, tmgr_trace_t lat_trace,
423     e_surf_link_sharing_policy_t policy)
424 : Link(model, name, props, lmm_constraint_new(system, this, constraint_value), state_trace)
425 {
426   m_bandwidth.scale = 1.0;
427   m_bandwidth.peak = bw_peak;
428   if (bw_trace)
429     m_bandwidth.event = future_evt_set->add_trace(bw_trace, 0.0, this);
430   else
431     m_bandwidth.event = NULL;
432
433   m_latency.scale = 1.0;
434   m_latency.peak = lat_initial;
435   if (lat_trace)
436     m_latency.event = future_evt_set->add_trace(lat_trace, 0.0, this);
437
438   if (policy == SURF_LINK_FATPIPE)
439     lmm_constraint_shared(getConstraint());
440 }
441
442
443
444 void NetworkCm02Link::apply_event(tmgr_trace_iterator_t triggered, double value)
445 {
446
447   /* Find out which of my iterators was triggered, and react accordingly */
448   if (triggered == m_bandwidth.event) {
449     updateBandwidth(value);
450     tmgr_trace_event_unref(&m_bandwidth.event);
451
452   } else if (triggered == m_latency.event) {
453     updateLatency(value);
454     tmgr_trace_event_unref(&m_latency.event);
455
456   } else if (triggered == m_stateEvent) {
457     if (value > 0)
458       turnOn();
459     else {
460       lmm_variable_t var = NULL;
461       lmm_element_t elem = NULL;
462       double now = surf_get_clock();
463
464       turnOff();
465       while ((var = lmm_get_var_from_cnst(getModel()->getMaxminSystem(), getConstraint(), &elem))) {
466         Action *action = static_cast<Action*>( lmm_variable_id(var) );
467
468         if (action->getState() == SURF_ACTION_RUNNING ||
469             action->getState() == SURF_ACTION_READY) {
470           action->setFinishTime(now);
471           action->setState(SURF_ACTION_FAILED);
472         }
473       }
474     }
475     tmgr_trace_event_unref(&m_stateEvent);
476   } else {
477     xbt_die("Unknown event!\n");
478   }
479
480   XBT_DEBUG("There was a resource state event, need to update actions related to the constraint (%p)",
481        getConstraint());
482 }
483
484 void NetworkCm02Link::updateBandwidth(double value) {
485
486   m_bandwidth.peak = value;
487
488   lmm_update_constraint_bound(getModel()->getMaxminSystem(), getConstraint(),
489       sg_bandwidth_factor * (m_bandwidth.peak * m_bandwidth.scale));
490   TRACE_surf_link_set_bandwidth(surf_get_clock(), getName(), sg_bandwidth_factor * m_bandwidth.peak * m_bandwidth.scale);
491
492   if (sg_weight_S_parameter > 0) {
493     double delta = sg_weight_S_parameter / value - sg_weight_S_parameter / (m_bandwidth.peak * m_bandwidth.scale);
494
495     lmm_variable_t var;
496     lmm_element_t elem = NULL, nextelem = NULL;
497     int numelem = 0;
498     while ((var = lmm_get_var_from_cnst_safe(getModel()->getMaxminSystem(), getConstraint(), &elem, &nextelem, &numelem))) {
499       NetworkCm02Action *action = (NetworkCm02Action*) lmm_variable_id(var);
500       action->m_weight += delta;
501       if (!action->isSuspended())
502         lmm_update_variable_weight(getModel()->getMaxminSystem(), action->getVariable(), action->m_weight);
503     }
504   }
505 }
506
507 void NetworkCm02Link::updateLatency(double value){
508   double delta = value - m_latency.peak;
509   lmm_variable_t var = NULL;
510   lmm_element_t elem = NULL;
511   lmm_element_t nextelem = NULL;
512   int numelem = 0;
513
514   m_latency.peak = value;
515
516   while ((var = lmm_get_var_from_cnst_safe(getModel()->getMaxminSystem(), getConstraint(), &elem, &nextelem, &numelem))) {
517     NetworkCm02Action *action = (NetworkCm02Action*) lmm_variable_id(var);
518     action->m_latCurrent += delta;
519     action->m_weight += delta;
520     if (action->m_rate < 0)
521       lmm_update_variable_bound(getModel()->getMaxminSystem(), action->getVariable(), sg_tcp_gamma / (2.0 * action->m_latCurrent));
522     else {
523       lmm_update_variable_bound(getModel()->getMaxminSystem(), action->getVariable(),
524                                 std::min(action->m_rate, sg_tcp_gamma / (2.0 * action->m_latCurrent)));
525
526       if (action->m_rate < sg_tcp_gamma / (2.0 * action->m_latCurrent)) {
527         XBT_INFO("Flow is limited BYBANDWIDTH");
528       } else {
529         XBT_INFO("Flow is limited BYLATENCY, latency of flow is %f", action->m_latCurrent);
530       }
531     }
532     if (!action->isSuspended())
533       lmm_update_variable_weight(getModel()->getMaxminSystem(), action->getVariable(), action->m_weight);
534   }
535 }
536
537 /**********
538  * Action *
539  **********/
540 void NetworkCm02Action::updateRemainingLazy(double now)
541 {
542   double delta = 0.0;
543
544   if (m_suspended != 0)
545     return;
546
547   delta = now - m_lastUpdate;
548
549   if (m_remains > 0) {
550     XBT_DEBUG("Updating action(%p): remains was %f, last_update was: %f", this, m_remains, m_lastUpdate);
551     double_update(&(m_remains), m_lastValue * delta, sg_maxmin_precision*sg_surf_precision);
552
553     XBT_DEBUG("Updating action(%p): remains is now %f", this, m_remains);
554   }
555
556   if (m_maxDuration != NO_MAX_DURATION)
557     double_update(&m_maxDuration, delta, sg_surf_precision);
558
559   if (m_remains <= 0 &&
560       (lmm_get_variable_weight(getVariable()) > 0)) {
561     finish();
562     setState(SURF_ACTION_DONE);
563
564     heapRemove(getModel()->getActionHeap());
565   } else if (((m_maxDuration != NO_MAX_DURATION)
566       && (m_maxDuration <= 0))) {
567     finish();
568     setState(SURF_ACTION_DONE);
569     heapRemove(getModel()->getActionHeap());
570   }
571
572   m_lastUpdate = now;
573   m_lastValue = lmm_variable_getvalue(getVariable());
574 }
575
576 }
577 }